linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: Fixes tag needs some work in the bpf-next tree
@ 2019-08-16 13:46 Stephen Rothwell
  2019-08-16 14:35 ` Quentin Monnet
  0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2019-08-16 13:46 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Quentin Monnet, Alexei Starovoitov

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

Hi all,

In commit

  ed4a3983cd3e ("tools: bpftool: fix argument for p_err() in BTF do_dump()")

Fixes tag

  Fixes: c93cc69004dt ("bpftool: add ability to dump BTF types")

has these problem(s):

  - missing space between the SHA1 and the subject

This is dues to the trailing 't' on the SHA1 :-(

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Fixes tag needs some work in the bpf-next tree
  2019-08-16 13:46 linux-next: Fixes tag needs some work in the bpf-next tree Stephen Rothwell
@ 2019-08-16 14:35 ` Quentin Monnet
  0 siblings, 0 replies; 9+ messages in thread
From: Quentin Monnet @ 2019-08-16 14:35 UTC (permalink / raw)
  To: Stephen Rothwell, Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

2019-08-16 23:46 UTC+1000 ~ Stephen Rothwell <sfr@canb.auug.org.au>
> Hi all,
> 
> In commit
> 
>   ed4a3983cd3e ("tools: bpftool: fix argument for p_err() in BTF do_dump()")
> 
> Fixes tag
> 
>   Fixes: c93cc69004dt ("bpftool: add ability to dump BTF types")
> 
> has these problem(s):
> 
>   - missing space between the SHA1 and the subject
> 
> This is dues to the trailing 't' on the SHA1 :-(
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
> 

Hi Stephen,

I made that typo, please accept my apologies :(.

The correct tag should be:

  Fixes: c93cc69004df ("bpftool: add ability to dump BTF types")

Regards,
Quentin

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Fixes tag needs some work in the bpf-next tree
  2022-08-24 17:04 ` Kumar Kartikeya Dwivedi
@ 2022-08-25  0:56   ` Alexei Starovoitov
  0 siblings, 0 replies; 9+ messages in thread
From: Alexei Starovoitov @ 2022-08-25  0:56 UTC (permalink / raw)
  To: Kumar Kartikeya Dwivedi
  Cc: Stephen Rothwell, Daniel Borkmann, Alexei Starovoitov,
	Andrii Nakryiko, bpf, Networking, Linux Kernel Mailing List,
	Linux Next Mailing List

On Wed, Aug 24, 2022 at 10:05 AM Kumar Kartikeya Dwivedi
<memxor@gmail.com> wrote:
>
> On Wed, 24 Aug 2022 at 07:00, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > In commit
> >
> >   2e5e0e8ede02 ("bpf: Fix reference state management for synchronous callbacks")
> >
> > Fixes tag
> >
> >   Fixes: 69c87ba6225 ("bpf: Add bpf_for_each_map_elem() helper")
> >
> > has these problem(s):
> >
> >   - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: 69c087ba6225 ("bpf: Add bpf_for_each_map_elem() helper")
> >
>
> Ugh, really sorry, I must have fat fingered and pressed 'x' in vim
> while editing the commit message. I always generate these using a git
> fixes alias.

Since that was caught quickly there weren't that many commits on top.
Fixed and force pushed bpf-next.

We actually have a script that checks such sha-s. Not sure how we missed it.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Fixes tag needs some work in the bpf-next tree
  2022-08-24  5:00 Stephen Rothwell
@ 2022-08-24 17:04 ` Kumar Kartikeya Dwivedi
  2022-08-25  0:56   ` Alexei Starovoitov
  0 siblings, 1 reply; 9+ messages in thread
From: Kumar Kartikeya Dwivedi @ 2022-08-24 17:04 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Daniel Borkmann, Alexei Starovoitov, Andrii Nakryiko, bpf,
	Networking, Linux Kernel Mailing List, Linux Next Mailing List

On Wed, 24 Aug 2022 at 07:00, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   2e5e0e8ede02 ("bpf: Fix reference state management for synchronous callbacks")
>
> Fixes tag
>
>   Fixes: 69c87ba6225 ("bpf: Add bpf_for_each_map_elem() helper")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 69c087ba6225 ("bpf: Add bpf_for_each_map_elem() helper")
>

Ugh, really sorry, I must have fat fingered and pressed 'x' in vim
while editing the commit message. I always generate these using a git
fixes alias.

> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 9+ messages in thread

* linux-next: Fixes tag needs some work in the bpf-next tree
@ 2022-08-24  5:00 Stephen Rothwell
  2022-08-24 17:04 ` Kumar Kartikeya Dwivedi
  0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2022-08-24  5:00 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Andrii Nakryiko, bpf, Networking
  Cc: Kumar Kartikeya Dwivedi, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

Hi all,

In commit

  2e5e0e8ede02 ("bpf: Fix reference state management for synchronous callbacks")

Fixes tag

  Fixes: 69c87ba6225 ("bpf: Add bpf_for_each_map_elem() helper")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 69c087ba6225 ("bpf: Add bpf_for_each_map_elem() helper")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* linux-next: Fixes tag needs some work in the bpf-next tree
@ 2022-03-17 21:14 Stephen Rothwell
  0 siblings, 0 replies; 9+ messages in thread
From: Stephen Rothwell @ 2022-03-17 21:14 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Andrii Nakryiko, bpf, Networking
  Cc: Kaixi Fan, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Hi all,

In commit

  a50cbac6d81a ("selftests/bpf: Fix tunnel remote IP comments")

Fixes tag

  Fixes: 933a741e ("selftests/bpf: bpf tunnel test.")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Fixes tag needs some work in the bpf-next tree
  2021-10-07 21:31 Stephen Rothwell
@ 2021-10-07 21:56 ` Daniel Borkmann
  0 siblings, 0 replies; 9+ messages in thread
From: Daniel Borkmann @ 2021-10-07 21:56 UTC (permalink / raw)
  To: Stephen Rothwell, Alexei Starovoitov, Networking
  Cc: Johan Almbladh, David Miller, Jakub Kicinski,
	Linux Kernel Mailing List, Linux Next Mailing List

On 10/7/21 11:31 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    065485ac5e86 ("mips, bpf: Fix Makefile that referenced a removed file")
> 
> Fixes tag
> 
>    Fixes: 06b339fe5450 ("mips, bpf: Remove old BPF JIT implementations")
> 
> has these problem(s):
> 
>    - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: ebcbacfa50ec ("mips, bpf: Remove old BPF JIT implementations")

Yeah, Fixes tag was incorrect. Fixed up now, thanks for the heads up!

^ permalink raw reply	[flat|nested] 9+ messages in thread

* linux-next: Fixes tag needs some work in the bpf-next tree
@ 2021-10-07 21:31 Stephen Rothwell
  2021-10-07 21:56 ` Daniel Borkmann
  0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2021-10-07 21:31 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Johan Almbladh, David Miller, Jakub Kicinski,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

Hi all,

In commit

  065485ac5e86 ("mips, bpf: Fix Makefile that referenced a removed file")

Fixes tag

  Fixes: 06b339fe5450 ("mips, bpf: Remove old BPF JIT implementations")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: ebcbacfa50ec ("mips, bpf: Remove old BPF JIT implementations")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* linux-next: Fixes tag needs some work in the bpf-next tree
@ 2020-08-01 11:00 Stephen Rothwell
  0 siblings, 0 replies; 9+ messages in thread
From: Stephen Rothwell @ 2020-08-01 11:00 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jerry Crunchtime

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Hi all,

In commit

  1acf8f90ea7e ("libbpf: Fix register in PT_REGS MIPS macros")

Fixes tag

  Fixes: c1932cd ("bpf: Add MIPS support to samples/bpf.")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-08-25  0:56 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-16 13:46 linux-next: Fixes tag needs some work in the bpf-next tree Stephen Rothwell
2019-08-16 14:35 ` Quentin Monnet
2020-08-01 11:00 Stephen Rothwell
2021-10-07 21:31 Stephen Rothwell
2021-10-07 21:56 ` Daniel Borkmann
2022-03-17 21:14 Stephen Rothwell
2022-08-24  5:00 Stephen Rothwell
2022-08-24 17:04 ` Kumar Kartikeya Dwivedi
2022-08-25  0:56   ` Alexei Starovoitov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).