From: Tal Shorer <tal.shorer@gmail.com>
To: tj@kernel.org
Cc: sfr@canb.auug.org.au, tglx@linutronix.de, mingo@elte.hu,
hpa@zytor.com, peterz@infradead.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, tal.shorer@gmail.com,
frederic@kernel.org
Subject: [PATCH v3 2/2] workqueue: respect isolated cpus when queueing an unbound work
Date: Fri, 3 Nov 2017 17:27:50 +0200 [thread overview]
Message-ID: <1509722870-27618-2-git-send-email-tal.shorer@gmail.com> (raw)
In-Reply-To: <1509722870-27618-1-git-send-email-tal.shorer@gmail.com>
Initialize wq_unbound_cpumask to exclude cpus that were isolated by
the cmdline's isolcpus parameter.
Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
---
kernel/workqueue.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 64d0edf..a355e9d 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -48,6 +48,7 @@
#include <linux/nodemask.h>
#include <linux/moduleparam.h>
#include <linux/uaccess.h>
+#include <linux/sched/isolation.h>
#include "workqueue_internal.h"
@@ -4980,6 +4981,10 @@ int workqueue_set_unbound_cpumask(cpumask_var_t cpumask)
if (!zalloc_cpumask_var(&saved_cpumask, GFP_KERNEL))
return -ENOMEM;
+ /*
+ * Not excluding isolated cpus on purpose.
+ * If the user wishes to include them, we allow that.
+ */
cpumask_and(cpumask, cpumask, cpu_possible_mask);
if (!cpumask_empty(cpumask)) {
apply_wqattrs_lock();
@@ -5579,7 +5584,7 @@ int __init workqueue_init_early(void)
WARN_ON(__alignof__(struct pool_workqueue) < __alignof__(long long));
BUG_ON(!alloc_cpumask_var(&wq_unbound_cpumask, GFP_KERNEL));
- cpumask_copy(wq_unbound_cpumask, cpu_possible_mask);
+ cpumask_copy(wq_unbound_cpumask, housekeeping_cpumask(HK_FLAG_DOMAIN));
pwq_cache = KMEM_CACHE(pool_workqueue, SLAB_PANIC);
--
2.7.4
next prev parent reply other threads:[~2017-11-03 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 3:34 linux-next: build failure after merge of the workqueues tree Stephen Rothwell
2017-11-03 13:59 ` Tejun Heo
2017-11-03 15:27 ` [PATCH v3 1/2] main: kernel_start: move housekeeping_init() before workqueue_init_early() Tal Shorer
2017-11-03 15:27 ` Tal Shorer [this message]
2017-11-06 15:26 ` [PATCH v3 2/2] workqueue: respect isolated cpus when queueing an unbound work Tejun Heo
2017-11-27 16:57 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509722870-27618-2-git-send-email-tal.shorer@gmail.com \
--to=tal.shorer@gmail.com \
--cc=frederic@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).