Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Bart Van Assche <bvanassche@acm.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: linux-next: build warning after merge of the scsi tree
Date: Thu, 04 Apr 2019 21:52:49 -0700
Message-ID: <1554439969.24612.41.camel@HansenPartnership.com> (raw)
In-Reply-To: <a1d4b608-a077-a757-9407-5cde4681e3af@acm.org>

On Thu, 2019-04-04 at 21:30 -0700, Bart Van Assche wrote:
> On 4/4/19 8:25 PM, Stephen Rothwell wrote:
> > Hi James,
> > 
> > After merging the scsi tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > drivers/scsi/lpfc/lpfc_nvme.c:2140:1: warning:
> > 'lpfc_nvme_lport_unreg_wait' defined but not used [-Wunused-
> > function]
> >   lpfc_nvme_lport_unreg_wait(struct lpfc_vport *vport,
> >   ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > Introduced by commit
> > 
> >    3999df75bccb ("scsi: lpfc: Declare local functions static")
> > 
> > It use is guarded by IS_ENABLED(CONFIG_NVME_FC).
> 
> I will have a closer look at this tomorrow.

In the meantime, we can just revert the patch.  Making functions static
serves no real purpose except it does tell the compiler they have to be
used internally which is where the problem is coming from.  Once the
issue is sorted, the static patch can be reapplied.

James

  reply index

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-05  3:25 Stephen Rothwell
2019-04-05  4:30 ` Bart Van Assche
2019-04-05  4:52   ` James Bottomley [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-11-07  4:01 Stephen Rothwell
2019-11-07 15:51 ` Bart Van Assche
2019-11-08 23:02   ` James Smart
2019-06-20  6:10 Stephen Rothwell
2019-05-31  3:36 Stephen Rothwell
2019-06-03 20:29 ` Tyrel Datwyler
2019-06-03 23:37 ` Tyrel Datwyler
2018-10-19  4:50 Stephen Rothwell
2018-10-19  4:54 ` James Bottomley
2018-10-19  4:58   ` Stephen Rothwell
     [not found] <20180620132911.5f6ab464@canb.auug.org.au>
2018-07-10  7:31 ` Stephen Rothwell
2018-07-10 14:09   ` Jens Axboe
2018-07-10 14:14     ` James Bottomley
2018-07-10 14:22       ` Jens Axboe
2018-07-10 14:26         ` James Bottomley
2018-07-10 14:35           ` Jens Axboe
2018-07-10 15:08             ` Martin K. Petersen
2018-04-17  2:25 Stephen Rothwell
2018-04-18 21:52 ` Long Li
2018-04-18 23:30   ` Martin K. Petersen
2017-04-06  4:04 Stephen Rothwell
2017-04-06  8:18 ` Fam Zheng
2016-11-22  7:44 Stephen Rothwell
2016-11-22 22:24 ` Martin K. Petersen
2016-09-13  4:15 Stephen Rothwell
2016-09-13 14:09 ` Bryant G. Ly
2016-09-15 13:55   ` Martin K. Petersen
2014-11-18  8:21 Stephen Rothwell
2014-11-20  8:23 ` Christoph Hellwig
2013-09-02  8:28 Stephen Rothwell
2013-09-04  9:18 ` Sujit Reddy Thumma
2013-09-04  9:54   ` Sujit Reddy Thumma
2011-07-20  4:08 Stephen Rothwell
     [not found] <20110518114912.dfdf8835.sfr@canb.auug.org.au>
2011-05-18  2:06 ` Nicholas A. Bellinger
2011-05-18  3:58   ` Stephen Rothwell
2011-05-19  2:54     ` Nicholas A. Bellinger
2011-05-19 16:18       ` Kiran Patil
2011-05-19 16:22     ` Geert Uytterhoeven
2011-06-23 17:02       ` Randy Dunlap
2010-08-04  3:13 Stephen Rothwell
2010-08-04  4:17 ` James Bottomley
2010-02-10  5:51 Stephen Rothwell
2010-02-10 22:13 ` James Bottomley

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1554439969.24612.41.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git