From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: linux-next: build warning after merge of the scsi tree Date: Thu, 04 Apr 2019 21:52:49 -0700 Message-ID: <1554439969.24612.41.camel@HansenPartnership.com> References: <20190405142347.1f264cdf@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Bart Van Assche , Stephen Rothwell Cc: Linux Next Mailing List , Linux Kernel Mailing List , "Martin K. Petersen" List-Id: linux-next.vger.kernel.org On Thu, 2019-04-04 at 21:30 -0700, Bart Van Assche wrote: > On 4/4/19 8:25 PM, Stephen Rothwell wrote: > > Hi James, > > > > After merging the scsi tree, today's linux-next build (powerpc > > ppc64_defconfig) produced this warning: > > > > drivers/scsi/lpfc/lpfc_nvme.c:2140:1: warning: > > 'lpfc_nvme_lport_unreg_wait' defined but not used [-Wunused- > > function] > > lpfc_nvme_lport_unreg_wait(struct lpfc_vport *vport, > > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > Introduced by commit > > > > 3999df75bccb ("scsi: lpfc: Declare local functions static") > > > > It use is guarded by IS_ENABLED(CONFIG_NVME_FC). > > I will have a closer look at this tomorrow. In the meantime, we can just revert the patch. Making functions static serves no real purpose except it does tell the compiler they have to be used internally which is where the problem is coming from. Once the issue is sorted, the static patch can be reapplied. James