* [PATCH 0/2] iio: adc: stm32-dfsdm: fix build dependencies
@ 2019-04-15 13:00 Fabrice Gasnier
2019-04-15 13:00 ` [PATCH 1/2] iio: adc: stm32-dfsdm: fix unmet direct dependencies detected Fabrice Gasnier
2019-04-15 13:00 ` [PATCH 2/2] iio: adc: stm32-dfsdm: fix triggered buffer build dependency Fabrice Gasnier
0 siblings, 2 replies; 5+ messages in thread
From: Fabrice Gasnier @ 2019-04-15 13:00 UTC (permalink / raw)
To: jic23, rdunlap
Cc: sfr, benjamin.gaignard, linux-next, linux-arm-kernel,
linux-kernel, mcoquelin.stm32, alexandre.torgue, fabrice.gasnier,
linux-iio, lars, knaack.h, pmeerw, linux-stm32, arnaud.pouliquen,
olivier.moysan
This series fixes two build dependencies:
- IIO_BUFFER needs to be selected along with IIO_BUFFER_HW_CONSUMER
- IIO_TRIGGERED_BUFFER needs to be selected now that it supports triggered
buffer mode.
Fabrice Gasnier (2):
iio: adc: stm32-dfsdm: fix unmet direct dependencies detected
iio: adc: stm32-dfsdm: fix triggered buffer build dependency
drivers/iio/adc/Kconfig | 2 ++
1 file changed, 2 insertions(+)
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] iio: adc: stm32-dfsdm: fix unmet direct dependencies detected
2019-04-15 13:00 [PATCH 0/2] iio: adc: stm32-dfsdm: fix build dependencies Fabrice Gasnier
@ 2019-04-15 13:00 ` Fabrice Gasnier
2019-04-22 10:16 ` Jonathan Cameron
2019-04-15 13:00 ` [PATCH 2/2] iio: adc: stm32-dfsdm: fix triggered buffer build dependency Fabrice Gasnier
1 sibling, 1 reply; 5+ messages in thread
From: Fabrice Gasnier @ 2019-04-15 13:00 UTC (permalink / raw)
To: jic23, rdunlap
Cc: sfr, benjamin.gaignard, linux-next, linux-arm-kernel,
linux-kernel, mcoquelin.stm32, alexandre.torgue, fabrice.gasnier,
linux-iio, lars, knaack.h, pmeerw, linux-stm32, arnaud.pouliquen,
olivier.moysan
This fixes unmet direct dependencies seen when CONFIG_STM32_DFSDM_ADC
is selected:
WARNING: unmet direct dependencies detected for IIO_BUFFER_HW_CONSUMER
Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
Selected by [y]:
- STM32_DFSDM_ADC [=y] && IIO [=y] && (ARCH_STM32 [=y] && OF [=y] ||
COMPILE_TEST [=n])
Fixes: e2e6771c6462 ("IIO: ADC: add STM32 DFSDM sigma delta ADC support")
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
drivers/iio/adc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 846c7ac..b1b2bde 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -821,6 +821,7 @@ config STM32_DFSDM_ADC
depends on (ARCH_STM32 && OF) || COMPILE_TEST
select STM32_DFSDM_CORE
select REGMAP_MMIO
+ select IIO_BUFFER
select IIO_BUFFER_HW_CONSUMER
help
Select this option to support ADCSigma delta modulator for
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] iio: adc: stm32-dfsdm: fix triggered buffer build dependency
2019-04-15 13:00 [PATCH 0/2] iio: adc: stm32-dfsdm: fix build dependencies Fabrice Gasnier
2019-04-15 13:00 ` [PATCH 1/2] iio: adc: stm32-dfsdm: fix unmet direct dependencies detected Fabrice Gasnier
@ 2019-04-15 13:00 ` Fabrice Gasnier
2019-04-22 10:17 ` Jonathan Cameron
1 sibling, 1 reply; 5+ messages in thread
From: Fabrice Gasnier @ 2019-04-15 13:00 UTC (permalink / raw)
To: jic23, rdunlap
Cc: sfr, benjamin.gaignard, linux-next, linux-arm-kernel,
linux-kernel, mcoquelin.stm32, alexandre.torgue, fabrice.gasnier,
linux-iio, lars, knaack.h, pmeerw, linux-stm32, arnaud.pouliquen,
olivier.moysan
This fixes build errors seen when CONFIG_STM32_DFSDM_ADC is set, as
stm32-dfsdm-adc driver now also relies on triggered buffer API:
Fixes: 11646e81d775 ("iio: adc: stm32-dfsdm: add support for buffer modes")
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
drivers/iio/adc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index b1b2bde..f3bd32e 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -823,6 +823,7 @@ config STM32_DFSDM_ADC
select REGMAP_MMIO
select IIO_BUFFER
select IIO_BUFFER_HW_CONSUMER
+ select IIO_TRIGGERED_BUFFER
help
Select this option to support ADCSigma delta modulator for
STMicroelectronics STM32 digital filter for sigma delta converter.
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] iio: adc: stm32-dfsdm: fix unmet direct dependencies detected
2019-04-15 13:00 ` [PATCH 1/2] iio: adc: stm32-dfsdm: fix unmet direct dependencies detected Fabrice Gasnier
@ 2019-04-22 10:16 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2019-04-22 10:16 UTC (permalink / raw)
To: Fabrice Gasnier
Cc: rdunlap, sfr, benjamin.gaignard, linux-next, linux-arm-kernel,
linux-kernel, mcoquelin.stm32, alexandre.torgue, linux-iio, lars,
knaack.h, pmeerw, linux-stm32, arnaud.pouliquen, olivier.moysan
On Mon, 15 Apr 2019 15:00:50 +0200
Fabrice Gasnier <fabrice.gasnier@st.com> wrote:
> This fixes unmet direct dependencies seen when CONFIG_STM32_DFSDM_ADC
> is selected:
>
> WARNING: unmet direct dependencies detected for IIO_BUFFER_HW_CONSUMER
> Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
> Selected by [y]:
> - STM32_DFSDM_ADC [=y] && IIO [=y] && (ARCH_STM32 [=y] && OF [=y] ||
> COMPILE_TEST [=n])
>
> Fixes: e2e6771c6462 ("IIO: ADC: add STM32 DFSDM sigma delta ADC support")
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Hmm. I wonder how we never got this one from a rand config.
Anyhow, give we are near the end of this cycle, I'll take this for
the next merge window rather than rushing it through.
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 846c7ac..b1b2bde 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -821,6 +821,7 @@ config STM32_DFSDM_ADC
> depends on (ARCH_STM32 && OF) || COMPILE_TEST
> select STM32_DFSDM_CORE
> select REGMAP_MMIO
> + select IIO_BUFFER
> select IIO_BUFFER_HW_CONSUMER
> help
> Select this option to support ADCSigma delta modulator for
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] iio: adc: stm32-dfsdm: fix triggered buffer build dependency
2019-04-15 13:00 ` [PATCH 2/2] iio: adc: stm32-dfsdm: fix triggered buffer build dependency Fabrice Gasnier
@ 2019-04-22 10:17 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2019-04-22 10:17 UTC (permalink / raw)
To: Fabrice Gasnier
Cc: rdunlap, sfr, benjamin.gaignard, linux-next, linux-arm-kernel,
linux-kernel, mcoquelin.stm32, alexandre.torgue, linux-iio, lars,
knaack.h, pmeerw, linux-stm32, arnaud.pouliquen, olivier.moysan
On Mon, 15 Apr 2019 15:00:51 +0200
Fabrice Gasnier <fabrice.gasnier@st.com> wrote:
> This fixes build errors seen when CONFIG_STM32_DFSDM_ADC is set, as
> stm32-dfsdm-adc driver now also relies on triggered buffer API:
>
> Fixes: 11646e81d775 ("iio: adc: stm32-dfsdm: add support for buffer modes")
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index b1b2bde..f3bd32e 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -823,6 +823,7 @@ config STM32_DFSDM_ADC
> select REGMAP_MMIO
> select IIO_BUFFER
> select IIO_BUFFER_HW_CONSUMER
> + select IIO_TRIGGERED_BUFFER
> help
> Select this option to support ADCSigma delta modulator for
> STMicroelectronics STM32 digital filter for sigma delta converter.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-22 10:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-15 13:00 [PATCH 0/2] iio: adc: stm32-dfsdm: fix build dependencies Fabrice Gasnier
2019-04-15 13:00 ` [PATCH 1/2] iio: adc: stm32-dfsdm: fix unmet direct dependencies detected Fabrice Gasnier
2019-04-22 10:16 ` Jonathan Cameron
2019-04-15 13:00 ` [PATCH 2/2] iio: adc: stm32-dfsdm: fix triggered buffer build dependency Fabrice Gasnier
2019-04-22 10:17 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).