linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Christie <michael.christie@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warnings after merge of the scsi-mkp tree
Date: Mon, 16 Oct 2023 10:25:14 -0500	[thread overview]
Message-ID: <1676c7c1-902b-4604-b411-b313c529c3de@oracle.com> (raw)
In-Reply-To: <20231016160616.0286cf0c@canb.auug.org.au>

On 10/16/23 12:06 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the scsi-mkp tree, today's linux-next build (htmldocs)
> produced thess warnings:
> 
> drivers/target/target_core_transport.c:1930: warning: Function parameter or member 'se_cmd' not described in 'target_submit'
> drivers/target/target_core_transport.c:1930: warning: Excess function parameter 'cmd' description in 'target_submit'
> 

I missed fixing up the param name when I merged some functions. I need
the patch below.


Martin, because this is only in your 6.7 scsi-staging branch, should I
re-send the entire patcheset with this patch merged into
("scsi: target: Allow userspace to request direct submissions")?

Or do you want me to just send the patch below against 6.7 scsi-staging?


diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index c81def3c96df..670cfb7bd426 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -1921,7 +1921,7 @@ static void target_queue_submission(struct se_cmd *se_cmd)
 
 /**
  * target_submit - perform final initialization and submit cmd to LIO core
- * @cmd: command descriptor to submit
+ * @se_cmd: command descriptor to submit
  *
  * target_submit_prep or something similar must have been called on the cmd,
  * and this must be called from process context.


  reply	other threads:[~2023-10-16 15:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16  5:06 linux-next: build warnings after merge of the scsi-mkp tree Stephen Rothwell
2023-10-16 15:25 ` Mike Christie [this message]
2023-10-17  0:27   ` Martin K. Petersen
  -- strict thread matches above, loose matches on Subject: below --
2021-03-03  6:03 Stephen Rothwell
2021-04-21  6:03 ` Stephen Rothwell
2018-02-13  3:00 Stephen Rothwell
2017-06-28  5:55 Stephen Rothwell
2017-06-29  5:07 ` Stephen Rothwell
2017-06-29 18:35   ` Madhani, Himanshu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1676c7c1-902b-4604-b411-b313c529c3de@oracle.com \
    --to=michael.christie@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).