From: Fabian Frederick <fabf@skynet.be>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Arnd Bergmann <arnd@arndb.de>, Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the char-misc tree
Date: Tue, 31 Mar 2015 21:35:45 +0200 (CEST) [thread overview]
Message-ID: <18153784.217855.1427830545058.open-xchange@webmail.nmp.proximus.be> (raw)
In-Reply-To: <20150327184835.6b214809@canb.auug.org.au>
> On 27 March 2015 at 08:48 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
>
> Hi all,
>
> After merging the char-misc tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
>
> In file included from include/linux/module.h:17:0,
> from drivers/uio/uio_pdrv_genirq.c:21:
> include/linux/moduleparam.h:326:22: warning: initialization discards 'const'
> qualifier from pointer target type
> static const struct kparam_string __param_string_##name \
> ^
> drivers/uio/uio_pdrv_genirq.c:260:1: note: in expansion of macro
> 'module_param_string'
> module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
> ^
>
> Introduced by commit 4d8beff2ae07 ("uio: constify of_device_id array").
Hi Stephen,
Absolutely, my patch is wrong ; comment below explains struct is filled
afterwards.Sorry.
Greg, should I send you a revert or maybe we could standardize that driver ? (it
seems it's the only one to work that way).
static const struct of_device_id uio_of_genirq_match[] = {
{ /* This is filled with module_parm */ },
{ /* Sentinel */ },
};
Regards,
Fabian
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
next prev parent reply other threads:[~2015-03-31 19:35 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 7:48 linux-next: build warning after merge of the char-misc tree Stephen Rothwell
2015-03-31 19:35 ` Fabian Frederick [this message]
2015-04-03 14:05 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2024-04-15 5:22 Stephen Rothwell
2024-04-15 7:21 ` Greg KH
2022-07-15 11:43 Stephen Rothwell
2021-05-24 6:19 Stephen Rothwell
2021-04-06 11:44 Stephen Rothwell
2021-04-06 11:46 ` Stephen Rothwell
2021-04-06 14:07 ` Greg KH
2021-04-06 14:13 ` Gustavo Pimentel
2021-04-06 14:15 ` Greg KH
2021-04-06 17:28 ` Gustavo Pimentel
2021-04-06 17:33 ` Greg KH
2021-01-29 7:07 Stephen Rothwell
2020-05-01 6:28 Stephen Rothwell
2020-05-01 6:55 ` Greg KH
2020-05-01 10:17 ` Rajan Vaja
2019-04-26 5:56 Stephen Rothwell
2019-04-26 6:25 ` Greg KH
2019-04-26 14:30 ` Patrick Venture
2019-04-26 18:00 ` Patrick Venture
2018-10-02 9:12 Stephen Rothwell
2018-10-02 9:49 ` Bartosz Golaszewski
2018-10-02 9:56 ` Srinivas Kandagatla
2018-10-02 10:04 ` Bartosz Golaszewski
2018-10-02 5:31 Stephen Rothwell
2018-10-02 8:34 ` Bartosz Golaszewski
2017-12-12 3:39 Stephen Rothwell
2017-12-12 11:49 ` Greg KH
2017-07-20 4:12 Stephen Rothwell
2017-07-20 5:13 ` Greg KH
2017-07-20 14:52 ` KY Srinivasan
2017-07-20 9:14 ` Greg KH
2017-03-28 3:31 Stephen Rothwell
2017-03-28 3:58 ` Masahiro Yamada
2013-02-15 5:26 Stephen Rothwell
2013-02-15 17:34 ` Greg KH
2013-02-15 18:07 ` Arnd Bergmann
2013-02-15 20:05 ` Arnd Bergmann
2013-03-01 15:51 ` Sedat Dilek
2013-03-01 17:16 ` Arnd Bergmann
2013-03-01 17:43 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18153784.217855.1427830545058.open-xchange@webmail.nmp.proximus.be \
--to=fabf@skynet.be \
--cc=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).