linux-next: powercp-next build failure

linux-next: powercp-next build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

Hi Paul,

Today's linux-next build (sparc64 defconfig) fails like this:

drivers/of/device.c: In function `modalias_show':
drivers/of/device.c:66: error: implicit declaration of function `of_device_get_modalias'

Caused by commit 140b932f8cb6cced10b96860651a198b1b89cbb9 ("[POWERPC]
Create modalias file in sysfs for of_platform bus") from the powerpc-next
tree as there is a definition and declaration of of_device_get_modalias
only for powerpc.  I reverted that commit for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: linux-next: powercp-next build failure

[Olaf Hering]

On Thu, May 15, Stephen Rothwell wrote:

> Today's linux-next build (sparc64 defconfig) fails like this:
> 
> drivers/of/device.c: In function `modalias_show':
> drivers/of/device.c:66: error: implicit declaration of function `of_device_get_modalias'
> 
> Caused by commit 140b932f8cb6cced10b96860651a198b1b89cbb9 ("[POWERPC]
> Create modalias file in sysfs for of_platform bus") from the powerpc-next
> tree as there is a definition and declaration of of_device_get_modalias
> only for powerpc.  I reverted that commit for today.

Better fix it up because my patch was for 2.6.25, and I cant follow
mainline due to time constraints.

Re: linux-next: powercp-next build failure

[Paul Mackerras]

> drivers/of/device.c: In function `modalias_show':
> drivers/of/device.c:66: error: implicit declaration of function `of_device_get_modalias'

Dave, how would you prefer to fix this?  We could move
of_device_get_modalias into drivers/of/device.c, or I could simply
revert that commit.

Paul.

Re: linux-next: powercp-next build failure

[David Miller]

From: Paul Mackerras <paulus@samba.org>
Date: Thu, 15 May 2008 19:24:23 +1000

> > drivers/of/device.c: In function `modalias_show':
> > drivers/of/device.c:66: error: implicit declaration of function `of_device_get_modalias'
> 
> Dave, how would you prefer to fix this?  We could move
> of_device_get_modalias into drivers/of/device.c, or I could simply
> revert that commit.

Feel free to move that function into drivers/of/device.c