Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build warning after merge of the arm-soc tree
@ 2021-04-06  0:45 Stephen Rothwell
  2021-04-06  6:34 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2021-04-06  0:45 UTC (permalink / raw)
  To: Olof Johansson, Arnd Bergmann, ARM
  Cc: Dinh Nguyen, Krzysztof Kozlowski, Linux Kernel Mailing List,
	Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

Hi all,

After merging the arm-soc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/clk/socfpga/clk-gate.c: In function 'socfpga_clk_recalc_rate':
drivers/clk/socfpga/clk-gate.c:102:7: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  102 |   if ((int) socfpgaclk->div_reg & SOCFPGA_GPIO_DB_CLK_OFFSET)
      |       ^

Exposed by commit

  cdb1e8b4f4c2 ("clk: socfpga: allow compile testing of Stratix 10 / Agilex clocks")
  552418658acd ("clk: socfpga: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs (and compile test)")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: build warning after merge of the arm-soc tree
  2021-04-06  0:45 linux-next: build warning after merge of the arm-soc tree Stephen Rothwell
@ 2021-04-06  6:34 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2021-04-06  6:34 UTC (permalink / raw)
  To: Stephen Rothwell, Olof Johansson, Arnd Bergmann, ARM
  Cc: Dinh Nguyen, Linux Kernel Mailing List, Linux Next Mailing List


On 06/04/2021 02:45, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the arm-soc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/clk/socfpga/clk-gate.c: In function 'socfpga_clk_recalc_rate':
> drivers/clk/socfpga/clk-gate.c:102:7: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>   102 |   if ((int) socfpgaclk->div_reg & SOCFPGA_GPIO_DB_CLK_OFFSET)
>       |       ^
> 
> Exposed by commit
> 
>   cdb1e8b4f4c2 ("clk: socfpga: allow compile testing of Stratix 10 / Agilex clocks")
>   552418658acd ("clk: socfpga: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs (and compile test)")
> 

Thanks Stephen. This is a result of compile testing and was already
fixed via clk tree. You should not have the warning after all the merges.

https://lore.kernel.org/lkml/20210314110709.32599-1-krzysztof.kozlowski@canonical.com/

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: build warning after merge of the arm-soc tree
@ 2019-08-15 23:25 Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2019-08-15 23:25 UTC (permalink / raw)
  To: Olof Johansson, Arnd Bergmann, ARM
  Cc: Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

Hi all,

After merging the arm-soc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/usb/gadget/udc/lpc32xx_udc.c: In function 'udc_pop_fifo':
drivers/usb/gadget/udc/lpc32xx_udc.c:1156:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  switch (((u32) data) & 0x3) {
           ^
drivers/usb/gadget/udc/lpc32xx_udc.c: In function 'udc_stuff_fifo':
drivers/usb/gadget/udc/lpc32xx_udc.c:1257:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  switch (((u32) data) & 0x3) {
           ^
drivers/usb/gadget/udc/lpc32xx_udc.c: In function 'udc_handle_ep0_setup':
drivers/usb/gadget/udc/lpc32xx_udc.c:2230:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
   switch (reqtype) {
   ^~~~~~
drivers/usb/gadget/udc/lpc32xx_udc.c:2269:2: note: here
  case USB_REQ_SET_ADDRESS:
  ^~~~

Exposed by commit

  50ad15282e7c ("usb: udc: lpc32xx: allow compile-testing")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: build warning after merge of the arm-soc tree
@ 2019-08-15 23:23 Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2019-08-15 23:23 UTC (permalink / raw)
  To: Olof Johansson, Arnd Bergmann, ARM
  Cc: Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 1686 bytes --]

Hi all,

After merging the arm-soc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/kernel.h:15,
                 from include/linux/list.h:9,
                 from include/linux/module.h:9,
                 from drivers/dma/iop-adma.c:13:
drivers/dma/iop-adma.c: In function '__iop_adma_slot_cleanup':
drivers/dma/iop-adma.c:118:12: warning: format '%x' expects argument of type 'unsigned int', but argument 6 has type 'dma_addr_t' {aka 'long long unsigned int'} [-Wformat=]
   pr_debug("\tcookie: %d slot: %d busy: %d "
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/printk.h:288:21: note: in definition of macro 'pr_fmt'
 #define pr_fmt(fmt) fmt
                     ^~~
include/linux/dynamic_debug.h:143:2: note: in expansion of macro '__dynamic_func_call'
  __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
  ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:153:2: note: in expansion of macro '_dynamic_func_call'
  _dynamic_func_call(fmt, __dynamic_pr_debug,  \
  ^~~~~~~~~~~~~~~~~~
include/linux/printk.h:336:2: note: in expansion of macro 'dynamic_pr_debug'
  dynamic_pr_debug(fmt, ##__VA_ARGS__)
  ^~~~~~~~~~~~~~~~
drivers/dma/iop-adma.c:118:3: note: in expansion of macro 'pr_debug'
   pr_debug("\tcookie: %d slot: %d busy: %d "
   ^~~~~~~~
drivers/dma/iop-adma.c:119:18: note: format string is defined here
    "this_desc: %#x next_desc: %#llx ack: %d\n",
                ~~^
                %#llx

Introduced (or exposed?) by commit

  00c9755524fb ("dmaengine: iop-adma: use correct printk format strings")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: build warning after merge of the arm-soc tree
  2019-05-03  6:49 ` Linus Walleij
@ 2019-05-03 12:57   ` Arnd Bergmann
  0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2019-05-03 12:57 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Stephen Rothwell, Olof Johansson, ARM, Linux Next Mailing List,
	Linux Kernel Mailing List

On Fri, May 3, 2019 at 2:49 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Tue, Apr 30, 2019 at 12:28 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > After merging the arm-soc tree, today's linux-next build
> > (x86_64 allmodconfig) produced this warning:
> >
> > drivers/clocksource/timer-ixp4xx.c:78:20: warning: 'ixp4xx_read_sched_clock' defined but not used [-Wunused-function]
> >  static u64 notrace ixp4xx_read_sched_clock(void)
> >                     ^~~~~~~~~~~~~~~~~~~~~~~
>
> This is kind of normal for timer drivers, as the sched_clock() call is #ifdef:ed
> for CONFIG_ARM, it is not uniformly available on all archs. This appears
> as a side effect of COMPILE_TEST which I think is fair to produce
> things like this.

Could you send a fixup patch to mark the function __maybe_unused or
move it into the #ifdef?

         Arnd

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: build warning after merge of the arm-soc tree
  2019-04-29 23:28 Stephen Rothwell
@ 2019-05-03  6:49 ` Linus Walleij
  2019-05-03 12:57   ` Arnd Bergmann
  0 siblings, 1 reply; 10+ messages in thread
From: Linus Walleij @ 2019-05-03  6:49 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Olof Johansson, Arnd Bergmann, ARM, Linux Next Mailing List,
	Linux Kernel Mailing List

On Tue, Apr 30, 2019 at 12:28 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the arm-soc tree, today's linux-next build
> (x86_64 allmodconfig) produced this warning:
>
> drivers/clocksource/timer-ixp4xx.c:78:20: warning: 'ixp4xx_read_sched_clock' defined but not used [-Wunused-function]
>  static u64 notrace ixp4xx_read_sched_clock(void)
>                     ^~~~~~~~~~~~~~~~~~~~~~~

This is kind of normal for timer drivers, as the sched_clock() call is #ifdef:ed
for CONFIG_ARM, it is not uniformly available on all archs. This appears
as a side effect of COMPILE_TEST which I think is fair to produce
things like this.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: build warning after merge of the arm-soc tree
@ 2019-04-29 23:28 Stephen Rothwell
  2019-05-03  6:49 ` Linus Walleij
  0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2019-04-29 23:28 UTC (permalink / raw)
  To: Olof Johansson, Arnd Bergmann, ARM
  Cc: Linus Walleij, Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1.1: Type: text/plain, Size: 451 bytes --]

Hi all,

After merging the arm-soc tree, today's linux-next build
(x86_64 allmodconfig) produced this warning:

drivers/clocksource/timer-ixp4xx.c:78:20: warning: 'ixp4xx_read_sched_clock' defined but not used [-Wunused-function]
 static u64 notrace ixp4xx_read_sched_clock(void)
                    ^~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  13e0b4059b98 ("clocksource/drivers/ixp4xx: Add driver")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: build warning after merge of the arm-soc tree
@ 2014-01-19 23:39 Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2014-01-19 23:39 UTC (permalink / raw)
  To: Olof Johansson, Arnd Bergmann, linux-arm-kernel
  Cc: linux-next, linux-kernel, Alexandre Belloni, Linus Walleij


[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

Hi all,

After merging the arm-soc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/pinctrl/pinconf.c: In function 'pinconf_pins_show':
drivers/pinctrl/pinconf.c:299:28: warning: unused variable 'ops' [-Wunused-variable]
  const struct pinconf_ops *ops = pctldev->desc->confops;
                            ^
drivers/pinctrl/pinconf.c: In function 'pinconf_groups_show':
drivers/pinctrl/pinconf.c:346:28: warning: unused variable 'ops' [-Wunused-variable]
  const struct pinconf_ops *ops = pctldev->desc->confops;
                            ^

Introduced by commit c420619d5177 ("pinctrl: pinconf: remove checks on
ops->pin_config_get").

Sorry, that I did not notice this earlier.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: build warning after merge of the arm-soc tree
  2012-03-19  7:39 Stephen Rothwell
@ 2012-03-19  9:40 ` Arnd Bergmann
  0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2012-03-19  9:40 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Olof Johansson, linux-arm-kernel, linux-next, linux-kernel,
	Turquette, Mike

On Monday 19 March 2012, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the arm-soc tree, today's linux-next build (all)
> produced this warning:
> 
> drivers/clk/Kconfig:22: warning: menuconfig statement without prompt
> 
> Introduced by commit c173033d154e ("clk: make CONFIG_COMMON_CLK invisible").

Thanks for the report. This is clearly my fault for not testing the last
minute patch.
I have now replaced it with the one below and tested that it works
as intended.

	Arnd


commit 8fb61e33507e5d76b69467b4f96290338e96b733
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Sat Mar 17 21:10:51 2012 +0000

    clk: make CONFIG_COMMON_CLK invisible
    
    All platforms that use the common clk infrastructure should select
    COMMON_CLK from platform code, and on all other platforms, it must
    not be enabled, so there is no point making the option visible to
    users, and when it is visible, we break randconfig builds.
    
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 2eaf17e..165e1fe 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -9,21 +9,18 @@ config HAVE_CLK_PREPARE
 config HAVE_MACH_CLKDEV
 	bool
 
-menuconfig COMMON_CLK
-	bool "Common Clock Framework"
+config COMMON_CLK
+	bool
 	select HAVE_CLK_PREPARE
 	---help---
 	  The common clock framework is a single definition of struct
 	  clk, useful across many platforms, as well as an
 	  implementation of the clock API in include/linux/clk.h.
 	  Architectures utilizing the common struct clk should select
-	  this automatically, but it may be necessary to manually select
-	  this option for loadable modules requiring the common clock
-	  framework.
-
-	  If in doubt, say "N".
+	  this option.
 
-if COMMON_CLK
+menu "Common Clock Framework"
+	depends on COMMON_CLK
 
 config COMMON_CLK_DISABLE_UNUSED
 	bool "Disabled unused clocks at boot"
@@ -47,4 +44,4 @@ config COMMON_CLK_DEBUG
 	  clk_flags, clk_prepare_count, clk_enable_count &
 	  clk_notifier_count.
 
-endif
+endmenu

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: build warning after merge of the arm-soc tree
@ 2012-03-19  7:39 Stephen Rothwell
  2012-03-19  9:40 ` Arnd Bergmann
  0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2012-03-19  7:39 UTC (permalink / raw)
  To: Olof Johansson, Arnd Bergmann, linux-arm-kernel; +Cc: linux-next, linux-kernel


[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

Hi all,

After merging the arm-soc tree, today's linux-next build (all)
produced this warning:

drivers/clk/Kconfig:22: warning: menuconfig statement without prompt

Introduced by commit c173033d154e ("clk: make CONFIG_COMMON_CLK invisible").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, back to index

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06  0:45 linux-next: build warning after merge of the arm-soc tree Stephen Rothwell
2021-04-06  6:34 ` Krzysztof Kozlowski
  -- strict thread matches above, loose matches on Subject: below --
2019-08-15 23:25 Stephen Rothwell
2019-08-15 23:23 Stephen Rothwell
2019-04-29 23:28 Stephen Rothwell
2019-05-03  6:49 ` Linus Walleij
2019-05-03 12:57   ` Arnd Bergmann
2014-01-19 23:39 Stephen Rothwell
2012-03-19  7:39 Stephen Rothwell
2012-03-19  9:40 ` Arnd Bergmann

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git