From: Jonathan Cameron <jic23@kernel.org>
To: William Breathitt Gray <vilhelm.gray@gmail.com>,
gregkh@linuxfoundation.org, akpm@linux-foundation.org
Cc: x86@kernel.org, linux-next@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
sfr@canb.auug.org.au, linux@roeck-us.net,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH v5 3/4] iio: stx104: Allow build for X86_64
Date: Sat, 28 May 2016 18:15:47 +0100 [thread overview]
Message-ID: <1d62168c-ab95-ff67-fd04-f8c3ba4f81a2@kernel.org> (raw)
In-Reply-To: <26bbe8f7c46b2504068f11c1f6219e1df6879822.1464380034.git.vilhelm.gray@gmail.com>
On 27/05/16 23:09, William Breathitt Gray wrote:
> With the introduction of the ISA_BUS_API Kconfig option, ISA-style
> drivers may be built for X86_64 architectures. This patch changes the
> ISA Kconfig option dependency of the Apex Embedded Systems STX104 DAC
> driver to ISA_BUS_API, thus allowing it to build for X86_64 as it is
> expected to.
>
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
I've only been following this discussion very vaguely, but the consensus seems
to be good, so feel free to apply this one with my Ack for IIO.
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> drivers/iio/dac/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index e63b957..f7c71da 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -247,7 +247,7 @@ config MCP4922
>
> config STX104
> tristate "Apex Embedded Systems STX104 DAC driver"
> - depends on X86 && ISA
> + depends on X86 && ISA_BUS_API
> help
> Say yes here to build support for the 2-channel DAC on the Apex
> Embedded Systems STX104 integrated analog PC/104 card. The base port
>
next prev parent reply other threads:[~2016-05-28 17:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 22:08 [PATCH v5 0/4] Allow ISA-style drivers on modern systems William Breathitt Gray
2016-05-27 22:08 ` [PATCH v5 1/4] isa: " William Breathitt Gray
2016-05-28 19:35 ` Linus Torvalds
2016-05-27 22:08 ` [PATCH v5 2/4] gpio: Allow PC/104 devices on X86_64 William Breathitt Gray
[not found] ` <61880bededb77bbc3ea3422e48ce717d2a2ff489.1464380034.git.vilhelm.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-31 8:41 ` Linus Walleij
2016-05-31 11:23 ` William Breathitt Gray
2016-05-31 15:25 ` Greg KH
2016-06-17 10:47 ` Thorsten Leemhuis
[not found] ` <057d8c0b-074c-609a-35da-5a01f07b6d31-rCxcAJFjeRkk+I/owrrOrA@public.gmane.org>
2016-06-18 2:36 ` Greg KH
2016-06-18 2:49 ` William Breathitt Gray
2016-06-18 3:18 ` Greg KH
2016-06-18 3:39 ` William Breathitt Gray
2016-06-18 3:47 ` Greg KH
[not found] ` <cover.1464380034.git.vilhelm.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-27 22:09 ` [PATCH v5 3/4] iio: stx104: Allow build for X86_64 William Breathitt Gray
2016-05-28 17:15 ` Jonathan Cameron [this message]
2016-05-27 22:09 ` [PATCH v5 4/4] watchdog: ebc-c384_wdt: " William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d62168c-ab95-ff67-fd04-f8c3ba4f81a2@kernel.org \
--to=jic23@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pmeerw@pmeerw.net \
--cc=sfr@canb.auug.org.au \
--cc=vilhelm.gray@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).