From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-next@vger.kernel.org
Subject: Re: linux-next: semaphore-removal build breakage
Date: Thu, 15 May 2008 03:05:10 +1000 [thread overview]
Message-ID: <20080515030510.1874c7b3.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20080428134609.9617eb8e.sfr@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 936 bytes --]
Hi Willy,
On Mon, 28 Apr 2008 13:46:09 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next build (x86_64 allmodconfig) broke like this:
>
> In file included from net/9p/trans_virtio.c:34:
> include/linux/idr.h:60: error: syntax error before 'spinlock_t'
> include/linux/idr.h:60: warning: no semicolon at end of struct or union
> include/linux/idr.h:104: error: field 'idr' has incomplete type
>
> Caused by commit 2c77d192c68a95a188dd326db1315b3492487c41 ("9p: Convert
> from semaphore to spinlock") in the semaphore-removal tree. The
> following patch fixes it but may well not be correct.
In fact, it would be also fixed (or hidden) if you put the includes back
in the order they were before that patch ....
It would be good for this to be fixed - its been there too long now.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next parent reply other threads:[~2008-05-14 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080428134609.9617eb8e.sfr@canb.auug.org.au>
2008-05-14 17:05 ` Stephen Rothwell [this message]
2008-05-15 4:23 ` linux-next: semaphore-removal build breakage Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515030510.1874c7b3.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=linux-next@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).