From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: netdev <netdev@vger.kernel.org>, jgarzik <jgarzik@pobox.com>,
linux-next@vger.kernel.org, akpm <akpm@linux-foundation.org>,
Adam M Belay <abelay@mit.edu>, Adam Belay <ambx1@neo.rr.com>
Subject: Re: [PATCH -next] 3c515: fix using pnp_get_resource when CONFIG_ISAPNP=n
Date: Fri, 16 May 2008 12:58:03 -0600 [thread overview]
Message-ID: <200805161258.04265.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <482DD0AF.7070003@oracle.com>
On Friday 16 May 2008 12:21:35 pm Randy Dunlap wrote:
> Bjorn Helgaas wrote:
> > I prefer CONFIG_PNP to __ISAPNP__ in general, but I see
> > you're just following the other tests in the same file.
>
> Yes. And it would need to be CONFIG_ISAPNP, not CONFIG_PNP.
Huh. Sure enough. I hadn't even noticed pnp_find_dev().
I'm not sure why pnp_find_dev() should be under CONFIG_ISAPNP
rather than CONFIG_PNP, other than the fact that it uses
ISAPNP_ANY_ID.
On the other hand, there are only 25-30 users of pnp_find_dev();
maybe I should just look at converting them and nuking the
compat interfaces completely.
Bjorn
next prev parent reply other threads:[~2008-05-16 18:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 17:35 [PATCH -next] 3c515: fix using pnp_get_resource when CONFIG_ISAPNP=n Randy Dunlap
2008-05-16 18:15 ` Bjorn Helgaas
2008-05-16 18:21 ` Randy Dunlap
2008-05-16 18:58 ` Bjorn Helgaas [this message]
2008-05-22 11:09 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805161258.04265.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=abelay@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=ambx1@neo.rr.com \
--cc=jgarzik@pobox.com \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).