From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org
Subject: Fwd: Re: [PATCH] kprobes: fix compilation break due to kprobe_mutex
Date: Sat, 17 May 2008 12:42:45 +0100 [thread overview]
Message-ID: <20080517114244.GB30141@flint.arm.linux.org.uk> (raw)
FYI.
Presumably this hasn't been detected because linux-next isn't building
enough ARM configurations to hit one that has kprobes enabled?
----- Forwarded message from Abhishek Sagar <sagar.abhishek@gmail.com> -----
Delivery-date: Sat, 17 May 2008 12:30:06 +0100
Date: Sat, 17 May 2008 16:59:53 +0530
From: "Abhishek Sagar" <sagar.abhishek@gmail.com>
To: "Russell King - ARM Linux" <linux@arm.linux.org.uk>
Subject: Re: [PATCH] kprobes: fix compilation break due to kprobe_mutex
Cc: linux-arm-kernel@lists.arm.linux.org.uk, nico@cam.org,
mathieu.desnoyers@polymtl.ca
On 5/17/08, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> The commit you refer to does not exist in mainline.
Yea, sorry. That commit is an upstream bubble in some unrelated branch
I was tracking.
Now that I look at it, the commit I'm referring to is in
git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git :
auto-sched-next. I merged all the recent kprobe related changes from
there into my local arm kprobes branch based on 2.6.26-rc2 and fired a
build for arm. That's when I encountered the kprobe build error.
> In addition, the URL you refer to above, the patch doesn't
> match the diffstat - the patch doesn't touch kernel/kprobes.c.
Here's the updated version (series), with a proper diffstat:
http://lkml.org/lkml/2008/4/24/217
> The only thing the patch seems to be doing is removing the
> mutex. It never adds anything.
Yes and this cleanup of kprobe_mutex usage from all the arch dependent
kprobe code needs to be done for arm too, else it'll break
compilation.
Regards,
Abhishek Sagar
----- End forwarded message -----
next reply other threads:[~2008-05-17 11:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-17 11:42 Russell King - ARM Linux [this message]
2008-05-17 12:02 ` Fwd: Re: [PATCH] kprobes: fix compilation break due to kprobe_mutex Stephen Rothwell
2008-05-17 12:17 ` Stephen Rothwell
2008-05-17 13:35 ` Russell King - ARM Linux
2008-05-17 13:59 ` Stephen Rothwell
2008-05-17 16:20 ` Stephen Rothwell
2008-05-17 19:08 ` Russell King - ARM Linux
2008-05-18 3:49 ` Stephen Rothwell
2008-05-18 3:53 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080517114244.GB30141@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).