archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <>
To: Jonathan Corbet <>
Subject: linux-next: bkl-removal build failure
Date: Mon, 19 May 2008 16:32:03 +1000	[thread overview]
Message-ID: <> (raw)

Hi Jon,

[Resend with correct address]

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/char/viotape.c: In function 'viotap_open':
/scratch/sfr/next/drivers/char/viotape.c:692: error: expected ';' before 'get_dev_info'

I have temporarily applied the patch below.

Stephen Rothwell          

>From 442ab511fe8c5d61ff81a85a188b0eb1c677b2c6 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <>
Date: Mon, 19 May 2008 16:06:52 +1000
Subject: [PATCH] bkl-removal viotape fixup

Signed-off-by: Stephen Rothwell <>
 drivers/char/viotape.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/viotape.c b/drivers/char/viotape.c
index 57be035..9f4c4ba 100644
--- a/drivers/char/viotape.c
+++ b/drivers/char/viotape.c
@@ -688,7 +688,7 @@ static int viotap_open(struct inode *inode, struct file *file)
 	if (op == NULL)
 		return -ENOMEM;
-	lock_kernel()
+	lock_kernel();
 	get_dev_info(file->f_path.dentry->d_inode, &devi);
 	/* Note: We currently only support one mode! */

             reply	other threads:[~2008-05-19  6:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-19  6:32 Stephen Rothwell [this message]
2008-05-19 17:12 ` linux-next: bkl-removal build failure Jonathan Corbet
2008-05-20  3:26   ` Stephen Rothwell
2008-05-20  4:43   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).