* linux-next: bkl-removal build failure
@ 2008-05-19 6:32 Stephen Rothwell
2008-05-19 17:12 ` Jonathan Corbet
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2008-05-19 6:32 UTC (permalink / raw)
To: Jonathan Corbet; +Cc: linux-next
Hi Jon,
[Resend with correct address]
Today's linux-next build (powerpc ppc64_defconfig) failed like this:
drivers/char/viotape.c: In function 'viotap_open':
/scratch/sfr/next/drivers/char/viotape.c:692: error: expected ';' before 'get_dev_info'
I have temporarily applied the patch below.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
>From 442ab511fe8c5d61ff81a85a188b0eb1c677b2c6 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 19 May 2008 16:06:52 +1000
Subject: [PATCH] bkl-removal viotape fixup
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/char/viotape.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/viotape.c b/drivers/char/viotape.c
index 57be035..9f4c4ba 100644
--- a/drivers/char/viotape.c
+++ b/drivers/char/viotape.c
@@ -688,7 +688,7 @@ static int viotap_open(struct inode *inode, struct file *file)
if (op == NULL)
return -ENOMEM;
- lock_kernel()
+ lock_kernel();
get_dev_info(file->f_path.dentry->d_inode, &devi);
/* Note: We currently only support one mode! */
--
1.5.5.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: linux-next: bkl-removal build failure
2008-05-19 6:32 linux-next: bkl-removal build failure Stephen Rothwell
@ 2008-05-19 17:12 ` Jonathan Corbet
2008-05-20 3:26 ` Stephen Rothwell
2008-05-20 4:43 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Jonathan Corbet @ 2008-05-19 17:12 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>
> drivers/char/viotape.c: In function 'viotap_open':
> /scratch/sfr/next/drivers/char/viotape.c:692: error: expected ';' before 'get_dev_info'
Well, that's embarrassing. There are limits to what can be done with
"make allyesconfig" when you only have one architecture at hand...:)
I've put your fix into my tree, thanks and sorry for the trouble.
jon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: bkl-removal build failure
2008-05-19 17:12 ` Jonathan Corbet
@ 2008-05-20 3:26 ` Stephen Rothwell
2008-05-20 4:43 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2008-05-20 3:26 UTC (permalink / raw)
To: Jonathan Corbet; +Cc: linux-next
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
Hi Jon,
On Mon, 19 May 2008 11:12:45 -0600 corbet@lwn.net (Jonathan Corbet) wrote:
>
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> >
> > drivers/char/viotape.c: In function 'viotap_open':
> > /scratch/sfr/next/drivers/char/viotape.c:692: error: expected ';' before 'get_dev_info'
>
> Well, that's embarrassing. There are limits to what can be done with
> "make allyesconfig" when you only have one architecture at hand...:)
Welcome to life with the big boys :-)
> I've put your fix into my tree, thanks and sorry for the trouble.
OK, thanks.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: bkl-removal build failure
2008-05-19 17:12 ` Jonathan Corbet
2008-05-20 3:26 ` Stephen Rothwell
@ 2008-05-20 4:43 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2008-05-20 4:43 UTC (permalink / raw)
To: Jonathan Corbet; +Cc: Stephen Rothwell, linux-next
On Mon, May 19, 2008 at 11:12:45AM -0600, Jonathan Corbet wrote:
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> >
> > drivers/char/viotape.c: In function 'viotap_open':
> > /scratch/sfr/next/drivers/char/viotape.c:692: error: expected ';' before 'get_dev_info'
>
> Well, that's embarrassing. There are limits to what can be done with
> "make allyesconfig" when you only have one architecture at hand...:)
Andrew has a set of pre-built cross-compilers that can help out with
this at:
http://userweb.kernel.org/~akpm/cross-compilers/
that ends up working very well for this. I'm ashamed I haven't been
using them all along...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-05-20 15:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-05-19 6:32 linux-next: bkl-removal build failure Stephen Rothwell
2008-05-19 17:12 ` Jonathan Corbet
2008-05-20 3:26 ` Stephen Rothwell
2008-05-20 4:43 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).