linux-next: bkl-removal build failure

linux-next: bkl-removal build failure

[Stephen Rothwell]

Hi Jon,

[Resend with correct address]

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/char/viotape.c: In function 'viotap_open':
/scratch/sfr/next/drivers/char/viotape.c:692: error: expected ';' before 'get_dev_info'

I have temporarily applied the patch below.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

>From 442ab511fe8c5d61ff81a85a188b0eb1c677b2c6 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 19 May 2008 16:06:52 +1000
Subject: [PATCH] bkl-removal viotape fixup

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/char/viotape.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/viotape.c b/drivers/char/viotape.c
index 57be035..9f4c4ba 100644
--- a/drivers/char/viotape.c
+++ b/drivers/char/viotape.c
@@ -688,7 +688,7 @@ static int viotap_open(struct inode *inode, struct file *file)
 	if (op == NULL)
 		return -ENOMEM;
 
-	lock_kernel()
+	lock_kernel();
 	get_dev_info(file->f_path.dentry->d_inode, &devi);
 
 	/* Note: We currently only support one mode! */
-- 
1.5.5.1

Re: linux-next: bkl-removal build failure

[Jonathan Corbet]

Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> drivers/char/viotape.c: In function 'viotap_open':
> /scratch/sfr/next/drivers/char/viotape.c:692: error: expected ';' before 'get_dev_info'

Well, that's embarrassing.  There are limits to what can be done with
"make allyesconfig" when you only have one architecture at hand...:)
I've put your fix into my tree, thanks and sorry for the trouble.

jon

Re: linux-next: bkl-removal build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

Hi Jon,

On Mon, 19 May 2008 11:12:45 -0600 corbet@lwn.net (Jonathan Corbet) wrote:
>
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> > 
> > drivers/char/viotape.c: In function 'viotap_open':
> > /scratch/sfr/next/drivers/char/viotape.c:692: error: expected ';' before 'get_dev_info'
> 
> Well, that's embarrassing.  There are limits to what can be done with
> "make allyesconfig" when you only have one architecture at hand...:)

Welcome to life with the big boys :-)

> I've put your fix into my tree, thanks and sorry for the trouble.

OK, thanks.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: linux-next: bkl-removal build failure

[Greg KH]

On Mon, May 19, 2008 at 11:12:45AM -0600, Jonathan Corbet wrote:
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> > 
> > drivers/char/viotape.c: In function 'viotap_open':
> > /scratch/sfr/next/drivers/char/viotape.c:692: error: expected ';' before 'get_dev_info'
> 
> Well, that's embarrassing.  There are limits to what can be done with
> "make allyesconfig" when you only have one architecture at hand...:)

Andrew has a set of pre-built cross-compilers that can help out with
this at:
	http://userweb.kernel.org/~akpm/cross-compilers/

that ends up working very well for this.  I'm ashamed I haven't been
using them all along...

thanks,

greg k-h