From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Subject: [PATCH] linux-next: Tree for May 21 - build failure with netfilter on __nf_ct_helper_find()
Date: Wed, 21 May 2008 17:02:30 +0530
Message-ID: <20080521113230.GA10830@linux.vnet.ibm.com>
References: <20080521155936.466bbe86.sfr@canb.auug.org.au>
Reply-To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-next-owner@vger.kernel.org>
Received: from E23SMTP03.au.ibm.com ([202.81.18.172]:46745 "EHLO
	e23smtp03.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759660AbYEULcg (ORCPT
	<rfc822;linux-next@vger.kernel.org>); Wed, 21 May 2008 07:32:36 -0400
Content-Disposition: inline
In-Reply-To: <20080521155936.466bbe86.sfr@canb.auug.org.au>
Sender: linux-next-owner@vger.kernel.org
List-ID: <linux-next.vger.kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, netfilter-devel@vger.kernel.org, apw@shadowen.org

Hi Stephen,

The next-20080521 kernel build fails, on x86_64 machine=20

CC net/netfilter/nf_conntrack_helper.o
net/netfilter/nf_conntrack_helper.c: In function =E2=80=98__nf_ct_helpe=
r_find=E2=80=99:
net/netfilter/nf_conntrack_helper.c:58: error: implicit declaration of =
function =E2=80=98hlist_for_each_entry_rcu=E2=80=99
net/netfilter/nf_conntrack_helper.c:58: error: =E2=80=98hnode=E2=80=99 =
undeclared (first use in this function)
net/netfilter/nf_conntrack_helper.c:58: error: (Each undeclared identif=
ier is reported only once
net/netfilter/nf_conntrack_helper.c:58: error: for each function it app=
ears in.)
net/netfilter/nf_conntrack_helper.c:58: error: expected =E2=80=98;=E2=80=
=99 before =E2=80=98{=E2=80=99 token
net/netfilter/nf_conntrack_helper.c:50: warning: unused variable =E2=80=
=98mask=E2=80=99
net/netfilter/nf_conntrack_helper.c: In function =E2=80=98__nf_conntrac=
k_helper_find_byname=E2=80=99:
net/netfilter/nf_conntrack_helper.c:74: error: =E2=80=98hnode=E2=80=99 =
undeclared (first use in this function)
net/netfilter/nf_conntrack_helper.c:74: error: expected =E2=80=98;=E2=80=
=99 before =E2=80=98{=E2=80=99 token
net/netfilter/nf_conntrack_helper.c: In function =E2=80=98nf_conntrack_=
helper_register=E2=80=99:
net/netfilter/nf_conntrack_helper.c:117: error: implicit declaration of=
 function =E2=80=98hlist_add_head_rcu=E2=80=99
net/netfilter/nf_conntrack_helper.c: In function =E2=80=98nf_conntrack_=
helper_unregister=E2=80=99:
net/netfilter/nf_conntrack_helper.c:133: error: implicit declaration of=
 function =E2=80=98hlist_del_rcu=E2=80=99
make[2]: *** [net/netfilter/nf_conntrack_helper.o] Error 1
make[1]: *** [net/netfilter] Error 2
make: *** [net] Error 2

This build error is because of the missing include file.I have tested
the patch for the build failure only.

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
--- linux-2.6.26-rc3/net/netfilter/nf_conntrack_helper.c	2008-05-20 20:=
24:14.000000000 +0530
+++ linux-2.6.26-rc3/net/netfilter/~nf_conntrack_helper.c	2008-05-22 00=
:17:32.000000000 +0530
@@ -20,6 +20,7 @@
 #include <linux/err.h>
 #include <linux/kernel.h>
 #include <linux/netdevice.h>
+#include <linux/rculist.h>
=20
 #include <net/netfilter/nf_conntrack.h>
 #include <net/netfilter/nf_conntrack_l3proto.h>
--=20
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
--
To unsubscribe from this list: send the line "unsubscribe linux-next" i=
n
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html