linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: sound build failure
@ 2008-05-21  3:20 Stephen Rothwell
  0 siblings, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2008-05-21  3:20 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: linux-next

Hi Takashi,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

sound/aoa/Kconfig:3: invalid option
make[2]: *** [ppc64_defconfig] Error 1

Caused by commit 6a5751b42420dce9267d7d915eed8f8673d16fdd ("sound:
Convert to menuconfig") from the sound tree.

I applied the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

>From 206a3c1db3cf96b8cebf3a873f26044ff436723c Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 21 May 2008 13:13:15 +1000
Subject: [PATCH] sound: "depends" requires "on"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/aoa/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/aoa/Kconfig b/sound/aoa/Kconfig
index eeae9e3..c081e18 100644
--- a/sound/aoa/Kconfig
+++ b/sound/aoa/Kconfig
@@ -1,6 +1,6 @@
 menuconfig SND_AOA
 	tristate "Apple Onboard Audio driver"
-	depends PPC_PMAC
+	depends on PPC_PMAC
 	select SND_PCM
 	---help---
 	This option enables the new driver for the various
-- 
1.5.5.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* linux-next: sound build failure
@ 2008-05-21  5:32 Stephen Rothwell
  2008-05-21  6:26 ` Takashi Iwai
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2008-05-21  5:32 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: linux-next

Hi Takashi,

Today's linux-next build (sparc64 defconfig) failed like this:

ERROR: "snd_ctl_make_virtual_master" [sound/pci/ac97/snd-ac97-codec.ko] undefined!
ERROR: "snd_ctl_add_slave" [sound/pci/ac97/snd-ac97-codec.ko] undefined!

A "select SND_VMASTER" appears to have been lost from "config
SND_AC97_CODEC" in commit 6a5751b42420dce9267d7d915eed8f8673d16fdd
("sound: Convert to menuconfig").

I applied the patch below.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

>From b88eff22395ffdf10f37cd1c6f1b6adcd37417f6 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 21 May 2008 15:28:59 +1000
Subject: [PATCH] sound: restore SND_VMASTER select to SND_AC97_CODEC

Otherwise the following error occurs:

ERROR: "snd_ctl_make_virtual_master" [sound/pci/ac97/snd-ac97-codec.ko] undefined!
ERROR: "snd_ctl_add_slave" [sound/pci/ac97/snd-ac97-codec.ko] undefined!

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/drivers/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/drivers/Kconfig b/sound/drivers/Kconfig
index 4bf44fb..255fd18 100644
--- a/sound/drivers/Kconfig
+++ b/sound/drivers/Kconfig
@@ -21,6 +21,7 @@ config SND_AC97_CODEC
 	tristate
 	select SND_PCM
 	select AC97_BUS
+	select SND_VMASTER
 
 menuconfig SND_DRIVERS
 	bool "Generic sound devices"
-- 
1.5.5.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-21  6:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-05-21  3:20 linux-next: sound build failure Stephen Rothwell
2008-05-21  5:32 Stephen Rothwell
2008-05-21  6:26 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).