linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-next@vger.kernel.org
Subject: linux-next: sound build failure
Date: Wed, 21 May 2008 15:32:12 +1000	[thread overview]
Message-ID: <20080521153212.f36796e2.sfr@canb.auug.org.au> (raw)

Hi Takashi,

Today's linux-next build (sparc64 defconfig) failed like this:

ERROR: "snd_ctl_make_virtual_master" [sound/pci/ac97/snd-ac97-codec.ko] undefined!
ERROR: "snd_ctl_add_slave" [sound/pci/ac97/snd-ac97-codec.ko] undefined!

A "select SND_VMASTER" appears to have been lost from "config
SND_AC97_CODEC" in commit 6a5751b42420dce9267d7d915eed8f8673d16fdd
("sound: Convert to menuconfig").

I applied the patch below.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

>From b88eff22395ffdf10f37cd1c6f1b6adcd37417f6 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 21 May 2008 15:28:59 +1000
Subject: [PATCH] sound: restore SND_VMASTER select to SND_AC97_CODEC

Otherwise the following error occurs:

ERROR: "snd_ctl_make_virtual_master" [sound/pci/ac97/snd-ac97-codec.ko] undefined!
ERROR: "snd_ctl_add_slave" [sound/pci/ac97/snd-ac97-codec.ko] undefined!

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/drivers/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/drivers/Kconfig b/sound/drivers/Kconfig
index 4bf44fb..255fd18 100644
--- a/sound/drivers/Kconfig
+++ b/sound/drivers/Kconfig
@@ -21,6 +21,7 @@ config SND_AC97_CODEC
 	tristate
 	select SND_PCM
 	select AC97_BUS
+	select SND_VMASTER
 
 menuconfig SND_DRIVERS
 	bool "Generic sound devices"
-- 
1.5.5.1


             reply	other threads:[~2008-05-21  5:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21  5:32 Stephen Rothwell [this message]
2008-05-21  6:26 ` linux-next: sound build failure Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2008-05-21  3:20 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080521153212.f36796e2.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=linux-next@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).