From: Hans-Joachim Picht <hans@linux.vnet.ibm.com>
To: linux-next@vger.kernel.org, Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] fix I/O memory related compile caused by wrong Kconfig dependencies
Date: Wed, 21 May 2008 18:05:23 +0200 [thread overview]
Message-ID: <20080521160523.GA1351@blc4eb509856389.ibm.com> (raw)
On s390 linux-next fails with the following build error:
sound/core/memory.c: In function 'copy_to_user_fromio':
sound/core/memory.c:47: error: implicit declaration of function 'memcpy_fromio'
sound/core/memory.c: In function 'copy_from_user_toio':
sound/core/memory.c:82: error: implicit declaration of function 'memcpy_toio'
The problem was introduced with the following commit
6a5751b42420dce9267d7d915eed8f8673d16fdd ("sound: Convert to menuconfig")
from Takashi's sound-2.6 tree.
Add "depends on HAS_IOMEM" to this menu to make the sound drivers
disappear for s390 which does not have I/O memory.
Signed-off-by: Hans-Joachim Picht <hans@linux.vnet.ibm.com>
diff --git a/sound/Kconfig b/sound/Kconfig
index b625855..51e7f7a 100644
--- a/sound/Kconfig
+++ b/sound/Kconfig
@@ -1,6 +1,8 @@
# sound/Config.in
#
+if HAS_IOMEM
+
menuconfig SOUND
tristate "Sound card support"
help
@@ -99,3 +101,5 @@ config AC97_BUS
should "select" this.
endif # SOUND
+
+endif # HAS_IOMEM
next reply other threads:[~2008-05-21 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 16:05 Hans-Joachim Picht [this message]
2008-05-21 16:21 ` [PATCH] fix I/O memory related compile caused by wrong Kconfig dependencies Takashi Iwai
2008-05-21 21:30 ` Hans-Joachim Picht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521160523.GA1351@blc4eb509856389.ibm.com \
--to=hans@linux.vnet.ibm.com \
--cc=linux-next@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).