linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Jean Delvare <khali@linux-fr.org>,
	linux-next@vger.kernel.org,
	Dave Young <hidave.darkstar@gmail.com>,
	Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: linux-next: i2c build failure
Date: Thu, 22 May 2008 18:58:09 -0700	[thread overview]
Message-ID: <20080523015809.GA16743@kroah.com> (raw)
In-Reply-To: <20080523113255.258e38bd.sfr@canb.auug.org.au>

On Fri, May 23, 2008 at 11:32:55AM +1000, Stephen Rothwell wrote:
> Hi Jean,
> 
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> drivers/i2c/i2c-core.c: In function 'i2c_register_driver':
> drivers/i2c/i2c-core.c:697: warning: passing argument 2 of 'class_for_each_device' from incompatible pointer type
> drivers/i2c/i2c-core.c:697: error: too few arguments to function 'class_for_each_device'
> drivers/i2c/i2c-core.c: In function 'i2c_del_driver':
> drivers/i2c/i2c-core.c:749: warning: passing argument 2 of 'class_for_each_device' from incompatible pointer type
> drivers/i2c/i2c-core.c:749: error: too few arguments to function 'class_for_each_device'
> 
> This is caused by commit f79228aaa062668bcbabf9762e819a1d7ee7c5c4 ("i2c:
> Use class_for_each_device") from the i2c tree interacting with commit
> a3ec024649e0095368d38a2e434ad092b79aa7af ("Driver Core: add ability for
> class_for_each_device to start in middle of list") from the driver-core
> tree.  The latter added a parameter to class_for_each_device while the
> former added a new usage.
> 
> I applied the patch below.

The patch looks correct, thanks.

> Greg, is there some better way to handle this interface change?  (e.g. new
> function name?)

There's only what, 5 users in the kernel for it today in 3 different
files?  I'd rather not go through that kind of sequence, can you just
keep this patch and we'll handle it when we merge together once .27
opens.  Sound reasonable?

thanks,

greg k-h

  reply	other threads:[~2008-05-23  1:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-23  1:32 linux-next: i2c build failure Stephen Rothwell
2008-05-23  1:58 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-05-15  2:12 Stephen Rothwell
2008-05-15  8:22 ` Jean Delvare
2008-05-15 10:39   ` Stephen Rothwell
2008-05-15 19:47   ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080523015809.GA16743@kroah.com \
    --to=greg@kroah.com \
    --cc=hidave.darkstar@gmail.com \
    --cc=kay.sievers@vrfy.org \
    --cc=khali@linux-fr.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).