linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: ldp build failure
@ 2008-06-04  5:08 Stephen Rothwell
  2008-06-04  5:24 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2008-06-04  5:08 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, Hans Verkuil, Mauro Carvalho Chehab, Dean Anderson

Hi Greg,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/media/video/s2255drv.c:1659: error: unknown field 'vidioc_enum_fmt_cap' specified in initializer
drivers/media/video/s2255drv.c:1659: warning: initialization from incompatible pointer type
drivers/media/video/s2255drv.c:1660: error: unknown field 'vidioc_g_fmt_cap' specified in initializer
drivers/media/video/s2255drv.c:1660: warning: initialization from incompatible pointer type
drivers/media/video/s2255drv.c:1661: error: unknown field 'vidioc_try_fmt_cap' specified in initializer
drivers/media/video/s2255drv.c:1661: warning: initialization from incompatible pointer type
drivers/media/video/s2255drv.c:1662: error: unknown field 'vidioc_s_fmt_cap' specified in initializer
drivers/media/video/s2255drv.c:1662: warning: initialization from incompatible pointer type

Caused by commit 7ddf62fca6b9be8867204dfcd062bca43a75bae6 ("V4L/DVB
(7949): videodev: renamed the vidioc_*_fmt_* callbacks") from the v4l-dvb
tree.  I applied the patch below.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

>From 7072d424c2a66ad1df68b4dc6266fcbbd721532b Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 4 Jun 2008 15:06:07 +1000
Subject: [PATCH] ldp: fix fallout from v4l struct element renaming

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/media/video/s2255drv.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/video/s2255drv.c b/drivers/media/video/s2255drv.c
index d9abde2..181cb78 100644
--- a/drivers/media/video/s2255drv.c
+++ b/drivers/media/video/s2255drv.c
@@ -1656,10 +1656,10 @@ static struct video_device template = {
 	.minor = -1,
 	.release = video_device_release,
 	.vidioc_querycap = vidioc_querycap,
-	.vidioc_enum_fmt_cap = vidioc_enum_fmt_cap,
-	.vidioc_g_fmt_cap = vidioc_g_fmt_cap,
-	.vidioc_try_fmt_cap = vidioc_try_fmt_cap,
-	.vidioc_s_fmt_cap = vidioc_s_fmt_cap,
+	.vidioc_enum_fmt_vid_cap = vidioc_enum_fmt_cap,
+	.vidioc_g_fmt_vid_cap = vidioc_g_fmt_cap,
+	.vidioc_try_fmt_vid_cap = vidioc_try_fmt_cap,
+	.vidioc_s_fmt_vid_cap = vidioc_s_fmt_cap,
 	.vidioc_reqbufs = vidioc_reqbufs,
 	.vidioc_querybuf = vidioc_querybuf,
 	.vidioc_qbuf = vidioc_qbuf,
-- 
1.5.5.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: linux-next: ldp build failure
  2008-06-04  5:08 linux-next: ldp build failure Stephen Rothwell
@ 2008-06-04  5:24 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2008-06-04  5:24 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, Hans Verkuil, Mauro Carvalho Chehab, Dean Anderson

On Wed, Jun 04, 2008 at 03:08:19PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> drivers/media/video/s2255drv.c:1659: error: unknown field 'vidioc_enum_fmt_cap' specified in initializer
> drivers/media/video/s2255drv.c:1659: warning: initialization from incompatible pointer type
> drivers/media/video/s2255drv.c:1660: error: unknown field 'vidioc_g_fmt_cap' specified in initializer
> drivers/media/video/s2255drv.c:1660: warning: initialization from incompatible pointer type
> drivers/media/video/s2255drv.c:1661: error: unknown field 'vidioc_try_fmt_cap' specified in initializer
> drivers/media/video/s2255drv.c:1661: warning: initialization from incompatible pointer type
> drivers/media/video/s2255drv.c:1662: error: unknown field 'vidioc_s_fmt_cap' specified in initializer
> drivers/media/video/s2255drv.c:1662: warning: initialization from incompatible pointer type
> 
> Caused by commit 7ddf62fca6b9be8867204dfcd062bca43a75bae6 ("V4L/DVB
> (7949): videodev: renamed the vidioc_*_fmt_* callbacks") from the v4l-dvb
> tree.  I applied the patch below.

Thanks for the patch, I'll apply it when I resend the driver to Mauro,
hopefully tomorrow :)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-06-04  5:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-06-04  5:08 linux-next: ldp build failure Stephen Rothwell
2008-06-04  5:24 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).