linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: v4l-dvb build failure
@ 2008-06-04  2:28 Stephen Rothwell
  0 siblings, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2008-06-04  2:28 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: Hans Verkuil, linux-next

Hi Mauro,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/media/video/soc_camera.c: In function 'soc_camera_video_start':
drivers/media/video/soc_camera.c:937: error: 'struct video_device' has no member named 'vidioc_g_fmt_cap'
drivers/media/video/soc_camera.c:938: error: 'struct video_device' has no member named 'vidioc_enum_fmt_cap'
drivers/media/video/soc_camera.c:939: error: 'struct video_device' has no member named 'vidioc_s_fmt_cap'
drivers/media/video/soc_camera.c:945: error: 'struct video_device' has no member named 'vidioc_try_fmt_cap'


Caused by commit 7ddf62fca6b9be8867204dfcd062bca43a75bae6 ("V4L/DVB
(7949): videodev: renamed the vidioc_*_fmt_* callbacks").

I applied the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

>From a8d310313869b6ca7f0fd32362f7d4912c48e0e2 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 4 Jun 2008 12:24:59 +1000
Subject: [PATCH] v4l-dvb: fix fallout from struct member renames

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/media/video/soc_camera.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/video/soc_camera.c b/drivers/media/video/soc_camera.c
index cc7f7c4..38ce780 100644
--- a/drivers/media/video/soc_camera.c
+++ b/drivers/media/video/soc_camera.c
@@ -934,15 +934,15 @@ int soc_camera_video_start(struct soc_camera_device *icd)
 	vdev->minor		= -1;
 	vdev->tvnorms		= V4L2_STD_UNKNOWN,
 	vdev->vidioc_querycap	= soc_camera_querycap;
-	vdev->vidioc_g_fmt_cap	= soc_camera_g_fmt_cap;
-	vdev->vidioc_enum_fmt_cap = soc_camera_enum_fmt_cap;
-	vdev->vidioc_s_fmt_cap	= soc_camera_s_fmt_cap;
+	vdev->vidioc_g_fmt_vid_cap	= soc_camera_g_fmt_cap;
+	vdev->vidioc_enum_fmt_vid_cap = soc_camera_enum_fmt_cap;
+	vdev->vidioc_s_fmt_vid_cap	= soc_camera_s_fmt_cap;
 	vdev->vidioc_enum_input	= soc_camera_enum_input;
 	vdev->vidioc_g_input	= soc_camera_g_input;
 	vdev->vidioc_s_input	= soc_camera_s_input;
 	vdev->vidioc_s_std	= soc_camera_s_std;
 	vdev->vidioc_reqbufs	= soc_camera_reqbufs;
-	vdev->vidioc_try_fmt_cap = soc_camera_try_fmt_cap;
+	vdev->vidioc_try_fmt_vid_cap = soc_camera_try_fmt_cap;
 	vdev->vidioc_querybuf	= soc_camera_querybuf;
 	vdev->vidioc_qbuf	= soc_camera_qbuf;
 	vdev->vidioc_dqbuf	= soc_camera_dqbuf;
-- 
1.5.5.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* linux-next: v4l-dvb build failure
@ 2008-06-23  3:08 Stephen Rothwell
  0 siblings, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2008-06-23  3:08 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-next, Greg Kroah-Hartman

[-- Attachment #1: Type: text/plain, Size: 1495 bytes --]

Hi Mauro,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/media/video/videodev.c: In function 'get_index':
drivers/media/video/videodev.c:1992: warning: passing argument 2 of 'class_for_each_device' from incompatible pointer type
drivers/media/video/videodev.c:1992: error: too few arguments to function 'class_for_each_device'

The class_for_each_device API is changing, so I have applied the
following patch.  There is nothing you can do about this so I will carry
this patch in linux-next.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

>From 9729a44374ade4322ac8813c38c0be2cdc3449cb Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 23 Jun 2008 13:05:52 +1000
Subject: [PATCH] v4l-dvb: class_for_each_device API change fallout

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/media/video/videodev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/videodev.c b/drivers/media/video/videodev.c
index 56044a0..d913008 100644
--- a/drivers/media/video/videodev.c
+++ b/drivers/media/video/videodev.c
@@ -1988,7 +1988,7 @@ static int get_index(struct video_device *vdev, int num)
 
 	info->dev = vdev->dev;
 
-	ret = class_for_each_device(&video_class, info,
+	ret = class_for_each_device(&video_class, NULL, info,
 					__fill_index_info);
 
 	if (ret < 0)
-- 
1.5.5.4


[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* linux-next: v4l-dvb build failure
@ 2008-06-23  3:07 Stephen Rothwell
  0 siblings, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2008-06-23  3:07 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-next, Sigmund Augdal

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

Hi Mauro,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/media/dvb/ttpci/budget-ci.c:50:21: error: tda827x.h: No such file or directory

I have reverted commit 020c648971a8e49b15848668ac1e100f8c84c804 ("V4L/DVB
(8049): budget-ci: Add support for Technotrend budget C-1501 dvb-c card").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-06-23  3:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-06-04  2:28 linux-next: v4l-dvb build failure Stephen Rothwell
2008-06-23  3:07 Stephen Rothwell
2008-06-23  3:08 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).