linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-next@vger.kernel.org
Subject: linux-next: firmware build failure
Date: Wed, 4 Jun 2008 16:46:23 +1000	[thread overview]
Message-ID: <20080604164623.3d5f38d2.sfr@canb.auug.org.au> (raw)

Hi David,

Today's linux-next build (x86_64 allmodconfig) failed like this:

firmware/whiteheat_loader.fw.gen.S: Assembler messages:
firmware/whiteheat_loader.fw.gen.S:8: Error: alignment not a power of 2
firmware/whiteheat_loader.fw.gen.S:12: Error: alignment not a power of 2

This file looked like:
-------------------------------------------
/* Generated by firmware/Makefile */
    .section .rodata
    .align 
_fw_whiteheat_loader_fw_bin:
    .incbin "firmware/whiteheat_loader.fw"
_fw_end:
   .section .rodata.str,"aMS",@progbits,1
    .align 3
_fw_whiteheat_loader_fw_name:
    .string "whiteheat_loader.fw"
    .section .builtin_fw,"a",@progbits
    .align 3
    .quad _fw_whiteheat_loader_fw_name
    .quad _fw_whiteheat_loader_fw_bin
    .quad _fw_end - _fw_whiteheat_loader_fw_bin
------------------------------------------------

My gas manual says: "The way the required alignment is specified varies
from system to system."  So you should probably use .p2align instead (see
patch below.

Also:

drivers/net/usb/kaweth.c: In function 'kaweth_download_firmware':
drivers/net/usb/kaweth.c:422: error: 'data' undeclared (first use in this function)

Fixed by patch below (should be done better).
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

>From f0c5123415078e99c9b37d73afb9221dafcecd1d Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 4 Jun 2008 16:44:11 +1000
Subject: [PATCH] firmware: build fixes 1

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/usb/kaweth.c |    2 ++
 firmware/Makefile        |    6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c
index 156b61c..9b1da4b 100644
--- a/drivers/net/usb/kaweth.c
+++ b/drivers/net/usb/kaweth.c
@@ -419,9 +419,11 @@ static int kaweth_download_firmware(struct kaweth_device *kaweth,
 	dbg("High: %i, Low:%i", kaweth->firmware_buf[3],
 		   kaweth->firmware_buf[2]);
 
+#if 0
 	dbg("Downloading firmware at %p to kaweth device at %p",
 	    data,
 	    kaweth);
+#endif
 	dbg("Firmware length: %d", data_len);
 
 	return kaweth_control(kaweth,
diff --git a/firmware/Makefile b/firmware/Makefile
index 1d84237..d1e4675 100644
--- a/firmware/Makefile
+++ b/firmware/Makefile
@@ -61,16 +61,16 @@ quiet_cmd_fwbin = MK_FW   $@
 		  ASM_ALIGN=$(if $(CONFIG_64BIT),3,2);			     \
 		  echo "/* Generated by firmware/Makefile */"		> $@;\
 		  echo "    .section .rodata"				>>$@;\
-		  echo "    .align $(ASM_ALIGN)"			>>$@;\
+		  echo "    .p2align $${ASM_ALIGN}"			>>$@;\
 		  echo "_fw_$${FWSTR}_bin:"				>>$@;\
 		  echo "    .incbin \"$(2)\""				>>$@;\
 		  echo "_fw_end:"					>>$@;\
 		  echo "   .section .rodata.str,\"aMS\",@progbits,1"	>>$@;\
-		  echo "    .align $${ASM_ALIGN}"			>>$@;\
+		  echo "    .p2align $${ASM_ALIGN}"			>>$@;\
 		  echo "_fw_$${FWSTR}_name:"				>>$@;\
 		  echo "    .string \"$$FWNAME\""			>>$@;\
 		  echo "    .section .builtin_fw,\"a\",@progbits"	>>$@;\
-		  echo "    .align $${ASM_ALIGN}"			>>$@;\
+		  echo "    .p2align $${ASM_ALIGN}"			>>$@;\
 		  echo "    $${ASM_WORD} _fw_$${FWSTR}_name" 		>>$@;\
 		  echo "    $${ASM_WORD} _fw_$${FWSTR}_bin" 		>>$@;\
 		  echo "    $${ASM_WORD} _fw_end - _fw_$${FWSTR}_bin"	>>$@;
-- 
1.5.5.3


             reply	other threads:[~2008-06-04  6:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04  6:46 Stephen Rothwell [this message]
2008-06-04  9:22 ` linux-next: firmware build failure David Woodhouse
2008-06-04 10:40   ` Stephen Rothwell
2008-06-04  9:53 ` David Woodhouse
2008-06-04 10:47   ` Stephen Rothwell
2008-06-06  7:47 Stephen Rothwell
2008-06-06  9:09 ` David Woodhouse
2008-06-06  9:31 ` David Woodhouse
2008-06-12  6:28 Stephen Rothwell
2008-06-12  8:54 ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080604164623.3d5f38d2.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=dwmw2@infradead.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).