linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	linux-next@vger.kernel.org
Subject: Re: linux-next: s390 build failure
Date: Sat, 21 Jun 2008 10:07:02 +0200	[thread overview]
Message-ID: <20080621080702.GA4841@osiris.ibm.com> (raw)
In-Reply-To: <20080620114247.GY20851@kernel.dk>

On Fri, Jun 20, 2008 at 01:42:48PM +0200, Jens Axboe wrote:
> On Fri, Jun 20 2008, Stephen Rothwell wrote:
> > Hi Martin,
> > 
> > Starting with next-20080613, the linux-next build (s390 defconfig s390x
> > compiler) has failed with these errors:
> > 
> > In file included from /scratch/michael/kisskb-build/src/include/linux/spinlock.h:87,
> >                  from /scratch/michael/kisskb-build/src/include/linux/smp.h:11,
> >                  from /scratch/michael/kisskb-build/src/include/linux/kernel_stat.h:4,
> >                  from /scratch/michael/kisskb-build/src/mm/memory.c:41:
> > include2/asm/spinlock.h: In function '__raw_spin_lock':
> > include2/asm/spinlock.h:69: error: implicit declaration of function 'smp_processor_id'
> > 
> > There are others as well, but I was concentrating on this.  Bisecting
> > leads to commit 2448ad3d8e64a9b58acca34a3d010cfa0be88cc1 which is the
> > merge of the block tree.  The block tree contains a commit
> > (37e81b98dba08cce1d8eedb2bdaa58022bf31ee0 "Add generic helpers for arch
> > IPI function calls") that adds an include of linux/spinlock.h to
> > linux/smp.h. (asm-s390/spinlock.h includes linux/smp.h ...)
> > 
> > But the block tree itself is OK.  So something in the s390 tree is
> > interacting with the above commit to cause the failure.  It is not
> > immediately obvious to me what that is. (Or I may have screwed up the
> > bisect :-))
> 
> Heiko was looking into this, I had forgotten about it. Heiko, did you
> find an adequate solution to this?

My only conclusion back then was that you shouldn't add the new
#include <linux/spinlock.h> to include <linux/smp.h> (see also Martin's mail).

  reply	other threads:[~2008-06-21  8:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-20  2:42 linux-next: s390 build failure Stephen Rothwell
2008-06-20 11:42 ` Jens Axboe
2008-06-21  8:07   ` Heiko Carstens [this message]
2008-06-26  9:14     ` Jens Axboe
2008-06-20 11:51 ` Martin Schwidefsky
  -- strict thread matches above, loose matches on Subject: below --
2009-03-19 23:53 Stephen Rothwell
2009-03-19 23:42 Stephen Rothwell
2009-03-20  8:24 ` Heiko Carstens
2009-03-20 10:00   ` Ingo Molnar
2009-03-20 10:33     ` Heiko Carstens
2008-06-20  3:52 Stephen Rothwell
2008-06-20  7:58 ` Cornelia Huck
2008-06-23 15:22   ` Cornelia Huck
2008-06-23 22:13     ` Greg KH
2008-05-12  8:03 Stephen Rothwell
2008-05-12 16:49 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080621080702.GA4841@osiris.ibm.com \
    --to=heiko.carstens@de.ibm.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-next@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).