From: Stephen Rothwell <sfr@canb.auug.org.au>
To: David Miller <davem@davemloft.net>
Cc: linux-next@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Greg KH <greg@kroah.com>
Subject: linux-next: sparc64 build failure
Date: Tue, 8 Jul 2008 19:08:37 +1000 [thread overview]
Message-ID: <20080708190837.bcdcbbd6.sfr@canb.auug.org.au> (raw)
Hi David,
Today's linux-next build (sparc64 defconfig) failed like this:
arch/sparc64/kernel/sysfs.c:160: warning: initialization from incompatible pointer type
arch/sparc64/kernel/sysfs.c:160: warning: initialization from incompatible pointer type
arch/sparc64/kernel/sysfs.c:205: warning: initialization from incompatible pointer type
arch/sparc64/kernel/sysfs.c:206: warning: initialization from incompatible pointer type
arch/sparc64/kernel/sysfs.c:207: warning: initialization from incompatible pointer type
arch/sparc64/kernel/sysfs.c:208: warning: initialization from incompatible pointer type
arch/sparc64/kernel/sysfs.c:209: warning: initialization from incompatible pointer type
arch/sparc64/kernel/sysfs.c:210: warning: initialization from incompatible pointer type
arch/sparc64/kernel/sysfs.c:211: warning: initialization from incompatible pointer type
make[2]: *** [arch/sparc64/kernel/sysfs.o] Error 1
Caused by commit 5b01a6a61c48d8e6ab4679d6e6208f5962d07b85 ("sysdev: Pass
the attribute to the low level sysdev show/store function") from the
driver-core tree. I have applied the patch below.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
>From 2b3ba8b78163527dade51c5c92ce52526abbb198 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 8 Jul 2008 19:03:49 +1000
Subject: [PATCH] sparc64: sysdev API change fallout
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
arch/sparc64/kernel/sysfs.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/sparc64/kernel/sysfs.c b/arch/sparc64/kernel/sysfs.c
index b057bc1..47478ce 100644
--- a/arch/sparc64/kernel/sysfs.c
+++ b/arch/sparc64/kernel/sysfs.c
@@ -136,13 +136,13 @@ static unsigned long write_mmustat_enable(unsigned long val)
return sun4v_mmustat_conf(ra, &orig_ra);
}
-static ssize_t show_mmustat_enable(struct sys_device *s, char *buf)
+static ssize_t show_mmustat_enable(struct sys_device *s, struct sysdev_attribute *attr, char *buf)
{
unsigned long val = run_on_cpu(s->id, read_mmustat_enable, 0);
return sprintf(buf, "%lx\n", val);
}
-static ssize_t store_mmustat_enable(struct sys_device *s, const char *buf, size_t count)
+static ssize_t store_mmustat_enable(struct sys_device *s, struct sysdev_attribute *attr, const char *buf, size_t count)
{
unsigned long val, err;
int ret = sscanf(buf, "%ld", &val);
@@ -180,14 +180,14 @@ static void unregister_mmu_stats(struct sys_device *s)
#endif
#define SHOW_CPUDATA_ULONG_NAME(NAME, MEMBER) \
-static ssize_t show_##NAME(struct sys_device *dev, char *buf) \
+static ssize_t show_##NAME(struct sys_device *dev, struct sysdev_attribute *attr, char *buf) \
{ \
cpuinfo_sparc *c = &cpu_data(dev->id); \
return sprintf(buf, "%lu\n", c->MEMBER); \
}
#define SHOW_CPUDATA_UINT_NAME(NAME, MEMBER) \
-static ssize_t show_##NAME(struct sys_device *dev, char *buf) \
+static ssize_t show_##NAME(struct sys_device *dev, struct sysdev_attribute *attr, char *buf) \
{ \
cpuinfo_sparc *c = &cpu_data(dev->id); \
return sprintf(buf, "%u\n", c->MEMBER); \
--
1.5.6.2
next reply other threads:[~2008-07-08 9:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 9:08 Stephen Rothwell [this message]
2008-07-08 9:13 ` linux-next: sparc64 build failure David Miller
-- strict thread matches above, loose matches on Subject: below --
2008-07-09 11:15 Stephen Rothwell
2008-07-09 21:23 ` Sam Ravnborg
2008-06-20 0:43 Stephen Rothwell
2008-06-20 0:55 ` David Miller
2008-06-20 1:11 ` Stephen Rothwell
2008-06-20 7:34 ` Sam Ravnborg
2008-06-20 7:53 ` Stephen Rothwell
2008-06-20 8:34 ` Sam Ravnborg
2008-06-21 0:02 ` Stephen Rothwell
2008-05-29 7:53 Stephen Rothwell
2008-05-29 22:01 ` Greg KH
2008-05-30 5:38 ` Stephen Rothwell
2008-05-30 14:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080708190837.bcdcbbd6.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).