From: Ingo Molnar <mingo@elte.hu>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Peter Oruba <peter.oruba@amd.com>,
x86@kernel.org, linux-next@vger.kernel.org,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] microcode_amd: fix shift warning
Date: Fri, 22 Aug 2008 06:55:34 +0200 [thread overview]
Message-ID: <20080822045534.GA3686@elte.hu> (raw)
In-Reply-To: <20080821134351.2b19ac2d.randy.dunlap@oracle.com>
* Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> microcode_amd.c uses ">> 32" on a 32-bit value, so gcc warns about that.
> The code could use something like this *untested* patch.
>
> linux-next-20080821/arch/x86/kernel/microcode_amd.c:229: warning: right shift count >= width of type
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
applied to tip/x86/microcode - thanks Randy!
Ingo
prev parent reply other threads:[~2008-08-22 4:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 20:43 [PATCH -next] microcode_amd: fix shift warning Randy Dunlap
2008-08-22 4:55 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080822045534.GA3686@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-next@vger.kernel.org \
--cc=peter.oruba@amd.com \
--cc=randy.dunlap@oracle.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).