linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-next@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: linux-next: build failure
Date: Wed, 27 Aug 2008 14:54:49 +1000	[thread overview]
Message-ID: <20080827145449.2790d97d.sfr@canb.auug.org.au> (raw)
In-Reply-To: <200808271255.22789.rusty@rustcorp.com.au>

Hi Rusty,

On Wed, 27 Aug 2008 12:55:22 +1000 Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> On Wednesday 27 August 2008 10:06:56 Stephen Rothwell wrote:
> > Introduced by commit 4cb9da6ecc2b0e25056b45981239475f8509d59d ("remove
> > CONFIG_KMOD from net") which added a !CONFIG_MODULES (static inline)
> > version of dev_load() to include/linux/netdevice.h but the copy in
> > net/core/dev.c is not protected by CONFIG_MODULES.
> 
> Thanks.  I've fixed this the simplest way: remove the change to the header.

So, for today, I have applied the following patch after importing the rr
tree:

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 27 Aug 2008 14:45:37 +1000
Subject: [PATCH] rr: build fix for remove CONFIG_KMOD from net

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/netdevice.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index b215744..2254eb8 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1639,11 +1639,7 @@ extern int		dev_set_allmulti(struct net_device *dev, int inc);
 extern void		netdev_state_change(struct net_device *dev);
 extern void		netdev_bonding_change(struct net_device *dev);
 extern void		netdev_features_change(struct net_device *dev);
-#ifdef CONFIG_MODULES
 extern void		dev_load(struct net *net, const char *name);
-#else
-static inline void	dev_load(struct net *net, const char *name) {};
-#endif
 extern void		dev_mcast_init(void);
 extern int		netdev_max_backlog;
 extern int		weight_p;
-- 
1.5.6.5

  reply	other threads:[~2008-08-27  4:55 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-27  0:06 linux-next: build failure Stephen Rothwell
2008-08-27  2:55 ` Rusty Russell
2008-08-27  4:54   ` Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-05-12 13:18 linux-next " Mark Salter
2014-05-12 15:47 ` Mark Salter
2014-05-12 17:05 ` Al Viro
2014-01-03 15:58 Mark Salter
2014-01-03 22:56 ` Andrew Morton
2014-01-06 15:21   ` Mark Salter
2013-11-08 16:51 Mark Salter
2013-10-30 15:27 Mark Salter
2013-10-30 20:37 ` Stephen Rothwell
2013-10-30 20:50   ` Andrew Morton
2013-10-30 23:17     ` Stephen Rothwell
     [not found] <CAHfT02u5as-YvAvwznMveNY_FbeDWLbj0NL6O78MRfeLQ5mpsA@mail.gmail.com>
2011-12-22 23:55 ` linux-next: " Carles Pey
2011-12-23  6:08   ` Stephen Rothwell
2011-12-30 19:43     ` Carles Pey
2009-04-08  4:04 Stephen Rothwell
2009-04-08  5:12 ` Alan Modra
2009-02-02  9:02 Stephen Rothwell
2009-02-02 19:43 ` Yinghai Lu
2009-02-03  6:14 ` David Miller
2009-01-08  5:20 Stephen Rothwell
2009-01-08  5:42 ` David Miller
2008-12-09  7:34 Stephen Rothwell
2008-12-09 21:05 ` Jesse Barnes
2008-11-11  8:10 Stephen Rothwell
2008-11-11  8:15 ` Sujith
2008-11-11  9:18 ` David Miller
2008-11-07  9:25 Stephen Rothwell
2008-11-07 16:40 ` Hollis Blanchard
2008-11-07 17:05   ` Josh Boyer
2008-11-07 17:24     ` Hollis Blanchard
2008-11-07 17:34       ` Josh Boyer
2008-11-07 21:18         ` Hollis Blanchard
2008-11-07 22:54   ` Stephen Rothwell
2008-11-09 15:50     ` Avi Kivity
2008-10-23  9:51 Stephen Rothwell
2008-10-23  9:18 Stephen Rothwell
2008-10-20 12:04 Stephen Rothwell
2008-10-20 15:48 ` Greg KH
2008-10-20 16:33   ` J.R. Mauro
2008-10-20 16:51     ` Greg KH
2008-10-20 20:47       ` Greg KH
2008-10-20 22:34         ` J.R. Mauro
2008-10-20 22:31   ` Stephen Rothwell
2008-10-17  8:21 Stephen Rothwell
2008-10-17 17:37 ` Greg KH
2008-10-17  7:59 Stephen Rothwell
2008-10-16  9:29 Stephen Rothwell
2008-10-16 10:39 ` Ingo Molnar
2008-10-16 16:11   ` Jeremy Fitzhardinge
2008-10-16 16:14     ` Ingo Molnar
2008-10-16  9:28 Stephen Rothwell
2008-10-16 14:00 ` Eric Van Hensbergen
2008-09-03  8:45 Stephen Rothwell
2008-09-03 10:19 ` David Woodhouse
2008-08-25 11:28 Stephen Rothwell
2008-08-25 12:40 ` Ingo Molnar
2008-08-28  7:40 ` David Miller
2008-07-30  5:30 Stephen Rothwell
2008-07-30  5:54 ` Ananth N Mavinakayanahalli
2008-07-30  6:41 ` Adrian Bunk
     [not found]   ` <20080730064146.GA1564-re2QNgSbS3j4D6uPqz5PAwR5/fbUUdgG@public.gmane.org>
2008-07-30  7:06     ` Ankita Garg
     [not found]       ` <20080730070643.GA18347-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org>
2008-07-30 19:16         ` Bartlomiej Zolnierkiewicz
2008-07-30 23:35           ` Stephen Rothwell
2008-07-29  6:23 Stephen Rothwell
2008-07-29  8:00 ` Ingo Molnar
2008-07-29  8:03   ` Stephen Rothwell
2008-07-29  8:58     ` Ingo Molnar
2008-07-29 11:28       ` KOSAKI Motohiro
2008-07-29 11:40         ` Ingo Molnar
2008-07-29 14:31           ` Mike Travis
2008-07-29 14:33             ` Mike Travis
2008-07-29 16:33           ` Linus Torvalds
2008-07-29 16:42             ` Ingo Molnar
2008-07-29 16:44             ` Linus Torvalds
2008-07-29  8:14   ` Wenji Huang
2008-07-29 16:26   ` Linus Torvalds
2008-07-28  5:07 Stephen Rothwell
2008-07-28  4:44 Stephen Rothwell
2008-07-25  6:45 Stephen Rothwell
2008-06-30 13:22 Stephen Rothwell
2008-06-30 14:06 ` Ingo Molnar
2008-06-30 14:46   ` Stephen Rothwell
2008-06-30 15:12 ` Randy Dunlap
2008-06-30 15:49   ` Randy Dunlap
2008-06-30 23:30     ` Stephen Rothwell
2008-06-30 16:10 ` Sam Ravnborg
2008-06-30 16:44   ` Randy Dunlap
     [not found] <20080512154717.2d0947f0.sfr@canb.auug.org.au>
2008-05-12  7:54 ` David Miller
2008-05-12  8:09   ` Stephen Rothwell
2008-05-12  8:15     ` Stephen Rothwell
2008-05-12  8:53       ` David Miller
2008-05-12 10:42         ` Stephen Rothwell
2008-05-12 16:50 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080827145449.2790d97d.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=johannes@sipsolutions.net \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).