linux-next: sparc build failure

linux-next: sparc build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Hi Dave,

The sparc32 allmodconfig build of linux-next (next-20080827) failed like
this (among other things):

ERROR: "nr_irqs" [drivers/net/hamradio/baycom_ser_fdx.ko] undefined!
ERROR: "nr_irqs" [drivers/net/3c59x.ko] undefined!

Introduced by the sparseirq tree.

nr_irqs is not exported for sparc.  I will add a patch to add the export
to linux-next today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: sparc build failure

[Ingo Molnar]

* Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Dave,
> 
> The sparc32 allmodconfig build of linux-next (next-20080827) failed like
> this (among other things):
> 
> ERROR: "nr_irqs" [drivers/net/hamradio/baycom_ser_fdx.ko] undefined!
> ERROR: "nr_irqs" [drivers/net/3c59x.ko] undefined!
> 
> Introduced by the sparseirq tree.
> 
> nr_irqs is not exported for sparc.  I will add a patch to add the export
> to linux-next today.

thanks - the patch below should fix all those architectures. (there's 
also s390)

	Ingo

---------->
>From 3af7043c57080f1ae7cd80c661d3e1308f164e1b Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Thu, 28 Aug 2008 08:56:33 +0200
Subject: [PATCH] sparseirq: export nr_irqs on m68k/sparc/s390

Stephen Rothwell reported such build failures on m68k/sparc/s390:

> ERROR: "nr_irqs" [drivers/net/hamradio/baycom_ser_fdx.ko] undefined!
> ERROR: "nr_irqs" [drivers/net/3c59x.ko] undefined!

export nr_irqs on these architectures too.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/m68k/kernel/ints.c |    1 +
 arch/s390/kernel/irq.c  |    1 +
 arch/sparc/kernel/irq.c |    1 +
 3 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/m68k/kernel/ints.c b/arch/m68k/kernel/ints.c
index d8aebfc..8dd5591 100644
--- a/arch/m68k/kernel/ints.c
+++ b/arch/m68k/kernel/ints.c
@@ -47,6 +47,7 @@
 #endif
 
 int nr_irqs = NR_IRQS;
+EXPORT_SYMBOL(nr_irqs);
 
 extern u32 auto_irqhandler_fixup[];
 extern u32 user_irqhandler_fixup[];
diff --git a/arch/s390/kernel/irq.c b/arch/s390/kernel/irq.c
index 14eb549..3624c4a 100644
--- a/arch/s390/kernel/irq.c
+++ b/arch/s390/kernel/irq.c
@@ -18,6 +18,7 @@
 #include <linux/profile.h>
 
 int nr_irqs = NR_IRQS;
+EXPORT_SYMBOL(nr_irqs);
 
 /*
  * show_interrupts is needed by /proc/interrupts.
diff --git a/arch/sparc/kernel/irq.c b/arch/sparc/kernel/irq.c
index 059598b..4b99e3c 100644
--- a/arch/sparc/kernel/irq.c
+++ b/arch/sparc/kernel/irq.c
@@ -57,6 +57,7 @@
 #endif /* SMP */
 
 int nr_irqs = NR_IRQS;
+EXPORT_SYMBOL(nr_irqs);
 
 unsigned long __raw_local_irq_save(void)
 {

Re: linux-next: sparc build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

Hi Ingo,

On Thu, 28 Aug 2008 08:57:54 +0200 Ingo Molnar <mingo@elte.hu> wrote:
>
> thanks - the patch below should fix all those architectures. (there's 
> also s390)

Thanks, saves me writing the patch :-)

Actually, it appears that s390 allmodconfig doesn't build any modules
that require nr_irqs.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: sparc build failure

[Ingo Molnar]

* Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Ingo,
> 
> On Thu, 28 Aug 2008 08:57:54 +0200 Ingo Molnar <mingo@elte.hu> wrote:
> >
> > thanks - the patch below should fix all those architectures. (there's 
> > also s390)
> 
> Thanks, saves me writing the patch :-)
> 
> Actually, it appears that s390 allmodconfig doesn't build any modules 
> that require nr_irqs.

ok - but was still worth fixing as a general principle: if something 
like nr_irqs is exported in kernel/irq/manage.c then it should be 
exported in non-genirq architectures as well.

	Ingo

linux-next: sparc build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1380 bytes --]

Hi Dave,

Today's linux-next build (sparc allmodconfig) fails like this:

In file included from include2/asm/sigcontext.h:6,
                 from include2/asm/signal.h:5,
                 from include/linux/signal.h:4,
                 from fs/ocfs2/dlm/userdlm.c:30:
include2/asm/ptrace.h:42: error: syntax error before "pt_regs_is_syscall"
include2/asm/ptrace.h:43: warning: return type defaults to `int'
include2/asm/ptrace.h:47: error: syntax error before "pt_regs_clear_syscall"
include2/asm/ptrace.h:48: warning: return type defaults to `int'

In file included from include2/asm/sigcontext.h:6,
                 from include2/asm/signal.h:5,
                 from include/linux/signal.h:4,
                 from drivers/net/usb/rtl8150.c:10:
include2/asm/ptrace.h:42: error: syntax error before "pt_regs_is_syscall"
include2/asm/ptrace.h:43: warning: return type defaults to `int'
include2/asm/ptrace.h:47: error: syntax error before "pt_regs_clear_syscall"
include2/asm/ptrace.h:48: warning: return type defaults to `int'

Seems to have been introduced by commit
28e6103665301ce60634e8a77f0b657c6cc099de ("sparc: Fix debugger syscall
restart interactions") which went into Linus' tree recently ("bool" seems
to be missing a definition).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: linux-next: sparc build failure

[David Miller]

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 12 May 2008 17:36:58 +1000

> Seems to have been introduced by commit
> 28e6103665301ce60634e8a77f0b657c6cc099de ("sparc: Fix debugger syscall
> restart interactions") which went into Linus' tree recently ("bool" seems
> to be missing a definition).

Fixed in current sparc-2.6.git

Re: linux-next: sparc build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

Hi Dave,

On Mon, 12 May 2008 00:40:31 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 12 May 2008 17:36:58 +1000
> 
> > Seems to have been introduced by commit
> > 28e6103665301ce60634e8a77f0b657c6cc099de ("sparc: Fix debugger syscall
> > restart interactions") which went into Linus' tree recently ("bool" seems
> > to be missing a definition).
> 
> Fixed in current sparc-2.6.git

OK, thanks ... tomorrow.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]