linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-next@vger.kernel.org, Greg KH <greg@kroah.com>
Subject: linux-next: manual merge of the ttydev tree
Date: Fri, 19 Sep 2008 12:53:32 +1000	[thread overview]
Message-ID: <20080919125332.f84ddf4b.sfr@canb.auug.org.au> (raw)

Hi Alan,

Today's linux-next merge of the ttydev tree got a conflict in
drivers/char/ip2/ip2main.c between commit
64dd9a65b282990a82d5ca0459e0be291f00270c ("device create: char: convert
device_create_drvdata to device_create") from the driver-core tree and
commit f9d65d9f1b0ad12c71771e1c47fb585da1f19818 ("ip2-cleanup-init") from
the ttydev tree.

I fixed it up (see below).
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

diff --cc drivers/char/ip2/ip2main.c
index e215e0c,6774572..0000000
--- a/drivers/char/ip2/ip2main.c
+++ b/drivers/char/ip2/ip2main.c
@@@ -705,23 -731,24 +731,24 @@@ static int __init ip2_loadmain(void
  	/* Register the read_procmem thing */
  	if (!proc_create("ip2mem",0,NULL,&ip2mem_proc_fops)) {
  		printk(KERN_ERR "IP2: failed to register read_procmem\n");
- 	} else {
+ 		return -EIO; /* leaking resources */
+ 	}
  
- 	ip2trace (ITRC_NO_PORT, ITRC_INIT, 4, 0 );
- 		/* Register the interrupt handler or poll handler, depending upon the
- 		 * specified interrupt.
- 		 */
+ 	ip2trace(ITRC_NO_PORT, ITRC_INIT, 4, 0);
+ 	/* Register the interrupt handler or poll handler, depending upon the
+ 	 * specified interrupt.
+ 	 */
  
- 		for( i = 0; i < IP2_MAX_BOARDS; ++i ) {
- 			if ( 0 == ip2config.addr[i] ) {
- 				continue;
- 			}
+ 	for (i = 0; i < IP2_MAX_BOARDS; ++i) {
+ 		if (ip2config.addr[i] == 0)
+ 			continue;
  
- 			if ( NULL != ( pB = i2BoardPtrTable[i] ) ) {
- 				device_create(ip2_class, NULL,
+ 		pB = i2BoardPtrTable[i];
+ 		if (pB != NULL) {
 -			device_create_drvdata(ip2_class, NULL,
++			device_create(ip2_class, NULL,
  					      MKDEV(IP2_IPL_MAJOR, 4 * i),
  					      NULL, "ipl%d", i);
- 				device_create(ip2_class, NULL,
 -			device_create_drvdata(ip2_class, NULL,
++			device_create(ip2_class, NULL,
  					      MKDEV(IP2_IPL_MAJOR, 4 * i + 1),
  					      NULL, "stat%d", i);
  

             reply	other threads:[~2008-09-19  2:53 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-19  2:53 Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-12-11  6:26 linux-next: manual merge of the ttydev tree Stephen Rothwell
2008-12-11 10:21 ` Alan Cox
2008-12-11 14:46   ` Dan Williams
2008-09-19  2:57 Stephen Rothwell
2008-08-25  8:33 Stephen Rothwell
2008-08-25  8:24 Stephen Rothwell
2008-08-22  5:51 Stephen Rothwell
2008-08-21  8:03 Stephen Rothwell
2008-08-21 10:21 ` Alan Cox
2008-08-21 12:14   ` Stephen Rothwell
2008-08-19  7:43 Stephen Rothwell
2008-08-19 19:57 ` Greg KH
2008-08-18  6:08 Stephen Rothwell
2008-08-14  5:50 Stephen Rothwell
2008-08-12  6:58 Stephen Rothwell
2008-08-12 20:42 ` Greg KH
2008-08-12  6:55 Stephen Rothwell
2008-07-23  6:47 Stephen Rothwell
2008-07-22  6:37 Stephen Rothwell
2008-07-22 10:31 ` Alan Cox
2008-07-21  7:20 Stephen Rothwell
2008-07-18  8:48 Stephen Rothwell
2008-07-18  8:41 Stephen Rothwell
2008-07-18  8:28 Stephen Rothwell
2008-07-18  8:23 Stephen Rothwell
2008-07-18  8:20 Stephen Rothwell
2008-07-18  8:49 ` Alan Cox
2008-07-18 10:49   ` Adrian Bunk
2008-07-18 10:55     ` David Miller
2008-07-18 11:00       ` Adrian Bunk
2008-07-04  9:11 Stephen Rothwell
2008-07-04 15:41 ` Alan Cox
2008-07-01 14:12 Stephen Rothwell
2008-07-01 14:16 ` Alan Cox
2008-07-01 14:09 Stephen Rothwell
2008-07-01 14:14 ` Alan Cox
2008-07-01 14:07 Stephen Rothwell
2008-07-01 14:12 ` Alan Cox
2008-07-01 14:43   ` Adrian Bunk
2008-07-01 15:42     ` Alan Cox
2008-07-01 16:45       ` Adrian Bunk
2008-07-01 14:04 Stephen Rothwell
2008-07-01 13:56 Stephen Rothwell
2008-07-01 13:54 Stephen Rothwell
2008-07-01 13:43 Stephen Rothwell
2008-07-01 12:43 Stephen Rothwell
2008-07-01 14:09 ` Alan Cox
2008-07-01 15:07   ` David Woodhouse
2008-07-01 15:29     ` Alan Cox
2008-07-02  9:01       ` David Woodhouse
2008-07-02  9:17         ` Alan Cox
2008-07-02  9:50           ` David Woodhouse
2008-07-02  9:43             ` Alan Cox
2008-07-01 12:35 Stephen Rothwell
2008-07-01 11:57 Stephen Rothwell
2008-07-01 11:59 ` Felipe Balbi
2008-07-01 15:25   ` Greg KH
2008-07-01 11:44 Stephen Rothwell
2008-07-01 11:37 Stephen Rothwell
2008-07-01 11:33 Stephen Rothwell
2008-07-12 18:59 ` Jesper Juhl
2008-07-12 20:29   ` Alan Cox
2008-07-13  1:20   ` Stephen Rothwell
2008-07-01 11:23 Stephen Rothwell
2008-07-01 11:17 Stephen Rothwell
2008-07-01 11:10 Stephen Rothwell
2008-07-01 11:56 ` Alan Cox
2008-07-01 16:18   ` David Brownell
2008-07-01 16:27     ` Alan Cox
2008-07-01 10:59 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080919125332.f84ddf4b.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=greg@kroah.com \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).