linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	linux-next@vger.kernel.org,
	Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	ppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: linux-next: ttydev tree build failure
Date: Thu, 23 Oct 2008 12:28:05 +0200	[thread overview]
Message-ID: <20081023102805.GA4197@cetus.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20081023172938.0460b191.sfr@canb.auug.org.au>

On Thu, Oct 23, 2008 at 05:29:38PM +1100, Stephen Rothwell wrote:
> drivers/char/hvc_console.c: In function 'hvc_set_winsz':
> drivers/char/hvc_console.c:532: warning: passing argument 2 of 'tty_do_resize' from incompatible pointer type
> drivers/char/hvc_console.c:532: error: too many arguments to function 'tty_do_resize'
> 
> Caused by commit eb6ab2d361a49470ca9785c70482772c19e49bec
> ("pty-simplify-resize") from the ttydev tree interacting with commit
> febde3711992a64ea83a47a719f68a90c4b0927a ("hvc_console: Add support for
> tty window resizing").
> 
> The former added another call to the function that the latter changed.
In linux-next, the pty-simplify-resize patch has changed the
tty_do_resize() signature; and therefore the hvc patch did not compile.

> I applied the following patch.
The patch is correct.
Thanks.

Acked-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>

-- 
Regards
Hendrik

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschaeftsfuehrung: Erich Baier
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

  parent reply	other threads:[~2008-10-23 10:29 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-23  6:29 linux-next: ttydev tree build failure Stephen Rothwell
2008-10-23  7:34 ` Alan Cox
2008-10-23  7:35   ` Benjamin Herrenschmidt
2008-10-24  4:58   ` Stephen Rothwell
2008-10-23 10:28 ` Hendrik Brueckner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-07-24  5:54 Stephen Rothwell
2009-07-17  3:12 Stephen Rothwell
2009-07-16  5:04 Stephen Rothwell
2009-07-14  4:10 Stephen Rothwell
2009-07-06  3:26 Stephen Rothwell
2009-04-20  3:09 Stephen Rothwell
2008-11-24  5:13 Stephen Rothwell
2008-11-24  9:59 ` Alan Cox
2008-10-20  8:06 Stephen Rothwell
2008-10-20 21:48 ` Lee Howard
2008-10-21  9:33   ` Alan Cox
2008-10-15  9:39 Stephen Rothwell
2008-09-02  7:23 Stephen Rothwell
2008-09-02  9:22 ` Alan Cox
2008-08-20  8:23 Stephen Rothwell
2008-08-20  8:26 ` Alan Cox
2008-08-20  9:08   ` Stephen Rothwell
2008-07-23  7:17 Stephen Rothwell
2008-07-23 12:39 ` Geert Uytterhoeven
2008-07-23 14:46   ` Alan Cox
2008-07-23 15:49     ` Geert Uytterhoeven
2008-07-23 15:47       ` Alan Cox
2008-07-23 16:39         ` Geert Uytterhoeven
2008-07-23 16:28           ` Alan Cox
2008-07-23 18:55             ` Geert Uytterhoeven
2008-07-18 21:34 Aleksey Gorelov
2008-07-18  8:59 Stephen Rothwell
2008-07-02  5:30 Stephen Rothwell
2008-07-02 18:10 ` Randy Dunlap
2008-07-02 19:54   ` Alan Cox
2008-07-02  5:19 Stephen Rothwell
2008-07-02  5:21 ` Stephen Rothwell
2008-07-02  8:09 ` Alan Cox
2008-07-02  5:08 Stephen Rothwell
2008-07-02  8:05 ` Alan Cox
2008-07-01 14:17 Stephen Rothwell
2008-07-01 14:23 ` Alan Cox
2008-07-01 14:51   ` Stephen Rothwell
2008-07-01 15:27     ` Greg KH
2008-07-01 15:36     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081023102805.GA4197@cetus.boeblingen.de.ibm.com \
    --to=brueckner@linux.vnet.ibm.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=benh@kernel.crashing.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).