From: Ingo Molnar <mingo@elte.hu>
To: Ken Chen <kenchen@google.com>, Paul Mackerras <paulus@samba.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-next@vger.kernel.org
Subject: Re: linux-next: sched tree build warning
Date: Mon, 22 Dec 2008 08:04:26 +0100 [thread overview]
Message-ID: <20081222070426.GD29160@elte.hu> (raw)
In-Reply-To: <b040c32a0812212249p45aba306tbb68a960b79cd0ee@mail.gmail.com>
* Ken Chen <kenchen@google.com> wrote:
> On Sun, Dec 21, 2008 at 8:22 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Today's linux-next build (powerpc ppc64_defconfig) produced this new
> > warning:
> >
> > fs/proc/base.c: In function 'proc_pid_schedstat':
> > fs/proc/base.c:352: warning: format '%llu' expects type 'long long unsigned int',
> > but argument 3 has type 'u64'
> >
> > Introduced by commit 9c2c48020ec0dd6ecd27e5a1298f73b40d85a595
> > ("schedstat: consolidate per-task cpu runtime stats").
>
> oh boy, this is the 2nd time that printing u64 bite me, I really need to
> get hold of a machine that is non-x86_64.
>
> Just saw Ingo's patch came in while I'm typing this email. Thank you
> Ingo for fixing this.
the real solution is something like the patch below. That generates new
(but harmless) warnings within the powerpc code but those are a one-off
effort to fix and are not reoccuring.
Cc:-ed Paul Mackerras - Paul, am i missing anything?
Ingo
--------------->
>From 3d835af97da5b6cb755ca4f8464f8e636cc321da Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Mon, 22 Dec 2008 08:02:06 +0100
Subject: [PATCH] powerpc: fix u64
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/powerpc/include/asm/types.h | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/include/asm/types.h b/arch/powerpc/include/asm/types.h
index c004c13..1cbfd7f 100644
--- a/arch/powerpc/include/asm/types.h
+++ b/arch/powerpc/include/asm/types.h
@@ -1,11 +1,7 @@
#ifndef _ASM_POWERPC_TYPES_H
#define _ASM_POWERPC_TYPES_H
-#ifdef __powerpc64__
-# include <asm-generic/int-l64.h>
-#else
-# include <asm-generic/int-ll64.h>
-#endif
+#include <asm-generic/int-ll64.h>
#ifndef __ASSEMBLY__
next prev parent reply other threads:[~2008-12-22 7:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-22 4:22 linux-next: sched tree build warning Stephen Rothwell
2008-12-22 6:47 ` Ingo Molnar
2008-12-22 6:49 ` Ken Chen
2008-12-22 7:04 ` Ingo Molnar [this message]
2008-12-22 7:19 ` Stephen Rothwell
2008-12-22 8:03 ` [patch] powerpc: change u64/s64 to a long long integer type Ingo Molnar
2008-12-22 22:43 ` Andrew Morton
2008-12-22 23:00 ` Sam Ravnborg
2008-12-22 23:03 ` H. Peter Anvin
2008-12-22 23:13 ` Sam Ravnborg
2008-12-22 23:13 ` Andrew Morton
2008-12-23 13:17 ` [PATCH] sparc64: use unsigned long long for u64 Sam Ravnborg
2008-12-23 14:42 ` [PATCH] sparc64: fix unsigned long long warnings in drivers Sam Ravnborg
2008-12-23 17:05 ` [PATCH] sparc64: use unsigned long long for u64 Ken Chen
2008-12-23 17:26 ` Sam Ravnborg
2008-12-23 17:29 ` Ken Chen
2008-12-23 17:34 ` Sam Ravnborg
2008-12-27 8:54 ` David Miller
2008-12-27 9:24 ` Sam Ravnborg
2008-12-27 9:37 ` David Miller
2008-12-27 9:49 ` Sam Ravnborg
2008-12-28 4:25 ` David Miller
2008-12-28 12:32 ` Sam Ravnborg
2008-12-31 4:40 ` [patch] powerpc: change u64/s64 to a long long integer type Stephen Rothwell
2008-12-31 7:52 ` Ingo Molnar
2008-12-22 8:14 ` linux-next: sched tree build warning Paul Mackerras
2008-12-22 8:18 ` Ingo Molnar
2008-12-22 9:44 ` Paul Mackerras
2008-12-22 10:53 ` Ingo Molnar
2008-12-22 12:03 ` Paul Mackerras
2009-04-21 0:27 Stephen Rothwell
2009-04-21 3:10 ` Gautham R Shenoy
2009-04-21 3:28 ` Stephen Rothwell
2009-04-21 6:09 ` Ingo Molnar
2009-04-21 6:21 ` Rusty Russell
2009-05-07 1:21 Stephen Rothwell
2009-05-07 6:45 ` David Rientjes
2009-05-07 7:39 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081222070426.GD29160@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=kenchen@google.com \
--cc=linux-next@vger.kernel.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).