Hi Greg, On Mon, 29 Dec 2008 17:34:44 +1100 Stephen Rothwell wrote: > > On Mon, 22 Dec 2008 20:29:32 -0800 Greg KH wrote: > > > > On Mon, Dec 22, 2008 at 02:50:46PM +0000, Mark McLoughlin wrote: > > > On Mon, 2008-12-22 at 23:59 +1100, Stephen Rothwell wrote: > > > > Hi Greg, > > > > > > > > Today's linux-next build (powerpc allnoconfig) failed like this: > > > > > > > > drivers/base/core.c: In function '__root_device_register': > > > > drivers/base/core.c:1277: error: dereferencing pointer to incomplete type > > > > > > > > Caused by bf86dbd2451d1012c2c968a960470e485b869f5b ("driver core: add > > > > root_device_register()"). This needs to cope with !CONFIG_MODULES (where > > > > struct module is not defined). > > > > > > Ouch, my bad. > > > > > > > I applied the following patch but only for today because it is too hard > > > > to revert the above patch ... > > > > > > > > Ick, I hate ifdefs... I'll go fix this up. > > Its still there today. Lucky for you I didn't notice early enough to > drop the driver-core tree :-). I will reapply my patch. Today I dropped the driver-core tree (and the usb and staging trees that depend on it). -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/