From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: linux-next: driver-core tree build failure
Date: Sun, 25 Jan 2009 17:10:07 -0800 [thread overview]
Message-ID: <20090126011007.GA24070@kroah.com> (raw)
In-Reply-To: <20090126115044.0b2e3936.sfr@canb.auug.org.au>
On Mon, Jan 26, 2009 at 11:50:44AM +1100, Stephen Rothwell wrote:
> Hi Greg,
>
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>
> arch/powerpc/platforms/ps3/system-bus.c: In function 'ps3_system_bus_probe':
> arch/powerpc/platforms/ps3/system-bus.c:379: error: 'struct device' has no member named 'bus_id'
> arch/powerpc/platforms/ps3/system-bus.c: In function 'ps3_system_bus_remove':
> arch/powerpc/platforms/ps3/system-bus.c:401: error: 'struct device' has no member named 'bus_id'
>
> Caused by commit aab0d375e01d8c16e7e5b9bd915dfaa0a815418f ("powerpc:
> struct device - replace bus_id with dev_name(), dev_set_name()") not
> being thorough enough before commit
> 73babb2d89a71d2110b65aab658e6309748827c2 ("driver core: get rid of struct
> device's bus_id string array") was applied.
>
> I have reverted the latter commit.
Gotta love the ps3 platform code, there is about 3 different fields
called "bus_id" in that file :(
Anyway, here's a patch that should fix this, Kay, look sane?
thanks,
greg k-h
---
arch/powerpc/platforms/ps3/system-bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/arch/powerpc/platforms/ps3/system-bus.c
+++ b/arch/powerpc/platforms/ps3/system-bus.c
@@ -376,7 +376,7 @@ static int ps3_system_bus_probe(struct d
struct ps3_system_bus_driver *drv;
BUG_ON(!dev);
- pr_debug(" -> %s:%d: %s\n", __func__, __LINE__, _dev->bus_id);
+ dev_dbg(_dev, "%s:%d\n", __func__, __LINE__);
drv = ps3_system_bus_dev_to_system_bus_drv(dev);
BUG_ON(!drv);
@@ -398,7 +398,7 @@ static int ps3_system_bus_remove(struct
struct ps3_system_bus_driver *drv;
BUG_ON(!dev);
- pr_debug(" -> %s:%d: %s\n", __func__, __LINE__, _dev->bus_id);
+ dev_dbg(_dev, "%s:%d\n", __func__, __LINE__);
drv = ps3_system_bus_dev_to_system_bus_drv(dev);
BUG_ON(!drv);
next prev parent reply other threads:[~2009-01-26 1:11 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-26 0:50 linux-next: driver-core tree build failure Stephen Rothwell
2009-01-26 1:10 ` Greg KH [this message]
2009-01-26 12:19 ` Kay Sievers
2009-01-26 17:40 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2009-07-14 6:33 Stephen Rothwell
2009-07-14 7:31 ` David Brownell
2009-07-16 22:50 ` Greg KH
2009-06-23 6:01 Stephen Rothwell
2009-06-23 15:29 ` Greg KH
2009-06-23 16:28 ` Greg KH
2009-05-12 3:44 Stephen Rothwell
2009-05-12 4:05 ` Greg KH
2009-05-13 0:13 ` Greg KH
2009-05-13 1:39 ` Stephen Rothwell
2009-05-04 6:25 Stephen Rothwell
2009-05-04 13:00 ` Kay Sievers
2009-05-05 4:18 ` Stephen Rothwell
2009-05-05 4:29 ` Greg KH
2009-05-09 11:16 ` Stephen Rothwell
2009-05-09 13:51 ` Greg KH
2009-03-26 7:34 Stephen Rothwell
2009-03-26 23:00 ` Jesse Barnes
2009-03-16 9:47 Stephen Rothwell
2009-03-22 12:22 ` Stephen Rothwell
2009-03-23 4:23 ` David Miller
2009-03-10 8:24 Stephen Rothwell
2009-03-10 13:31 ` Geert Uytterhoeven
2009-03-10 13:38 ` Herbert Xu
2009-03-10 13:53 ` Martin Schwidefsky
2009-03-10 15:29 ` Geert Uytterhoeven
2009-03-10 16:08 ` Martin Schwidefsky
2009-03-10 20:02 ` Jason Baron
2009-03-11 3:30 ` Greg KH
2009-03-11 8:33 ` Geert Uytterhoeven
2009-03-11 10:07 ` Greg Banks
2009-03-11 10:50 ` Geert Uytterhoeven
2009-03-11 15:12 ` Jason Baron
2008-12-22 12:59 Stephen Rothwell
2008-12-22 14:50 ` Mark McLoughlin
2008-12-23 4:29 ` Greg KH
2008-12-29 6:34 ` Stephen Rothwell
2008-12-30 15:28 ` Stephen Rothwell
2009-01-02 7:26 ` Greg KH
2009-01-03 4:32 ` Stephen Rothwell
2008-12-11 0:21 Stephen Rothwell
2008-12-11 4:55 ` Greg KH
2008-11-19 0:30 Stephen Rothwell
2008-11-19 0:40 ` Kay Sievers
2008-11-19 2:22 ` Stephen Rothwell
2008-11-19 2:24 ` Stephen Rothwell
2008-11-19 6:36 ` Greg KH
2008-11-19 5:43 ` Stephen Rothwell
2008-11-19 6:26 ` Greg KH
2008-11-19 6:51 ` Stephen Rothwell
2008-11-19 6:55 ` Greg KH
2008-09-12 3:53 Stephen Rothwell
2008-09-15 18:58 ` Greg KH
2008-08-15 8:25 Stephen Rothwell
2008-08-16 5:31 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090126011007.GA24070@kroah.com \
--to=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).