linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build failure
@ 2009-02-02  9:02 Stephen Rothwell
  2009-02-02 19:43 ` Yinghai Lu
  2009-02-03  6:14 ` David Miller
  0 siblings, 2 replies; 96+ messages in thread
From: Stephen Rothwell @ 2009-02-02  9:02 UTC (permalink / raw)
  To: David S. Miller, Ingo Molnar; +Cc: linux-next, Yinghai Lu

Hi Dave, Ingo,

Today's linux-next build (sparc64 defconfig) failed like this:

arch/sparc/kernel/nmi.c: In function 'perfctr_irq':
arch/sparc/kernel/nmi.c:97: error: 'struct kernel_stat' has no member named 'irqs'

Probably caused by commit e5553a6d04421eec326a629571d696e8e745a0e4
("sparc64: Implement NMI watchdog on capable cpus") from the
sparc-current tree interacting with commit
d7e51e66899f95dabc89b4d4c6674a6e50fa37fc ("sparseirq: make some func to
be used with genirq") from the sparseirq tree.

I have temporarily applied the patch below.  I don't know if it is
correct (but it fixes the build).  If it is, it should be applicable to
the sparc-current tree as the needed interface exists in Linus' current
tree.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 2 Feb 2009 20:00:15 +1100
Subject: [PATCH] sparc: fixup for sparseirq changes

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/sparc/kernel/nmi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/sparc/kernel/nmi.c b/arch/sparc/kernel/nmi.c
index ffc6900..09f088e 100644
--- a/arch/sparc/kernel/nmi.c
+++ b/arch/sparc/kernel/nmi.c
@@ -94,7 +94,7 @@ notrace __kprobes void perfctr_irq(int irq, struct pt_regs *regs)
 		       pt_regs_trap_type(regs), SIGINT) == NOTIFY_STOP)
 		touched = 1;
 
-	sum = kstat_cpu(cpu).irqs[0];
+	sum = kstat_irqs_cpu(0, cpu);
 	if (__get_cpu_var(nmi_touch)) {
 		__get_cpu_var(nmi_touch) = 0;
 		touched = 1;
-- 
1.6.0.5

^ permalink raw reply related	[flat|nested] 96+ messages in thread
* linux-next build failure
@ 2014-05-12 13:18 Mark Salter
  2014-05-12 15:47 ` Mark Salter
  2014-05-12 17:05 ` Al Viro
  0 siblings, 2 replies; 96+ messages in thread
From: Mark Salter @ 2014-05-12 13:18 UTC (permalink / raw)
  To: Alexander Viro; +Cc: linux-next

I'm seeing a build failure in linux-net for c6x (!CONFIG_MMU):

  fs/binfmt_elf_fdpic.c: In function ‘elf_fdpic_dump_segments’:
  fs/binfmt_elf_fdpic.c:1490:17: warning: unused variable ‘addr’ [-Wunused-variable]
     unsigned long addr;
                 ^
This was introduced by this patch:

  Author: Al Viro <viro@zeniv.linux.org.uk>
  Date:   Sat Oct 5 18:58:47 2013 -0400

      convert the rest of binfmt_elf_fdpic to dump_emit()

^ permalink raw reply	[flat|nested] 96+ messages in thread
* linux-next build failure
@ 2014-01-03 15:58 Mark Salter
  2014-01-03 22:56 ` Andrew Morton
  0 siblings, 1 reply; 96+ messages in thread
From: Mark Salter @ 2014-01-03 15:58 UTC (permalink / raw)
  To: linux-next; +Cc: Andrew Morton, jmarchan

The c6x arch (no MMU) is failing to build in linux-next with:

  kernel/built-in.o:(.fardata+0x3fc): undefined reference to `overcommit_ratio_handler'
  kernel/built-in.o:(.fardata+0x420): undefined reference to `overcommit_kbytes_handler'
  make[1]: *** [vmlinux] Error 1

Looks like this patch adds those functions to mm/mmap.c which
is only used when CONFIG_MMU is defined.

  commit 31bdaf7c8e8a784fd8f889371bdacb24670734c7
  Author: Jerome Marchand <jmarchan@redhat.com>
  Date:   Tue Dec 17 10:45:06 2013 +1100

      mm: add overcommit_kbytes sysctl variable
    

^ permalink raw reply	[flat|nested] 96+ messages in thread
* linux-next build failure
@ 2013-11-08 16:51 Mark Salter
  0 siblings, 0 replies; 96+ messages in thread
From: Mark Salter @ 2013-11-08 16:51 UTC (permalink / raw)
  To: linux-next; +Cc: linux-kernel, Andrew Morton

I'm seeing a build failure for a no-MMU system:

   mm/built-in.o: In function `__vm_enough_memory':
  (.text+0x1ce70): undefined reference to `vm_commit_limit'
  fs/built-in.o: In function `meminfo_proc_show':
  meminfo.c:(.text+0x6852c): undefined reference to `vm_commit_limit'


This patch added vm_commit_limit() to mm/mmap.c, but no-mmu systems
use mm/nommu.c instead.

commit 50e05119f980037b474043434cb713bf6f859734
Author: Andrew Morton <akpm@linux-foundation.org>
Date:   Thu Nov 7 12:01:09 2013 +1100

    mm-factor-commit-limit-calculation-fix
    
    uninline vm_commit_limit()

^ permalink raw reply	[flat|nested] 96+ messages in thread
* linux-next build failure
@ 2013-10-30 15:27 Mark Salter
  2013-10-30 20:37 ` Stephen Rothwell
  0 siblings, 1 reply; 96+ messages in thread
From: Mark Salter @ 2013-10-30 15:27 UTC (permalink / raw)
  To: linux-next; +Cc: linux-kernel, ccross

This patch causes a build failure for no-MMU builds:

  commit 41df2957cb010edfa2f9d394d3617da6beeeb660
  Author: Colin Cross <ccross@android.com>
  Date:   Wed Oct 30 11:45:39 2013 +1100

      mm: add a field to store names for private anonymous memory
    
The problem is:

  kernel/built-in.o: In function `sys_prctl':
  (.text+0x19854): undefined reference to `madvise_set_anon_name'

madvise doesn't make sense without an MMU.

--Mark

^ permalink raw reply	[flat|nested] 96+ messages in thread
[parent not found: <CAHfT02u5as-YvAvwznMveNY_FbeDWLbj0NL6O78MRfeLQ5mpsA@mail.gmail.com>]
* linux-next: build failure
@ 2009-04-08  4:04 Stephen Rothwell
  2009-04-08  5:12 ` Alan Modra
  0 siblings, 1 reply; 96+ messages in thread
From: Stephen Rothwell @ 2009-04-08  4:04 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Paul Mackerras; +Cc: linux-next, linuxppc-dev, amodra

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

Hi all,

Today's linux-next build (powerpc allyesconfig) failed like this:

  LD      vmlinux.o
powerpc-linux-ld: TOC section size exceeds 64k

I will think about (and appreciate suggestions on) how to fix this ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2009-01-08  5:20 Stephen Rothwell
  2009-01-08  5:42 ` David Miller
  0 siblings, 1 reply; 96+ messages in thread
From: Stephen Rothwell @ 2009-01-08  5:20 UTC (permalink / raw)
  To: David S. Miller; +Cc: linux-next

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

Hi Dave,

Today's linux-next build (sparc64 defconfig) failed like this:

drivers/base/topology.c: In function 'show_physical_package_id':
drivers/base/topology.c:103: error: implicit declaration of function 'cpu_data'
drivers/base/topology.c:103: error: request for member 'proc_id' in something not a structure or union
drivers/base/topology.c: In function 'show_core_id':
drivers/base/topology.c:106: error: request for member 'core_id' in something not a structure or union

I cherry-picked the fix out of Linus' tree.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-12-09  7:34 Stephen Rothwell
  2008-12-09 21:05 ` Jesse Barnes
  0 siblings, 1 reply; 96+ messages in thread
From: Stephen Rothwell @ 2008-12-09  7:34 UTC (permalink / raw)
  To: Dave Airlie; +Cc: linux-next, Jesse Barnes, Eric Anholt

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

Hi Dave,

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/gpu/drm/drm_gem.c: In function 'drm_gem_mmap':
drivers/gpu/drm/drm_gem.c:519: error: '_PAGE_CACHE_WC' undeclared (first use in this function)

Caused by commit 33b801854540a4f5205c0b2b4b91987e7f21af08 ("drm: GEM mmap
support").  I tried to revert just that commit, but it lead me down a
road of dependent commits, so I have reverted the whole drm tree for
today.

_PAGE_CACHE_WC appears to be defined only for x86 and, before the above
commit, was not used outside arch/x86.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-11-11  8:10 Stephen Rothwell
  2008-11-11  8:15 ` Sujith
  2008-11-11  9:18 ` David Miller
  0 siblings, 2 replies; 96+ messages in thread
From: Stephen Rothwell @ 2008-11-11  8:10 UTC (permalink / raw)
  To: John W. Linville; +Cc: linux-next, Sujith, David S. Miller

Hi John, Dave,

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/net/wireless/ath9k/main.c: At top level:
drivers/net/wireless/ath9k/main.c:827: warning: conflicting types for 'ath_detach'
drivers/net/wireless/ath9k/main.c:827: error: static declaration of 'ath_detach' follows non-static declaration
drivers/net/wireless/ath9k/main.c:812: error: previous implicit declaration of 'ath_detach' was here

Caused by commit 9c84b7978f1b99048bf31be5a0218cd509e74148 ("ath9k:
Streamline attach/detach") (from the wireless/net tree) which added a
call to the static function before it was defined.

I added the patch below, which then lead to:

drivers/net/wireless/ath9k/main.c: In function 'ath_start_rfkill_poll':
drivers/net/wireless/ath9k/main.c:818: error: 'hw' undeclared (first use in this function)

So I gave up and reverted the wireless tree for today (I actually
reverted the merge of the wireless tree into the net tree).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

diff --git a/drivers/net/wireless/ath9k/main.c b/drivers/net/wireless/ath9k/main.c
index fb50aa0..dc66fb7 100644
--- a/drivers/net/wireless/ath9k/main.c
+++ b/drivers/net/wireless/ath9k/main.c
@@ -28,6 +28,8 @@ MODULE_DESCRIPTION("Support for Atheros 802.11n wireless LAN cards.");
 MODULE_SUPPORTED_DEVICE("Atheros 802.11n WLAN cards");
 MODULE_LICENSE("Dual BSD/GPL");
 
+static void ath_detach(struct ath_softc *sc);
+
 static struct pci_device_id ath_pci_id_table[] __devinitdata = {
 	{ PCI_VDEVICE(ATHEROS, 0x0023) }, /* PCI   */
 	{ PCI_VDEVICE(ATHEROS, 0x0024) }, /* PCI-E */
-- 
1.5.6.5

^ permalink raw reply related	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-11-07  9:25 Stephen Rothwell
  2008-11-07 16:40 ` Hollis Blanchard
  0 siblings, 1 reply; 96+ messages in thread
From: Stephen Rothwell @ 2008-11-07  9:25 UTC (permalink / raw)
  To: Avi Kivity; +Cc: linux-next, Hollis Blanchard

[-- Attachment #1: Type: text/plain, Size: 4117 bytes --]

Hi Avi,

Today's linux-next build (powerpc ppc44x_config) failed like this:

arch/powerpc/kvm/built-in.o: In function `kvm_vcpu_ioctl':
kvm_main.c:(.text+0x890): undefined reference to `kvm_arch_vcpu_ioctl_get_sregs'
kvm_main.c:(.text+0xa84): undefined reference to `kvm_arch_vcpu_ioctl_set_fpu'
kvm_main.c:(.text+0xadc): undefined reference to `kvm_arch_vcpu_ioctl_get_regs'
kvm_main.c:(.text+0xb58): undefined reference to `kvm_arch_vcpu_ioctl_get_fpu'
kvm_main.c:(.text+0xc48): undefined reference to `kvm_arch_vcpu_ioctl_translate'
kvm_main.c:(.text+0xd7c): undefined reference to `kvm_arch_vcpu_ioctl_set_regs'
kvm_main.c:(.text+0xdbc): undefined reference to `kvm_arch_vcpu_ioctl_set_sregs'
arch/powerpc/kvm/built-in.o: In function `kvm_exit':
(.text+0x117e): undefined reference to `debugfs_entries'
arch/powerpc/kvm/built-in.o: In function `kvm_exit':
(.text+0x1182): undefined reference to `debugfs_entries'
arch/powerpc/kvm/built-in.o: In function `kvm_exit':
(.text+0x1186): undefined reference to `debugfs_entries'
arch/powerpc/kvm/built-in.o: In function `kvm_init':
(.text+0x13ce): undefined reference to `debugfs_entries'
arch/powerpc/kvm/built-in.o: In function `kvm_init':
(.text+0x13da): undefined reference to `debugfs_entries'
arch/powerpc/kvm/built-in.o:(.text+0x13de): more undefined references to `debugfs_entries' follow
arch/powerpc/kvm/built-in.o: In function `kvm_vm_ioctl':
kvm_main.c:(.text+0x2d20): undefined reference to `kvm_arch_vcpu_setup'
arch/powerpc/kvm/built-in.o: In function `kvm_vcpu_ioctl_interrupt':
(.text+0x38b4): undefined reference to `kvmppc_core_queue_external'
arch/powerpc/kvm/built-in.o: In function `kvm_arch_vcpu_ioctl_run':
(.text+0x3a0c): undefined reference to `kvmppc_core_deliver_interrupts'
arch/powerpc/kvm/built-in.o: In function `kvm_arch_vcpu_ioctl_run':
(.text+0x3a28): undefined reference to `__kvmppc_vcpu_run'
arch/powerpc/kvm/built-in.o: In function `kvm_arch_vcpu_put':
(.text+0x3de0): undefined reference to `kvmppc_core_load_host_debugstate'
arch/powerpc/kvm/built-in.o: In function `kvm_arch_vcpu_put':
(.text+0x3de8): undefined reference to `kvmppc_core_vcpu_put'
arch/powerpc/kvm/built-in.o: In function `kvm_arch_vcpu_load':
(.text+0x3e24): undefined reference to `kvmppc_core_load_guest_debugstate'
arch/powerpc/kvm/built-in.o: In function `kvm_arch_vcpu_load':
(.text+0x3e30): undefined reference to `kvmppc_core_vcpu_load'
arch/powerpc/kvm/built-in.o: In function `kvmppc_decrementer_func':
powerpc.c:(.text+0x3ea4): undefined reference to `kvmppc_core_queue_dec'
arch/powerpc/kvm/built-in.o: In function `kvm_cpu_has_pending_timer':
(.text+0x3efc): undefined reference to `kvmppc_core_pending_dec'
arch/powerpc/kvm/built-in.o: In function `kvm_arch_vcpu_free':
(.text+0x3f1c): undefined reference to `kvmppc_core_vcpu_free'
arch/powerpc/kvm/built-in.o: In function `kvm_arch_vcpu_destroy':
(.text+0x3f3c): undefined reference to `kvmppc_core_vcpu_free'
arch/powerpc/kvm/built-in.o: In function `kvm_arch_vcpu_create':
(.text+0x3f5c): undefined reference to `kvmppc_core_vcpu_create'
arch/powerpc/kvm/built-in.o: In function `kvm_arch_destroy_vm':
(.text+0x3f90): undefined reference to `kvmppc_core_vcpu_free'
arch/powerpc/kvm/built-in.o: In function `kvm_arch_check_processor_compat':
(.text+0x4034): undefined reference to `kvmppc_core_check_processor_compat'
arch/powerpc/kvm/built-in.o: In function `kvmppc_emulate_instruction':
(.text+0x41b4): undefined reference to `kvmppc_core_emulate_op'
arch/powerpc/kvm/built-in.o: In function `kvmppc_emulate_instruction':
(.text+0x4380): undefined reference to `kvmppc_core_queue_program'
arch/powerpc/kvm/built-in.o: In function `kvmppc_emulate_instruction':
(.text+0x45ac): undefined reference to `kvmppc_core_emulate_mtspr'
arch/powerpc/kvm/built-in.o: In function `kvmppc_emulate_instruction':
(.text+0x468c): undefined reference to `kvmppc_core_emulate_mfspr'

I have reverted the merge of the kvm tree for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-10-23  9:51 Stephen Rothwell
  0 siblings, 0 replies; 96+ messages in thread
From: Stephen Rothwell @ 2008-10-23  9:51 UTC (permalink / raw)
  To: Rusty Russell; +Cc: linux-next, Mike Travis

Hi Rusty,

Today's linux-next build (sparc defconfig) failed like this:

In file included from arch/sparc/include/asm/smp_32.h:15,
                 from arch/sparc/include/asm/smp.h:6,
                 from arch/sparc/include/asm/system_32.h:12,
                 from arch/sparc/include/asm/system.h:6,
                 from include/linux/list.h:7,
                 from include/linux/preempt.h:11,
                 from include/linux/spinlock.h:50,
                 from include/linux/seqlock.h:29,
                 from include/linux/time.h:8,
                 from include/linux/timex.h:57,
                 from include/linux/sched.h:54,
                 from arch/sparc/kernel/asm-offsets.c:13:
include/linux/cpumask.h:110: error: `CONFIG_NR_CPUS' undeclared here (not in a function)

and it went on ...

I applied the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 23 Oct 2008 20:48:36 +1100
Subject: [PATCH] sparc: fallout from cpumask CONFIG_NR_CPUS changes

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/sparc/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index 6b4970e..7b1a000 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -66,7 +66,7 @@ config SMP
 config NR_CPUS
 	int "Maximum number of CPUs (2-32)" if SMP
 	range 2 32 if SMP
-	default "1" if SMP
+	default "1" if !SMP
 	default "32" if SMP
 
 config SPARC
-- 
1.5.6.5

^ permalink raw reply related	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-10-23  9:18 Stephen Rothwell
  0 siblings, 0 replies; 96+ messages in thread
From: Stephen Rothwell @ 2008-10-23  9:18 UTC (permalink / raw)
  To: Rusty Russell; +Cc: linux-next, Mike Travis

Hi Rusty,

Today's linux-next build (powerpc allnoconfig) failed like this:

In file included from include/linux/sched.h:58,
                 from arch/powerpc/kernel/asm-offsets.c:17:
include/linux/cpumask.h:110: error: 'CONFIG_NR_CPUS' undeclared here (not in a function)

Caused by commit d08dde18aebb15633e5c4480814b77d93a4d68f6 ("cpumask:CONFIG_NR_CPUS-always") from the rr tree.  I applied the following patch.

There are several other architectures that don't appear to have been
updated for this change - how confident ae you that none of them have
been broken as powerpc was?
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 23 Oct 2008 20:14:18 +1100
Subject: [PATCH] powerpc: fallout from cpumask CONFIG_NR_CPUS changes

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/powerpc/platforms/Kconfig.cputype |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
index 548efa5..e8fd928 100644
--- a/arch/powerpc/platforms/Kconfig.cputype
+++ b/arch/powerpc/platforms/Kconfig.cputype
@@ -242,9 +242,9 @@ config SMP
 	  If you don't know what to do here, say N.
 
 config NR_CPUS
-	int "Maximum number of CPUs (2-1024)"
-	range 2 1024
-	depends on SMP
+	int "Maximum number of CPUs (2-1024)" if SMP
+	range 2 1024 if SMP
+	default "1" if !SMP
 	default "32" if PPC64
 	default "4"
 
-- 
1.5.6.5

^ permalink raw reply related	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-10-20 12:04 Stephen Rothwell
  2008-10-20 15:48 ` Greg KH
  0 siblings, 1 reply; 96+ messages in thread
From: Stephen Rothwell @ 2008-10-20 12:04 UTC (permalink / raw)
  To: Greg KH
  Cc: linux-next, Christopher Harrer, Michael Miles, LKML,
	Andrew Morton, linus

Hi Greg,

Today's linux-next build (powerpc allyesconfig) failed like this:

In file included from drivers/staging/sxg/sxg.c:77:
drivers/staging/sxg/sxghif.h:859: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'Compilation'
drivers/staging/sxg/sxg.c: In function 'sxg_transmit_packet':
drivers/staging/sxg/sxg.c:1949: error: 'SXG_SGL_BUF_SIZE' undeclared (first use in this function)
drivers/staging/sxg/sxg.c:1958: error: implicit declaration of function 'SXG_SGL_BUFFER'
drivers/staging/sxg/sxg.c:1958: warning: assignment makes pointer from integer without a cast
drivers/staging/sxg/sxg.c: In function 'sxg_mcast_set_mask':
drivers/staging/sxg/sxg.c:2846: warning: format '%llx' expects type 'long long unsigned int', but argument 5 has type 'u64'

I applied the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 20 Oct 2008 22:59:18 +1100
Subject: [PATCH] staging: sxg depends on X86

sxghif.h has code that explicitly will not build fo other architecures.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/staging/sxg/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/sxg/Kconfig b/drivers/staging/sxg/Kconfig
index 1ae3508..6e6cf0b 100644
--- a/drivers/staging/sxg/Kconfig
+++ b/drivers/staging/sxg/Kconfig
@@ -1,6 +1,7 @@
 config SXG
 	tristate "Alacritech SLIC Technology Non-Accelerated 10Gbe support"
 	depends on PCI && NETDEV_10000
+	depends on X86
 	default n
 	help
 	  This driver supports the Alacritech SLIC Technology Non-Accelerated
-- 
1.5.6.5

^ permalink raw reply related	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-10-17  8:21 Stephen Rothwell
  2008-10-17 17:37 ` Greg KH
  0 siblings, 1 reply; 96+ messages in thread
From: Stephen Rothwell @ 2008-10-17  8:21 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, Ming Lei

Hi Greg,

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/usb/host/ehci-dbg.c: In function 'fill_buffer':
drivers/usb/host/ehci-dbg.c:839: error: implicit declaration of function 'vmalloc'
drivers/usb/host/ehci-dbg.c:839: warning: cast to pointer from integer of different size
drivers/usb/host/ehci-dbg.c: In function 'debug_close':
drivers/usb/host/ehci-dbg.c:887: error: implicit declaration of function 'vfree'

Caused by commit b28e0eaa4a48bdc742978d6dd3688ef1db71928c ("USB:
ehci-dbg: increase debug buffer size for periodic file") from the usb
tree.

I added the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 17 Oct 2008 19:19:03 +1100
Subject: [PATCH] usb: vmalloc needs include of vmalloc.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/usb/host/ehci-dbg.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index 0cb53ca..7119036 100644
--- a/drivers/usb/host/ehci-dbg.c
+++ b/drivers/usb/host/ehci-dbg.c
@@ -18,6 +18,8 @@
 
 /* this file is part of ehci-hcd.c */
 
+#include <linux/vmalloc.h>
+
 #define ehci_dbg(ehci, fmt, args...) \
 	dev_dbg (ehci_to_hcd(ehci)->self.controller , fmt , ## args )
 #define ehci_err(ehci, fmt, args...) \
-- 
1.5.6.5

^ permalink raw reply related	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-10-17  7:59 Stephen Rothwell
  0 siblings, 0 replies; 96+ messages in thread
From: Stephen Rothwell @ 2008-10-17  7:59 UTC (permalink / raw)
  To: David S. Miller; +Cc: linux-next

[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]

Hi ,

Today's linux-next build (sparc defconfig) failed like this:

.tmp_kallsyms2.o(.rodata+0x0): In function `kallsyms_addresses':
: relocation truncated to fit: R_SPARC_32 _text
.tmp_kallsyms2.o(.rodata+0x4): In function `kallsyms_addresses':
: relocation truncated to fit: R_SPARC_32 _text
.tmp_kallsyms2.o(.rodata+0x8): In function `kallsyms_addresses':
: relocation truncated to fit: R_SPARC_32 _text
.tmp_kallsyms2.o(.rodata+0xc): In function `kallsyms_addresses':
: relocation truncated to fit: R_SPARC_32 _text
.tmp_kallsyms2.o(.rodata+0x10): In function `kallsyms_addresses':
: relocation truncated to fit: R_SPARC_32 _text
.tmp_kallsyms2.o(.rodata+0x14): In function `kallsyms_addresses':
: relocation truncated to fit: R_SPARC_32 _text
.tmp_kallsyms2.o(.rodata+0x18): In function `kallsyms_addresses':
: relocation truncated to fit: R_SPARC_32 _text
.tmp_kallsyms2.o(.rodata+0x1c): In function `kallsyms_addresses':
: relocation truncated to fit: R_SPARC_32 _text
.tmp_kallsyms2.o(.rodata+0x20): In function `kallsyms_addresses':
: relocation truncated to fit: R_SPARC_32 _text
.tmp_kallsyms2.o(.rodata+0x24): In function `kallsyms_addresses':
: relocation truncated to fit: R_SPARC_32 _text
.tmp_kallsyms2.o(.rodata+0x28): In function `kallsyms_addresses':
: additional relocation overflows omitted from the output

I have no idea what to do about this.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 96+ messages in thread
* linux-next:  build failure
@ 2008-10-16  9:29 Stephen Rothwell
  2008-10-16 10:39 ` Ingo Molnar
  0 siblings, 1 reply; 96+ messages in thread
From: Stephen Rothwell @ 2008-10-16  9:29 UTC (permalink / raw)
  To: Jeremy Fitzhardinge; +Cc: linux-next, ppc-dev, Ingo Molnar, Andrew Morton

Hi all,

Today's linux-next build (powerpc allyesconfig) failed like this:

In file included from arch/powerpc/include/asm/mmu-hash64.h:17,
                 from arch/powerpc/include/asm/mmu.h:8,
                 from arch/powerpc/include/asm/pgtable.h:8,
                 from arch/powerpc/mm/slb.c:20:
arch/powerpc/include/asm/page.h:76: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'memstart_addr'
arch/powerpc/include/asm/page.h:77: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'kernstart_addr'

Caused by commit 600715dcdf567c86f8b2c6173fcfb4b873e25a19 ("generic: add
phys_addr_t for holding physical addresses") from the tip-core tree.
This only fails if CONFIG_RELOCATABLE is set.

I have applied the patch below.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

>From 3e3a6a5f9479a4d35070c15f863a8635e9865058 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 16 Oct 2008 20:07:00 +1100
Subject: [PATCH] tip-core/powerpc: phys_addr_t has moved to linux/types.h

So include that instead of asm/types.h in asm/page.h for
the CONFIG_RELOCATABLE case.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/powerpc/include/asm/page.h |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include/asm/page.h
index 64e1445..5ac51e6 100644
--- a/arch/powerpc/include/asm/page.h
+++ b/arch/powerpc/include/asm/page.h
@@ -10,9 +10,13 @@
  * 2 of the License, or (at your option) any later version.
  */
 
+#ifndef __ASSEMBLY__
+#include <linux/types.h>
+#else
+#include <asm/types.h>
+#endif
 #include <asm/asm-compat.h>
 #include <asm/kdump.h>
-#include <asm/types.h>
 
 /*
  * On PPC32 page size is 4K. For PPC64 we support either 4K or 64K software
-- 
1.5.6.5

^ permalink raw reply related	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-10-16  9:28 Stephen Rothwell
  2008-10-16 14:00 ` Eric Van Hensbergen
  0 siblings, 1 reply; 96+ messages in thread
From: Stephen Rothwell @ 2008-10-16  9:28 UTC (permalink / raw)
  To: Eric Van Hensbergen; +Cc: linux-next

Hi Eric,

Today's linux-next build (powerpc allyesconfig) failed like this:

net/9p/client.c: At top level:
net/9p/client.c:698: error: __ksymtab_p9_client_version causes a section type conflict

Caused by commit f0cad54013b07371dcefd8fa36ff1d3918b49695 ("9p: rework
client code to use new protocol support functions") from the v9fs tree
which exported a static function.  I have applied the following patch.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 16 Oct 2008 20:27:24 +1100
Subject: [PATCH] v9fs: don't export static functions

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/9p/client.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/9p/client.c b/net/9p/client.c
index 4cd9e70..7621fe8 100644
--- a/net/9p/client.c
+++ b/net/9p/client.c
@@ -655,7 +655,7 @@ static void p9_fid_destroy(struct p9_fid *fid)
 	kfree(fid);
 }
 
-static int p9_client_version(struct p9_client *c)
+int p9_client_version(struct p9_client *c)
 {
 	int err = 0;
 	struct p9_req_t *req;
-- 
1.5.6.5

^ permalink raw reply related	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-09-03  8:45 Stephen Rothwell
  2008-09-03 10:19 ` David Woodhouse
  0 siblings, 1 reply; 96+ messages in thread
From: Stephen Rothwell @ 2008-09-03  8:45 UTC (permalink / raw)
  To: David Woodhouse; +Cc: linux-next

Hi David,

Today's linux-next build (powerpc allnoconfig) failed like this:

In file included from arch/powerpc/include/asm/statfs.h:5,
                 from include/linux/statfs.h:7,
                 from include/linux/vfs.h:5,
                 from fs/open.c:23:
include/asm-generic/statfs.h:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__u32'
include/asm-generic/statfs.h:36: error: two or more data types in declaration specifiers
include/asm-generic/statfs.h:36: warning: useless type name in empty declaration
include/asm-generic/statfs.h:47: error: expected specifier-qualifier-list before '__statfs_word'

and it went downhill from there.

Introduced by commit 97bea16fbd30f35637447cf0884ac0e1fe467a37 ("Make
<asm-generic/statfs.h> suitable for 64-bit platforms") from the dwmw2
tree.  I applied the following patch.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 3 Sep 2008 18:37:34 +1000
Subject: [PATCH] statfs: fix typo

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/asm-generic/statfs.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/asm-generic/statfs.h b/include/asm-generic/statfs.h
index 68b6d69..6129d68 100644
--- a/include/asm-generic/statfs.h
+++ b/include/asm-generic/statfs.h
@@ -17,7 +17,7 @@ typedef __kernel_fsid_t	fsid_t;
 #if BITS_PER_LONG == 64
 #define __statfs_word long
 #else
-typedef __statfs_word __u32
+#define __statfs_word __u32
 #endif
 #endif
 
-- 
1.5.6.5

^ permalink raw reply related	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-08-27  0:06 Stephen Rothwell
  2008-08-27  2:55 ` Rusty Russell
  0 siblings, 1 reply; 96+ messages in thread
From: Stephen Rothwell @ 2008-08-27  0:06 UTC (permalink / raw)
  To: Johannes Berg; +Cc: linux-next, Rusty Russell, netdev

[-- Attachment #1: Type: text/plain, Size: 669 bytes --]

Hi all,

next-20080826 build (powerpc mpc885_ads_defconfig) failed like this:

net/core/dev.c:1000: error: redefinition of 'dev_load'
include/linux/netdevice.h:1645: error: previous definition of 'dev_load' was here

This also failed for several other builds where CONFIG_MODULES is off.

Introduced by commit 4cb9da6ecc2b0e25056b45981239475f8509d59d ("remove
CONFIG_KMOD from net") which added a !CONFIG_MODULES (static inline)
version of dev_load() to include/linux/netdevice.h but the copy in
net/core/dev.c is not protected by CONFIG_MODULES.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 96+ messages in thread
* linux-next:  build failure
@ 2008-08-25 11:28 Stephen Rothwell
  2008-08-25 12:40 ` Ingo Molnar
  2008-08-28  7:40 ` David Miller
  0 siblings, 2 replies; 96+ messages in thread
From: Stephen Rothwell @ 2008-08-25 11:28 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: linux-next, David Miller, LKML

Hi Ingo,

Today's linux-next build (sparc64 defconfig) failed like this:

ERROR: "__BUILD_BUG_ON_non_constant" [drivers/net/sunvnet.ko] undefined!
ERROR: "__BUILD_BUG_ON_non_constant" [drivers/block/sunvdc.ko] undefined!

Probably intorduced by commit f5b5d41dd51a31fe70e3a04fb80a3b90b84c6a4e
("debug: fix BUILD_BUG_ON() for non-constant expressions").

The preprocessed code looks like this:

static inline __attribute__((always_inline)) u32 vio_dring_avail(struct vio_dring_state *dr,
      unsigned int ring_size)
{
 do { (void)sizeof(char[1 - 2*!!(!is_power_of_2(ring_size))]); if (!__builtin_constant_p(!is_power_of_2(ring_size))) __BUILD_BUG_ON_non_constant++; } while (0);

 return (dr->pending -
  ((dr->prod - dr->cons) & (ring_size - 1)));
}

I tried turning the above inline function into a macro to no avail.

I applied the following patch (which is probably not what is wanted, but
puts back what was there before).

I see from LKML that this definition of BUILD_BUG_ON is to be replaced,
so this is just a temporary measure.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 25 Aug 2008 21:16:14 +1000
Subject: [PATCH] revert BUILD_BUG_ON change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/compiler.h |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/include/linux/compiler.h b/include/linux/compiler.h
index d7d313b..a1c082d 100644
--- a/include/linux/compiler.h
+++ b/include/linux/compiler.h
@@ -206,15 +206,9 @@ extern void __chk_io_ptr(const volatile void __iomem *);
  * ( The linker trick relies on gcc optimizing out a multiplication with
  *   constant zero - which should be reasonable enough. )
  */
-#ifndef __ASSEMBLY__
-extern unsigned int __BUILD_BUG_ON_non_constant;
-#endif
-
 #define BUILD_BUG_ON(condition)					\
 do {								\
 	(void)sizeof(char[1 - 2*!!(condition)]);		\
-	if (!__builtin_constant_p(condition))			\
-		__BUILD_BUG_ON_non_constant++;			\
 } while (0)
 
 /*
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-07-30  5:30 Stephen Rothwell
  2008-07-30  5:54 ` Ananth N Mavinakayanahalli
  2008-07-30  6:41 ` Adrian Bunk
  0 siblings, 2 replies; 96+ messages in thread
From: Stephen Rothwell @ 2008-07-30  5:30 UTC (permalink / raw)
  To: Ananth N Mavinakayanahalli
  Cc: linux-next, Ankita Garg, Vivek Goyal, Haren Myneni, kexec

Hi Ananth,

Today's linux-next build (powerpc allyesconfig) failed like this:

tests/lkdtm.c:182: error: expected ')' before '*' token

I have no idea why this fails now when it did not before.

I applied the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 30 Jul 2008 15:24:53 +1000
Subject: [PATCH] tests: lkdtm needs ide.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 tests/lkdtm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/tests/lkdtm.c b/tests/lkdtm.c
index 2a40d18..856f060 100644
--- a/tests/lkdtm.c
+++ b/tests/lkdtm.c
@@ -52,6 +52,7 @@
 #include <linux/init.h>
 #include <linux/interrupt.h>
 #include <linux/hrtimer.h>
+#include <linux/ide.h>
 #include <scsi/scsi_cmnd.h>
 
 #define NUM_CPOINTS 8
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-07-29  6:23 Stephen Rothwell
  2008-07-29  8:00 ` Ingo Molnar
  0 siblings, 1 reply; 96+ messages in thread
From: Stephen Rothwell @ 2008-07-29  6:23 UTC (permalink / raw)
  To: David Miller
  Cc: linux-next, LKML, Andrew Morton, Linus, Mike Travis, Ingo Molnar

Hi Dave,

Today's linux-next build (sparc64 defconfig) failed like this:

kernel/time/tick-common.c: In function `tick_check_new_device':
kernel/time/tick-common.c:210: error: invalid lvalue in unary `&'
kernel/time/tick-common.c:223: error: invalid lvalue in unary `&'
kernel/time/tick-common.c:255: error: invalid lvalue in unary `&'

gcc is version 3.4.5 sparc64 cross compiler (powercp64 host).

The below patch fixes it.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 29 Jul 2008 16:07:37 +1000
Subject: [PATCH] cpumask: statement expressions confuse some versions of gcc

when you take the address of the result.  Noticed on a sparc64 compile
using a version 3.4.5 cross compiler.

kernel/time/tick-common.c: In function `tick_check_new_device':
kernel/time/tick-common.c:210: error: invalid lvalue in unary `&'
kernel/time/tick-common.c:223: error: invalid lvalue in unary `&'
kernel/time/tick-common.c:255: error: invalid lvalue in unary `&'

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/cpumask.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h
index 96d0509..d3219d7 100644
--- a/include/linux/cpumask.h
+++ b/include/linux/cpumask.h
@@ -287,7 +287,7 @@ static inline const cpumask_t *get_cpu_mask(unsigned int cpu)
  * gcc optimizes it out (it's a constant) and there's no huge stack
  * variable created:
  */
-#define cpumask_of_cpu(cpu) ({ *get_cpu_mask(cpu); })
+#define cpumask_of_cpu(cpu) (*get_cpu_mask(cpu))
 
 
 #define CPU_MASK_LAST_WORD BITMAP_LAST_WORD_MASK(NR_CPUS)
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-07-28  5:07 Stephen Rothwell
  0 siblings, 0 replies; 96+ messages in thread
From: Stephen Rothwell @ 2008-07-28  5:07 UTC (permalink / raw)
  To: Andrew Vasquez; +Cc: linux-next, LKML, James Bottomley, David S. Miller

Hi James, Andrew,

(Previously reported by Dave Miller.)

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/scsi/qla2xxx/qla_attr.c: In function 'qla24xx_vport_delete':
drivers/scsi/qla2xxx/qla_attr.c:1184: error: implicit declaration of function 'msleep'

I applied the patch below.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

>From 879b13261ee593b8afcae80a33844f162e8e8a5c Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 28 Jul 2008 15:02:35 +1000
Subject: [PATCH] scsi: msleep is declared in delay.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/scsi/qla2xxx/qla_attr.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
index 7a4409a..a319a20 100644
--- a/drivers/scsi/qla2xxx/qla_attr.c
+++ b/drivers/scsi/qla2xxx/qla_attr.c
@@ -8,6 +8,7 @@
 
 #include <linux/kthread.h>
 #include <linux/vmalloc.h>
+#include <linux/delay.h>
 
 static int qla24xx_vport_disable(struct fc_vport *, bool);
 
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-07-28  4:44 Stephen Rothwell
  0 siblings, 0 replies; 96+ messages in thread
From: Stephen Rothwell @ 2008-07-28  4:44 UTC (permalink / raw)
  To: Karsten Keil; +Cc: linux-next, LKML, David S. Miller

Hi Karsten,

(Previously reported by Dave Miller for Sparc)

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/isdn/hardware/mISDN/hfcmulti.c:5255:2: error: #error "not running on big endian machines now"

I just disabled it using the patch below.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

>From c4f3c0cba3811f71465c332fe36fe30b3b17f507 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 28 Jul 2008 14:38:29 +1000
Subject: [PATCH] hfcmulti is not supported on big endian

So stick it to X86 for now.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/isdn/hardware/mISDN/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/isdn/hardware/mISDN/Kconfig b/drivers/isdn/hardware/mISDN/Kconfig
index 9cd5f5f..1a78575 100644
--- a/drivers/isdn/hardware/mISDN/Kconfig
+++ b/drivers/isdn/hardware/mISDN/Kconfig
@@ -16,6 +16,7 @@ config MISDN_HFCMULTI
 	tristate "Support for HFC multiport cards (HFC-4S/8S/E1)"
 	depends on PCI
 	depends on MISDN
+	depends on X86
 	help
 	  Enable support for cards with Cologne Chip AG's HFC multiport
 	  chip. There are three types of chips that are quite similar,
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-07-25  6:45 Stephen Rothwell
  0 siblings, 0 replies; 96+ messages in thread
From: Stephen Rothwell @ 2008-07-25  6:45 UTC (permalink / raw)
  To: linux-next; +Cc: Andrew Morton

Hi all,

Today's linux-next build (powerpc ppc44x_config) failed like this:

mm/migrate.c: In function 'remove_migration_pte':
mm/migrate.c:195: error: implicit declaration of function 'update_mmu_cache'

I applied the patch below from Benjamin Herrenschmidt (which he will send
to Linus).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

>From 1e3519f8e1baec0b733cd42684fcd3d9681662f1 Mon Sep 17 00:00:00 2001
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Fri, 25 Jul 2008 16:21:11 +1000
Subject: [PATCH] Move update_mmu_cache() declaration from tlbflush.h to pgtable.h
where it belongs. This fixes some build problems on some configs

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
 include/asm-powerpc/pgtable.h  |   13 +++++++++++++
 include/asm-powerpc/tlbflush.h |   11 -----------
 2 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/include/asm-powerpc/pgtable.h b/include/asm-powerpc/pgtable.h
index d18ffe7..dbb8ca1 100644
--- a/include/asm-powerpc/pgtable.h
+++ b/include/asm-powerpc/pgtable.h
@@ -38,6 +38,19 @@ extern void paging_init(void);
 		remap_pfn_range(vma, vaddr, pfn, size, prot)
 
 #include <asm-generic/pgtable.h>
+
+
+/*
+ * This gets called at the end of handling a page fault, when
+ * the kernel has put a new PTE into the page table for the process.
+ * We use it to ensure coherency between the i-cache and d-cache
+ * for the page which has just been mapped in.
+ * On machines which use an MMU hash table, we use this to put a
+ * corresponding HPTE into the hash table ahead of time, instead of
+ * waiting for the inevitable extra hash-table miss exception.
+ */
+extern void update_mmu_cache(struct vm_area_struct *, unsigned long, pte_t);
+
 #endif /* __ASSEMBLY__ */
 
 #endif /* __KERNEL__ */
diff --git a/include/asm-powerpc/tlbflush.h b/include/asm-powerpc/tlbflush.h
index 5c91081..361cd5c 100644
--- a/include/asm-powerpc/tlbflush.h
+++ b/include/asm-powerpc/tlbflush.h
@@ -162,16 +162,5 @@ extern void __flush_hash_table_range(struct mm_struct *mm, unsigned long start,
 
 #endif
 
-/*
- * This gets called at the end of handling a page fault, when
- * the kernel has put a new PTE into the page table for the process.
- * We use it to ensure coherency between the i-cache and d-cache
- * for the page which has just been mapped in.
- * On machines which use an MMU hash table, we use this to put a
- * corresponding HPTE into the hash table ahead of time, instead of
- * waiting for the inevitable extra hash-table miss exception.
- */
-extern void update_mmu_cache(struct vm_area_struct *, unsigned long, pte_t);
-
 #endif /*__KERNEL__ */
 #endif /* _ASM_POWERPC_TLBFLUSH_H */
-- 
1.5.2.4122.g5cc8f-dirty

^ permalink raw reply related	[flat|nested] 96+ messages in thread
* linux-next: build failure
@ 2008-06-30 13:22 Stephen Rothwell
  2008-06-30 14:06 ` Ingo Molnar
                   ` (2 more replies)
  0 siblings, 3 replies; 96+ messages in thread
From: Stephen Rothwell @ 2008-06-30 13:22 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: linux-next, Thomas Gleixner, Ingo Molnar, H. Peter Anvin

[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]

Hi Sam,

Today's linux-next build (i386 defconfig) failed like this:

  GEN     /scratch/sfr/i386_defconfig/Makefile
  GEN     /scratch/sfr/i386_defconfig/Makefile
  SYMLINK include/asm -> include/asm-x86
  Using /scratch/sfr/next as source for kernel
/bin/sh: include/asm/asm-offsets.h: No such file or directory

I can only guess that this is a kbuild problem.  The object include directory
looked like this:

/scratch/sfr/i386_defconfig/include$ ls -la
total 24
drwxr-xr-x   5 sfr users 4096 2008-06-30 23:06 .
drwxr-xr-x   8 sfr users 4096 2008-06-30 23:06 ..
lrwxrwxrwx   1 sfr users    7 2008-06-30 23:06 asm -> asm-x86
drwxr-xr-x   2 sfr users 4096 2008-06-30 23:06 asm-i386
drwxr-xr-x 184 sfr users 8192 2008-06-30 23:06 config
drwxr-xr-x   2 sfr users 4096 2008-06-30 23:06 linux

My powerpc (ppc64_defconfig, allnoconfig, allyesconfig and
ppc44x_deconfig), x86_64 (allmodconfig), sparc (defconfig) and sparc64
(defconfig) build all worked.  The kisskb overnight builds will show us
what else is broken.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 96+ messages in thread
[parent not found: <20080512154717.2d0947f0.sfr@canb.auug.org.au>]

end of thread, other threads:[~2014-05-12 17:05 UTC | newest]

Thread overview: 96+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-02  9:02 linux-next: build failure Stephen Rothwell
2009-02-02 19:43 ` Yinghai Lu
2009-02-03  6:14 ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2014-05-12 13:18 linux-next " Mark Salter
2014-05-12 15:47 ` Mark Salter
2014-05-12 17:05 ` Al Viro
2014-01-03 15:58 Mark Salter
2014-01-03 22:56 ` Andrew Morton
2014-01-06 15:21   ` Mark Salter
2013-11-08 16:51 Mark Salter
2013-10-30 15:27 Mark Salter
2013-10-30 20:37 ` Stephen Rothwell
2013-10-30 20:50   ` Andrew Morton
2013-10-30 23:17     ` Stephen Rothwell
     [not found] <CAHfT02u5as-YvAvwznMveNY_FbeDWLbj0NL6O78MRfeLQ5mpsA@mail.gmail.com>
2011-12-22 23:55 ` linux-next: " Carles Pey
2011-12-23  6:08   ` Stephen Rothwell
2011-12-30 19:43     ` Carles Pey
2009-04-08  4:04 Stephen Rothwell
2009-04-08  5:12 ` Alan Modra
2009-01-08  5:20 Stephen Rothwell
2009-01-08  5:42 ` David Miller
2008-12-09  7:34 Stephen Rothwell
2008-12-09 21:05 ` Jesse Barnes
2008-11-11  8:10 Stephen Rothwell
2008-11-11  8:15 ` Sujith
2008-11-11  9:18 ` David Miller
2008-11-07  9:25 Stephen Rothwell
2008-11-07 16:40 ` Hollis Blanchard
2008-11-07 17:05   ` Josh Boyer
2008-11-07 17:24     ` Hollis Blanchard
2008-11-07 17:34       ` Josh Boyer
2008-11-07 21:18         ` Hollis Blanchard
2008-11-07 22:54   ` Stephen Rothwell
2008-11-09 15:50     ` Avi Kivity
2008-10-23  9:51 Stephen Rothwell
2008-10-23  9:18 Stephen Rothwell
2008-10-20 12:04 Stephen Rothwell
2008-10-20 15:48 ` Greg KH
2008-10-20 16:33   ` J.R. Mauro
2008-10-20 16:51     ` Greg KH
2008-10-20 20:47       ` Greg KH
2008-10-20 22:34         ` J.R. Mauro
2008-10-20 22:31   ` Stephen Rothwell
2008-10-17  8:21 Stephen Rothwell
2008-10-17 17:37 ` Greg KH
2008-10-17  7:59 Stephen Rothwell
2008-10-16  9:29 Stephen Rothwell
2008-10-16 10:39 ` Ingo Molnar
2008-10-16 16:11   ` Jeremy Fitzhardinge
2008-10-16 16:14     ` Ingo Molnar
2008-10-16  9:28 Stephen Rothwell
2008-10-16 14:00 ` Eric Van Hensbergen
2008-09-03  8:45 Stephen Rothwell
2008-09-03 10:19 ` David Woodhouse
2008-08-27  0:06 Stephen Rothwell
2008-08-27  2:55 ` Rusty Russell
2008-08-27  4:54   ` Stephen Rothwell
2008-08-25 11:28 Stephen Rothwell
2008-08-25 12:40 ` Ingo Molnar
2008-08-28  7:40 ` David Miller
2008-07-30  5:30 Stephen Rothwell
2008-07-30  5:54 ` Ananth N Mavinakayanahalli
2008-07-30  6:41 ` Adrian Bunk
     [not found]   ` <20080730064146.GA1564-re2QNgSbS3j4D6uPqz5PAwR5/fbUUdgG@public.gmane.org>
2008-07-30  7:06     ` Ankita Garg
     [not found]       ` <20080730070643.GA18347-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org>
2008-07-30 19:16         ` Bartlomiej Zolnierkiewicz
2008-07-30 23:35           ` Stephen Rothwell
2008-07-29  6:23 Stephen Rothwell
2008-07-29  8:00 ` Ingo Molnar
2008-07-29  8:03   ` Stephen Rothwell
2008-07-29  8:58     ` Ingo Molnar
2008-07-29 11:28       ` KOSAKI Motohiro
2008-07-29 11:40         ` Ingo Molnar
2008-07-29 14:31           ` Mike Travis
2008-07-29 14:33             ` Mike Travis
2008-07-29 16:33           ` Linus Torvalds
2008-07-29 16:42             ` Ingo Molnar
2008-07-29 16:44             ` Linus Torvalds
2008-07-29  8:14   ` Wenji Huang
2008-07-29 16:26   ` Linus Torvalds
2008-07-28  5:07 Stephen Rothwell
2008-07-28  4:44 Stephen Rothwell
2008-07-25  6:45 Stephen Rothwell
2008-06-30 13:22 Stephen Rothwell
2008-06-30 14:06 ` Ingo Molnar
2008-06-30 14:46   ` Stephen Rothwell
2008-06-30 15:12 ` Randy Dunlap
2008-06-30 15:49   ` Randy Dunlap
2008-06-30 23:30     ` Stephen Rothwell
2008-06-30 16:10 ` Sam Ravnborg
2008-06-30 16:44   ` Randy Dunlap
     [not found] <20080512154717.2d0947f0.sfr@canb.auug.org.au>
2008-05-12  7:54 ` David Miller
2008-05-12  8:09   ` Stephen Rothwell
2008-05-12  8:15     ` Stephen Rothwell
2008-05-12  8:53       ` David Miller
2008-05-12 10:42         ` Stephen Rothwell
2008-05-12 16:50 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).