linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: linux-next@vger.kernel.org, yanghy@cn.fujitsu.com
Subject: Re: linux-next: wireless tree build failure
Date: Sun, 22 Mar 2009 21:55:41 -0700 (PDT)	[thread overview]
Message-ID: <20090322.215541.205935147.davem@davemloft.net> (raw)
In-Reply-To: <20090323153954.95094b80.sfr@canb.auug.org.au>


Stephen does this fix the build for you?

I want to have you test it before I commit because unlike
some people I'd like to build test changes before submitting
them anywhere.

Yang, I am pretty pissed at you, this is beyond unforgivable.
There is zero excuse for this build regression.

Grumble!

diff --git a/drivers/net/spider_net.c b/drivers/net/spider_net.c
index 136d9f1..0288054 100644
--- a/drivers/net/spider_net.c
+++ b/drivers/net/spider_net.c
@@ -2260,18 +2260,18 @@ spider_net_tx_timeout(struct net_device *netdev)
 }
 
 static const struct net_device_ops spider_net_ops = {
-	.ndo_open		= spider_net_open;
-	.ndo_stop		= spider_net_stop;
-	.ndo_start_xmit		= spider_net_xmit;
-	.ndo_set_multicast_list	= spider_net_set_multi;
-	.ndo_set_mac_address	= spider_net_set_mac;
-	.ndo_change_mtu		= spider_net_change_mtu;
-	.ndo_do_ioctl		= spider_net_do_ioctl;
-	.ndo_tx_timeout		= spider_net_tx_timeout;
+	.ndo_open		= spider_net_open,
+	.ndo_stop		= spider_net_stop,
+	.ndo_start_xmit		= spider_net_xmit,
+	.ndo_set_multicast_list	= spider_net_set_multi,
+	.ndo_set_mac_address	= spider_net_set_mac,
+	.ndo_change_mtu		= spider_net_change_mtu,
+	.ndo_do_ioctl		= spider_net_do_ioctl,
+	.ndo_tx_timeout		= spider_net_tx_timeout,
 	/* HW VLAN */
 #ifdef CONFIG_NET_POLL_CONTROLLER
 	/* poll controller */
-	.ndo_poll_controller	= spider_net_poll_controller;
+	.ndo_poll_controller	= spider_net_poll_controller,
 #endif /* CONFIG_NET_POLL_CONTROLLER */
 };
 

  parent reply	other threads:[~2009-03-23  4:55 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-23  4:39 linux-next: wireless tree build failure Stephen Rothwell
2009-03-23  4:53 ` David Miller
2009-03-23  5:01   ` Yang Hongyang
2009-03-23  4:55 ` David Miller [this message]
2009-03-23  5:06   ` Yang Hongyang
2009-03-23  5:48   ` Stephen Rothwell
2009-03-23  7:59     ` David Miller
2009-03-23  8:10       ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2009-11-09  8:08 Stephen Rothwell
2009-11-09 13:37 ` Bartlomiej Zolnierkiewicz
     [not found] <20090505115455.0b147aeb.sfr@canb.auug.org.au>
2009-05-05  2:55 ` John W. Linville
2009-04-22  1:57 Stephen Rothwell
2009-04-22  8:59 ` Johannes Berg
2009-04-22 13:03   ` Stephen Rothwell
2009-04-22 13:06     ` John W. Linville
2009-04-22 13:33       ` Johannes Berg
2009-04-22 13:36         ` Matthew Garrett
2009-06-03  2:52           ` Stephen Rothwell
2009-06-15 12:21             ` Stephen Rothwell
2009-04-22 13:11     ` Johannes Berg
2009-04-28  3:28 ` Stephen Rothwell
2009-04-28 12:50   ` John W. Linville
2009-02-27  2:44 Stephen Rothwell
2009-02-12  8:35 Stephen Rothwell
2009-02-12 16:16 ` John W. Linville
2009-02-12 22:07   ` Stephen Rothwell
2009-02-13 18:24   ` Dave
2009-02-13 18:24     ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090322.215541.205935147.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=yanghy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).