linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: driver-core tree build failure
@ 2009-03-16  9:47 Stephen Rothwell
  2009-03-22 12:22 ` Stephen Rothwell
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2009-03-16  9:47 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, David S. Miller

Hi Greg,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/net/dnet.c: In function 'dnet_mii_probe':
drivers/net/dnet.c:283: error: 'struct device' has no member named 'bus_id'
drivers/net/dnet.c:287: error: 'struct device' has no member named 'bus_id'
drivers/net/dnet.c: In function 'dnet_probe':
drivers/net/dnet.c:928: error: 'struct device' has no member named 'bus_id'

Another new driver (in net-current) that needs conversion for then bus_id
removal.  I applied the patch below for today.

Dave, this could apply to net-current (or net after you merge
net-current) or Greg could put it in driver-core after net-current gets
merged into Linus' tree.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 16 Mar 2009 20:37:10 +1100
Subject: [PATCH] net: update dnet.c for bus_id removal

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/dnet.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/dnet.c b/drivers/net/dnet.c
index 5c347f7..1b40632 100644
--- a/drivers/net/dnet.c
+++ b/drivers/net/dnet.c
@@ -280,11 +280,11 @@ static int dnet_mii_probe(struct net_device *dev)
 
 	/* attach the mac to the phy */
 	if (bp->capabilities & DNET_HAS_RMII) {
-		phydev = phy_connect(dev, phydev->dev.bus_id,
+		phydev = phy_connect(dev, dev_name(&phydev->dev),
 				     &dnet_handle_link_change, 0,
 				     PHY_INTERFACE_MODE_RMII);
 	} else {
-		phydev = phy_connect(dev, phydev->dev.bus_id,
+		phydev = phy_connect(dev, dev_name(&phydev->dev),
 				     &dnet_handle_link_change, 0,
 				     PHY_INTERFACE_MODE_MII);
 	}
@@ -927,7 +927,7 @@ static int __devinit dnet_probe(struct platform_device *pdev)
 	phydev = bp->phy_dev;
 	dev_info(&pdev->dev, "attached PHY driver [%s] "
 	       "(mii_bus:phy_addr=%s, irq=%d)\n",
-	       phydev->drv->name, phydev->dev.bus_id, phydev->irq);
+	       phydev->drv->name, dev_name(&phydev->dev), phydev->irq);
 
 	return 0;
 
-- 
1.6.2

^ permalink raw reply related	[flat|nested] 59+ messages in thread
* linux-next: driver-core tree build failure
@ 2009-07-14  6:33 Stephen Rothwell
  2009-07-14  7:31 ` David Brownell
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2009-07-14  6:33 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel, David Brownell

Hi Greg,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/mtd/mtdcore.c:220: error: expected '{' before 'const'
drivers/mtd/mtdcore.c:227: error: 'mtd_groups' undeclared here (not in a function)

Caused by the update to commit ba87b739a1f5dd545679d886b8d193cdede991cf
("driver model: constify attribute groups").

I have applied the patch below for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 14 Jul 2009 16:29:39 +1000
Subject: [PATCH] driver-core: fix for mtd typo

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/mtd/mtdcore.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 93e6731..05a16be 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -217,7 +217,7 @@ struct attribute_group mtd_group = {
 	.attrs		= mtd_attrs,
 };
 
-struct const attribute_group *mtd_groups[] = {
+const struct attribute_group *mtd_groups[] = {
 	&mtd_group,
 	NULL,
 };
-- 
1.6.3.3

^ permalink raw reply related	[flat|nested] 59+ messages in thread
* linux-next: driver-core tree build failure
@ 2009-06-23  6:01 Stephen Rothwell
  2009-06-23 15:29 ` Greg KH
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2009-06-23  6:01 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel, Russell King

[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]

Hi Greg,

Today's linux-next build (arm omap_osk_5912_defconfig) failed like this:

drivers/video/omap/omapfb_main.c: In function 'omapfb_show_caps_num':
drivers/video/omap/omapfb_main.c:1253: error: 'struct device' has no member named 'driver_data'
drivers/video/omap/omapfb_main.c: In function 'omapfb_show_caps_text':
drivers/video/omap/omapfb_main.c:1273: error: 'struct device' has no member named 'driver_data'
drivers/video/omap/omapfb_main.c: In function 'omapfb_show_panel_name':
drivers/video/omap/omapfb_main.c:1320: error: 'struct device' has no member named 'driver_data'
drivers/video/omap/omapfb_main.c: In function 'omapfb_show_bklight_level':
drivers/video/omap/omapfb_main.c:1329: error: 'struct device' has no member named 'driver_data'
drivers/video/omap/omapfb_main.c: In function 'omapfb_store_bklight_level':
drivers/video/omap/omapfb_main.c:1344: error: 'struct device' has no member named 'driver_data'
drivers/video/omap/omapfb_main.c: In function 'omapfb_show_bklight_max':
drivers/video/omap/omapfb_main.c:1363: error: 'struct device' has no member named 'driver_data'
drivers/video/omap/omapfb_main.c: In function 'omapfb_show_ctrl_name':
drivers/video/omap/omapfb_main.c:1396: error: 'struct device' has no member named 'driver_data'

Caused by commit 53d8ba57f16029a47ed5df9840ab6c3f9abd3727 ("Driver core:
move dev_get/set_drvdata to drivers/base/dd.c") from the driver-core tree.

I see more grepping in your future :-)
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread
* linux-next: driver-core tree build failure
@ 2009-05-12  3:44 Stephen Rothwell
  2009-05-12  4:05 ` Greg KH
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2009-05-12  3:44 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, Roel Kluin

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

Hi Greg,

Today's linux-next build (powerpc_ppc64_defconfig) failed like this:

In file included from arch/powerpc/platforms/ps3/platform.h:28,
                 from arch/powerpc/platforms/ps3/mm.c:32:
arch/powerpc/include/asm/ps3.h: In function 'ps3_system_bus_set_driver_data':
arch/powerpc/include/asm/ps3.h:424: error: 'struct device' has no member named 'driver_data'
arch/powerpc/include/asm/ps3.h: In function 'ps3_system_bus_get_driver_data':
arch/powerpc/include/asm/ps3.h:429: error: 'struct device' has no member named 'driver_data'

Caused (obviously) by commit 9499952d8efc857406365bfc04079ff1e85660ff
("Driver core: move dev_get/set_drvdata to drivers/base/dd.c") which I
have reverted.

Grep is your friend ...  Actually there is a patch for this ...
http://patchwork.ozlabs.org/patch/27061/ ... also for another ...
http://patchwork.ozlabs.org/patch/27062/

Please leave the above commit out of the tree until you have at least
fixed all the in tree users.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread
* linux-next: driver-core tree build failure
@ 2009-05-04  6:25 Stephen Rothwell
  2009-05-04 13:00 ` Kay Sievers
  2009-05-09 11:16 ` Stephen Rothwell
  0 siblings, 2 replies; 59+ messages in thread
From: Stephen Rothwell @ 2009-05-04  6:25 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, Kay Sievers

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

Hi Greg,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/hid/usbhid/hiddev.c:965: error: unknown field 'nodename' specified in initializer
drivers/hid/usbhid/hiddev.c:965: warning: initialization from incompatible pointer type

Caused by commit 5b1e3a40a98ad5a822cb527439cd57dc60a41db9 ("Driver Core:
devtmpfs - driver core maintained /dev tmpfs").  As far as I can see the
version of this patch in your quilt series currently has never been
posted anywhere public ... The diff summaries for the previous and
current version of this patch are:

- 18 files changed, 484 insertions(+), 5 deletions(-)
+ 38 files changed, 599 insertions(+), 11 deletions(-)

Which is a pretty big change for something in linux-next.  So, can we
please remove this patch until it has proper review, been tested and has
settled down a bit.

I have reverted that patch for today (anything else was harder).
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread
* linux-next: driver-core tree build failure
@ 2009-03-26  7:34 Stephen Rothwell
  2009-03-26 23:00 ` Jesse Barnes
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2009-03-26  7:34 UTC (permalink / raw)
  To: Greg KH, Jesse Barnes; +Cc: linux-next, Trent Piepho, Kay Sievers

Hi Greg, Jesse,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/pci/hotplug/fakephp.c: In function 'legacy_add_slot':
drivers/pci/hotplug/fakephp.c:91: error: 'struct device' has no member named 'bus_id'

Caused by commit 83dbf66f04b96e65c6c18436c16d40f9cf8630aa ("PCI Hotplug:
restore fakephp interface with complete reimplementation") from the pci
tree which added another use of bus_id. (Commit
c32e967b935450c5178ebeaabb9ed889b14ed197 ("driver core: get rid of struct
device's bus_id string array") removes bus_id.)

I applied the batch below.  Jesse, this is suitable for the pci tree as
the dev_name() interface already exists in Linus' tree.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 26 Mar 2009 18:25:06 +1100
Subject: [PATCH] pci: update fakephp for bus_id removal

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/pci/hotplug/fakephp.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/hotplug/fakephp.c b/drivers/pci/hotplug/fakephp.c
index 2dc7828..21c2f5d 100644
--- a/drivers/pci/hotplug/fakephp.c
+++ b/drivers/pci/hotplug/fakephp.c
@@ -18,6 +18,7 @@
 #include <linux/sysfs.h>
 #include <linux/init.h>
 #include <linux/pci.h>
+#include <linux/device.h>
 #include "../pci.h"
 
 struct legacy_slot {
@@ -88,7 +89,7 @@ static int legacy_add_slot(struct pci_dev *pdev)
 
 	if (kobject_init_and_add(&slot->kobj, &legacy_ktype,
 				 &pci_slots_kset->kobj, "%s",
-				 pdev->dev.bus_id)) {
+				 dev_name(&pdev->dev))) {
 		dev_warn(&pdev->dev, "Failed to created legacy fake slot\n");
 		return -EINVAL;
 	}
-- 
1.6.2.1

^ permalink raw reply related	[flat|nested] 59+ messages in thread
* linux-next: driver-core tree build failure
@ 2009-03-10  8:24 Stephen Rothwell
  2009-03-10 13:31 ` Geert Uytterhoeven
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2009-03-10  8:24 UTC (permalink / raw)
  To: Greg KH
  Cc: linux-next, Jason Baron, Greg Banks, Geert Uytterhoeven, Herbert Xu

[-- Attachment #1: Type: text/plain, Size: 2043 bytes --]

Hi Greg,

Today's linux-next build (x86_64 allmodconfig) failed like this:

crypto/zlib.c: In function 'zlib_compress_update':
crypto/zlib.c:148: warning: initialization makes integer from pointer without a cast
crypto/zlib.c:148: error: initializer element is not computable at load time
crypto/zlib.c:148: error: (near initialization for 'descriptor.primary_hash')
crypto/zlib.c:148: warning: excess elements in struct initializer
crypto/zlib.c:148: warning: (near initialization for 'descriptor')

And many more similar.  This line is a pr_debug() statement, so the
finger points at commit 25b67b75587d43ff3f09ad88c03c70a38372d95d
("dynamic debug: combine dprintk and dynamic printk") from the
driver-core tree.

The preprocessed code looks like this:

static int zlib_compress_update(struct crypto_pcomp *tfm,
    struct comp_request *req)
{
 int ret;
 struct zlib_ctx *dctx = crypto_tfm_ctx(crypto_pcomp_tfm(tfm));
 struct z_stream_s *stream = &dctx->comp_stream;

 do { do { static struct _ddebug descriptor __attribute__((__used__)) __attribute__((section("__verbose"), aligned(8))) = { "zlib", __func__, "/scratch/sfr/next/crypto/zlib.c", "%s: " "avail_in %u, avail_out %u\n", __func__, 55, 33, 148, 0 }; if (({ int __ret = 0; if (__builtin_expect(!!((dynamic_debug_enabled & (1LL << 55)) && (dynamic_debug_enabled2 & (1LL << 33))), 0)) if (__builtin_expect(!!(descriptor.flags), 0)) __ret = 1; __ret; })) printk("<7>" "zlib" ":" "%s: " "avail_in %u, avail_out %u\n", __func__, req->avail_in, req->avail_out); } while (0); } while (0);

The problem is the line:

#define pr_fmt(fmt)     "%s: " fmt, __func__

in crypto/zlib.c which was introduced by commit
bf68e65ec9ea61e32ab71bef59aa5d24d255241f ("crypto: zlib - New zlib crypto
module, using pcomp") from the crypto tree.

For today, I have removed the above line from crypto/zlib.c, but
something better needs to be done for tomorrow!

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread
* linux-next: driver-core tree build failure
@ 2009-01-26  0:50 Stephen Rothwell
  2009-01-26  1:10 ` Greg KH
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2009-01-26  0:50 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, Kay Sievers

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

Hi Greg,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

arch/powerpc/platforms/ps3/system-bus.c: In function 'ps3_system_bus_probe':
arch/powerpc/platforms/ps3/system-bus.c:379: error: 'struct device' has no member named 'bus_id'
arch/powerpc/platforms/ps3/system-bus.c: In function 'ps3_system_bus_remove':
arch/powerpc/platforms/ps3/system-bus.c:401: error: 'struct device' has no member named 'bus_id'

Caused by commit aab0d375e01d8c16e7e5b9bd915dfaa0a815418f ("powerpc:
struct device - replace bus_id with dev_name(), dev_set_name()") not
being thorough enough before commit
73babb2d89a71d2110b65aab658e6309748827c2 ("driver core: get rid of struct
device's bus_id string array") was applied.

I have reverted the latter commit.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread
* linux-next: driver-core tree build failure
@ 2008-12-22 12:59 Stephen Rothwell
  2008-12-22 14:50 ` Mark McLoughlin
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2008-12-22 12:59 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, Mark McLoughlin

Hi Greg,

Today's linux-next build (powerpc allnoconfig) failed like this:

drivers/base/core.c: In function '__root_device_register':
drivers/base/core.c:1277: error: dereferencing pointer to incomplete type

Caused by bf86dbd2451d1012c2c968a960470e485b869f5b ("driver core: add
root_device_register()").  This needs to cope with !CONFIG_MODULES (where
struct module is not defined).

I applied the following patch but only for today because it is too hard
to revert the above patch ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 22 Dec 2008 23:50:56 +1100
Subject: [PATCH] driver core: fix root_device_register for not CONFIG_MODULES

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/base/core.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 6fbdd8b..aa93980 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -1273,6 +1273,7 @@ struct device *__root_device_register(const char *name, struct module *owner)
 		return ERR_PTR(err);
 	}
 
+#ifdef CONFIG_MODULE
 	if (owner) {
 		struct module_kobject *mk = &owner->mkobj;
 
@@ -1283,6 +1284,7 @@ struct device *__root_device_register(const char *name, struct module *owner)
 		}
 		root->owner = owner;
 	}
+#endif
 
 	return &root->dev;
 }
-- 
1.6.0.5

^ permalink raw reply related	[flat|nested] 59+ messages in thread
* linux-next: driver-core tree build failure
@ 2008-12-11  0:21 Stephen Rothwell
  2008-12-11  4:55 ` Greg KH
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2008-12-11  0:21 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, Kay Sievers

[-- Attachment #1: Type: text/plain, Size: 669 bytes --]

Hi Greg,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/mtd/maps/physmap.c: In function 'physmap_flash_probe':
drivers/mtd/maps/physmap.c:108: error: expected ')' before '{' token
drivers/mtd/maps/physmap.c:144: error: expected expression before '}' token

Caused by commit 7267696c2421503e280d9da5bbdbd5c11e1e5b25 ("mtd: struct
device - replace bus_id with dev_name(), dev_set_name()").

I have reverted that patch for today.

Please be more careful ... allmodconfig is your friend when doing wide
ranging changes ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread
* linux-next: driver-core tree build failure
@ 2008-11-19  0:30 Stephen Rothwell
  2008-11-19  0:40 ` Kay Sievers
  2008-11-19  5:43 ` Stephen Rothwell
  0 siblings, 2 replies; 59+ messages in thread
From: Stephen Rothwell @ 2008-11-19  0:30 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, Kay Sievers

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

Hi Greg,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

arch/powerpc/kernel/vio.c: In function 'vio_register_device_node':
arch/powerpc/kernel/vio.c:1246: error: incompatible type for argument 1 of 'dev_name'

Caused by commit 92136135687b1f8f5d3f03baa3cec40dbc6e73e9 ("powerpc:
struct device - replace bus_id with dev_name(), dev_set_name()").

I have dropped the driver-core tree (and the usb tree that depends on it)
from linux-next for today. 
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 59+ messages in thread
* linux-next: driver-core tree build failure
@ 2008-09-12  3:53 Stephen Rothwell
  2008-09-15 18:58 ` Greg KH
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2008-09-12  3:53 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, Hannes Reinecke

Hi Greg,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/net/wireless/atmel_cs.c: In function 'atmel_config':
drivers/net/wireless/atmel_cs.c:237: error: incompatible type for argument 1 of 'dev_get_drvdata'

Introduced by commit 107aeb9753159da848f066b26557f0aaab900a90 ("Driver
core: Use dev_get_drvdata() accessors").  handle_to_dev returns a struct
device not a struct device *.

I applied the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 12 Sep 2008 13:50:07 +1000
Subject: [PATCH] driver-core: atmel_cs.c fixup

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/wireless/atmel_cs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/atmel_cs.c b/drivers/net/wireless/atmel_cs.c
index 9b002cc..8ef37d0 100644
--- a/drivers/net/wireless/atmel_cs.c
+++ b/drivers/net/wireless/atmel_cs.c
@@ -234,7 +234,7 @@ static int atmel_config(struct pcmcia_device *link)
 	struct pcmcia_device_id *did;
 
 	dev = link->priv;
-	did = dev_get_drvdata(handle_to_dev(link));
+	did = dev_get_drvdata(&handle_to_dev(link));
 
 	DEBUG(0, "atmel_config(0x%p)\n", link);
 
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 59+ messages in thread
* linux-next:  driver-core tree build failure
@ 2008-08-15  8:25 Stephen Rothwell
  2008-08-16  5:31 ` Greg KH
  0 siblings, 1 reply; 59+ messages in thread
From: Stephen Rothwell @ 2008-08-15  8:25 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next

Hi Greg,

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/usb/gadget/f_ecm.c:737: error: __ksymtab_ecm_bind causes a section type conflict

You really shouldn't EXPORT static functions.  I applied the patch below.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

diff --git a/drivers/usb/gadget/f_ecm.c b/drivers/usb/gadget/f_ecm.c
index ff85c9d..6d0a88c 100644
--- a/drivers/usb/gadget/f_ecm.c
+++ b/drivers/usb/gadget/f_ecm.c
@@ -599,7 +599,7 @@ static void ecm_close(struct gether *geth)
 
 /* ethernet function driver setup/binding */
 
-static int __init
+int __init
 ecm_bind(struct usb_configuration *c, struct usb_function *f)
 {
 	struct usb_composite_dev *cdev = c->cdev;

^ permalink raw reply related	[flat|nested] 59+ messages in thread

end of thread, other threads:[~2009-07-16 22:56 UTC | newest]

Thread overview: 59+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-16  9:47 linux-next: driver-core tree build failure Stephen Rothwell
2009-03-22 12:22 ` Stephen Rothwell
2009-03-23  4:23   ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2009-07-14  6:33 Stephen Rothwell
2009-07-14  7:31 ` David Brownell
2009-07-16 22:50   ` Greg KH
2009-06-23  6:01 Stephen Rothwell
2009-06-23 15:29 ` Greg KH
2009-06-23 16:28   ` Greg KH
2009-05-12  3:44 Stephen Rothwell
2009-05-12  4:05 ` Greg KH
2009-05-13  0:13   ` Greg KH
2009-05-13  1:39     ` Stephen Rothwell
2009-05-04  6:25 Stephen Rothwell
2009-05-04 13:00 ` Kay Sievers
2009-05-05  4:18   ` Stephen Rothwell
2009-05-05  4:29     ` Greg KH
2009-05-09 11:16 ` Stephen Rothwell
2009-05-09 13:51   ` Greg KH
2009-03-26  7:34 Stephen Rothwell
2009-03-26 23:00 ` Jesse Barnes
2009-03-10  8:24 Stephen Rothwell
2009-03-10 13:31 ` Geert Uytterhoeven
2009-03-10 13:38   ` Herbert Xu
2009-03-10 13:53   ` Martin Schwidefsky
2009-03-10 15:29     ` Geert Uytterhoeven
2009-03-10 16:08       ` Martin Schwidefsky
2009-03-10 20:02         ` Jason Baron
2009-03-11  3:30           ` Greg KH
2009-03-11  8:33           ` Geert Uytterhoeven
2009-03-11 10:07           ` Greg Banks
2009-03-11 10:50             ` Geert Uytterhoeven
2009-03-11 15:12             ` Jason Baron
2009-01-26  0:50 Stephen Rothwell
2009-01-26  1:10 ` Greg KH
2009-01-26 12:19   ` Kay Sievers
2009-01-26 17:40     ` Greg KH
2008-12-22 12:59 Stephen Rothwell
2008-12-22 14:50 ` Mark McLoughlin
2008-12-23  4:29   ` Greg KH
2008-12-29  6:34     ` Stephen Rothwell
2008-12-30 15:28       ` Stephen Rothwell
2009-01-02  7:26         ` Greg KH
2009-01-03  4:32           ` Stephen Rothwell
2008-12-11  0:21 Stephen Rothwell
2008-12-11  4:55 ` Greg KH
2008-11-19  0:30 Stephen Rothwell
2008-11-19  0:40 ` Kay Sievers
2008-11-19  2:22   ` Stephen Rothwell
2008-11-19  2:24     ` Stephen Rothwell
2008-11-19  6:36     ` Greg KH
2008-11-19  5:43 ` Stephen Rothwell
2008-11-19  6:26   ` Greg KH
2008-11-19  6:51     ` Stephen Rothwell
2008-11-19  6:55       ` Greg KH
2008-09-12  3:53 Stephen Rothwell
2008-09-15 18:58 ` Greg KH
2008-08-15  8:25 Stephen Rothwell
2008-08-16  5:31 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).