From: Jan Kara <jack@suse.cz>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: Theodore Tso <tytso@mit.edu>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
linux-ext4@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
sparclinux@vger.kernel.org
Subject: Re: next-20090310: ext4 hangs
Date: Thu, 26 Mar 2009 01:00:36 +0100 [thread overview]
Message-ID: <20090326000035.GB11024@duck.suse.cz> (raw)
In-Reply-To: <a4423d670903251538p3a7c180br1bcfe08c4f044c15@mail.gmail.com>
Hi,
thanks for the updated disassembly.
> 55bab0: 82 10 60 01 or %g1, 1, %g1
> spin_unlock(&journal->j_list_lock);
> 55bab4: 40 06 4b 20 call 6ee734 <_spin_unlock>
> 55bab8: c2 24 e0 28 st %g1, [ %l3 + 0x28 ]
OK, so it really seems that:
jinode->i_flags |= JI_COMMIT_RUNNING;
spin_unlock(&journal->j_list_lock);
has been compiled to
ld [ %l3 + 0x28 ], %g1
or %g1, 1, %g1
call 6ee734 <_spin_unlock>
st %g1, [ %l3 + 0x28 ]
Which seems like a bug in the compiler or in the way implement compiler
barriers in spin_unlock() on UP sparc. Or is there some sparc magic by which
this is correct code? Any clever sparc guy?
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2009-03-26 0:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 12:17 next-20090310: ext4 hangs Alexander Beregalov
2009-03-10 12:46 ` Theodore Tso
2009-03-10 12:54 ` Alexander Beregalov
2009-03-10 14:18 ` Alexander Beregalov
2009-03-10 15:47 ` Theodore Tso
2009-03-11 16:07 ` Alexander Beregalov
2009-03-25 15:11 ` Jan Kara
2009-03-25 15:15 ` Jan Kara
2009-03-25 15:18 ` Alexander Beregalov
2009-03-25 15:22 ` Jan Kara
2009-03-25 15:29 ` Alexander Beregalov
2009-03-25 16:15 ` Jan Kara
2009-03-25 17:07 ` Alexander Beregalov
2009-03-25 19:43 ` Jan Kara
2009-03-25 22:38 ` Alexander Beregalov
2009-03-26 0:00 ` Jan Kara [this message]
2009-03-26 0:17 ` Jiri Gaisler
2009-03-26 0:25 ` Jan Kara
2009-03-31 10:01 ` Jan Kara
2009-03-31 10:07 ` Alexander Beregalov
2009-03-31 12:33 ` Jan Kara
2009-04-02 18:50 ` Alexander Beregalov
2009-04-04 21:09 ` Alexander Beregalov
2009-04-06 9:20 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090326000035.GB11024@duck.suse.cz \
--to=jack@suse.cz \
--cc=a.beregalov@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).