linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Linus <torvalds@linux-foundation.org>
Cc: linux-next@vger.kernel.org,
	Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Ingo Molnar <mingo@elte.hu>
Subject: linux-next: origin tree build failure
Date: Tue, 14 Apr 2009 14:43:17 +1000	[thread overview]
Message-ID: <20090414144317.026498df.sfr@canb.auug.org.au> (raw)

Hi all,

Today's linux-next build (sparc defconfig) failed like this:

In file included from kernel/panic.c:12:
include/linux/debug_locks.h: In function '__debug_locks_off':
include/linux/debug_locks.h:15: error: implicit declaration of function 'xchg'

Caused by commit 9eeba6138cefc0435695463ddadb0d95e0a6bcd2 ("lockdep: warn
about lockdep disabling after kernel taint").  xchg is defined in
asm/system.h on sparc. It looks like asm/atomic.h on 64bit sparc includes
asm/system.h, but not on 32bit.

Dave, arch/sparc/include/asm/atomic_32.h should really include
asm/system.h since xchg is used in there.

I have applied the following patch for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 14 Apr 2009 14:27:09 +1000
Subject: [PATCH] sparc: asm/atomic.h on 32bit should include asm/system.h for xchg

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/sparc/include/asm/atomic_32.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/sparc/include/asm/atomic_32.h b/arch/sparc/include/asm/atomic_32.h
index ce46597..bb91b12 100644
--- a/arch/sparc/include/asm/atomic_32.h
+++ b/arch/sparc/include/asm/atomic_32.h
@@ -15,6 +15,8 @@
 
 #ifdef __KERNEL__
 
+#include <asm/system.h>
+
 #define ATOMIC_INIT(i)  { (i) }
 
 extern int __atomic_add_return(int, atomic_t *);
-- 
1.6.2.1

             reply	other threads:[~2009-04-14  4:43 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-14  4:43 Stephen Rothwell [this message]
2009-04-14  8:57 ` linux-next: origin tree build failure David Miller
2009-04-14  9:20   ` Heiko Carstens
2009-04-14  9:08 ` David Miller
2009-04-14 10:26   ` Stephen Rothwell
2009-04-14  9:15 ` [PATCH] lockdep: warn about lockdep disabling after kernel taint, fix Ingo Molnar
2009-04-14  9:23   ` Heiko Carstens
2009-04-14 10:29   ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2010-01-12  1:14 linux-next: origin tree build failure Stephen Rothwell
2010-01-12  1:26 ` Linus Torvalds
2010-01-12  2:32   ` Stephen Rothwell
2010-01-12  2:39     ` Stephen Rothwell
2010-01-13  0:14       ` Phillip Lougher
2010-01-13  2:55         ` Stephen Rothwell
2010-01-11 23:58 Stephen Rothwell
2010-01-12  0:29 ` Joakim Tjernlund
2010-01-12 12:38 ` Joakim Tjernlund
2009-12-24  0:54 Stephen Rothwell
2009-12-15  5:41 Stephen Rothwell
2009-12-15  8:07 ` Ingo Molnar
2009-12-15 13:01 ` Peter Ujfalusi
2009-12-15 14:53 ` Mark Brown
2009-12-15 17:27   ` Tony Lindgren
2009-12-15 22:45     ` Stephen Rothwell
2009-12-15 23:02       ` Linus Torvalds
2009-12-15 23:37         ` Stephen Rothwell
2009-12-16  9:30       ` Samuel Ortiz
2009-12-09 23:57 Stephen Rothwell
2009-11-30 23:10 Stephen Rothwell
2009-11-12  0:23 Stephen Rothwell
2009-10-09  7:50 Stephen Rothwell
2009-07-09  0:28 Stephen Rothwell
2009-06-25  1:13 Stephen Rothwell
2009-06-25  3:24 ` Baruch Siach
2009-06-25  4:12   ` Paul Mundt
2009-06-23  6:22 Stephen Rothwell
2009-06-23 10:13 ` Mark Brown
2009-06-19  6:30 Stephen Rothwell
2009-06-12  0:46 Stephen Rothwell
2009-06-12  0:24 Stephen Rothwell
2009-06-12  0:53 ` Paul Mackerras
2009-06-12  1:00 ` Benjamin Herrenschmidt
2009-06-12  9:20   ` Ingo Molnar
2009-06-12  9:33     ` Benjamin Herrenschmidt
2009-06-12  9:43       ` Peter Zijlstra
2009-06-12  9:55         ` Ingo Molnar
2009-06-12  9:57         ` Benjamin Herrenschmidt
2009-06-12 12:53       ` Ingo Molnar
2009-06-12 13:10         ` Benjamin Herrenschmidt
2009-06-12 13:29           ` Benjamin Herrenschmidt
2009-06-12 13:49             ` Ingo Molnar
2009-06-12 14:06               ` Benjamin Herrenschmidt
2009-06-12 14:11                 ` Ingo Molnar
2009-06-12 14:23                   ` Benjamin Herrenschmidt
2009-06-13  5:06                   ` Stephen Rothwell
2009-06-12 13:44           ` Ingo Molnar
2009-06-12 13:56             ` Benjamin Herrenschmidt
2009-06-12 14:07               ` Ingo Molnar
2009-06-12 14:19                 ` Benjamin Herrenschmidt
2009-06-13  4:54             ` Stephen Rothwell
2009-04-14  7:34 Stephen Rothwell
2009-04-14  7:58 ` Jesper Nilsson
2009-04-08  3:28 Stephen Rothwell
2009-04-08  0:10 Stephen Rothwell
2009-03-30  0:55 Stephen Rothwell
     [not found] <20090112104837.69feedec.sfr@canb.auug.org.au>
2009-01-12  0:10 ` Benjamin Herrenschmidt
2009-01-12  0:10 ` Benjamin Herrenschmidt
2009-01-12  0:10 ` Benjamin Herrenschmidt
     [not found] ` <1231719015.22571.4.camel@pasglop>
2009-01-12  9:05   ` Ingo Molnar
2009-01-12  9:24     ` Stephen Rothwell
2009-01-12  9:32       ` Ingo Molnar
2009-01-13 16:31         ` Stephen Rothwell
2009-01-12  9:49     ` Michael Ellerman
2009-01-12 10:44       ` Ingo Molnar
2009-01-12 10:44       ` Ingo Molnar
2009-01-12 10:44       ` Ingo Molnar
2009-01-11 23:48 Stephen Rothwell
2009-01-11 23:48 Stephen Rothwell
2009-01-11 23:48 Stephen Rothwell
2008-12-29  0:43 Stephen Rothwell
2008-12-29  3:36 ` Roland Dreier
2008-12-29  3:44 ` Roland Dreier
2008-12-29  9:58   ` Aleksey Senin
2008-12-29  0:00 Stephen Rothwell
2008-12-28 23:51 Stephen Rothwell
2008-12-28 23:38 Stephen Rothwell
2008-12-29  0:31 ` Linus Torvalds
2008-10-16  0:35 Stephen Rothwell
2008-10-16  4:57 ` David Miller
2008-10-16  0:31 Stephen Rothwell
2008-10-16 12:58 ` Ralf Baechle
2008-10-14 22:59 Stephen Rothwell
2008-10-14 23:43 ` Linus Torvalds
2008-10-14 23:52   ` David Miller
2008-10-15  0:05   ` Mark Brown
2008-10-15  0:34     ` Linus Torvalds
2008-10-14 23:51 ` Linus Torvalds
2008-10-15  9:02 ` Alan Cox
2008-10-15  9:33 ` Ingo Molnar
2008-10-15 11:01   ` Mark Brown
2008-08-26  0:37 Stephen Rothwell
2008-08-18  0:01 Stephen Rothwell
2008-08-18 12:55 ` David Howells
2008-08-18 14:03   ` James Morris
2008-07-25  0:30 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090414144317.026498df.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=davem@davemloft.net \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).