From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH -next] cx231xx: fix SND dependency build error
Date: Mon, 20 Apr 2009 16:44:49 -0300 [thread overview]
Message-ID: <20090420164449.34942436@pedra.chehab.org> (raw)
In-Reply-To: <49DB7861.5050606@oracle.com>
On Tue, 07 Apr 2009 08:59:29 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Don't select VIDEO_CX231XX_ALSA when SND is not enabled since selecting it
> won't cause SND to be enabled.
Sorry for being late with this issue. I was fixing some upstream scripts, and
we had a few holydays.
The better is just to trop the select for -alsa module. I have already a fix on
my tree. I'll push it later today to my linux-next git repository.
>
> ERROR: "snd_pcm_period_elapsed" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined!
> ERROR: "snd_card_create" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined!
> ERROR: "snd_pcm_hw_constraint_integer" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined!
> ERROR: "snd_pcm_set_ops" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined!
> ERROR: "snd_pcm_lib_ioctl" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined!
> ERROR: "snd_card_free" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined!
> ERROR: "snd_card_register" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined!
> ERROR: "snd_pcm_new" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined!
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/media/video/cx231xx/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20090407.orig/drivers/media/video/cx231xx/Kconfig
> +++ linux-next-20090407/drivers/media/video/cx231xx/Kconfig
> @@ -6,7 +6,7 @@ config VIDEO_CX231XX
> select VIDEO_IR
> select VIDEOBUF_VMALLOC
> select VIDEO_CX25840
> - select VIDEO_CX231XX_ALSA
> + select VIDEO_CX231XX_ALSA if SND
>
> ---help---
> This is a video4linux driver for Conexant 231xx USB based TV cards.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers,
Mauro
prev parent reply other threads:[~2009-04-20 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 4:07 linux-next: Tree for April 7 Stephen Rothwell
2009-04-07 15:59 ` [PATCH -next] cx231xx: fix SND dependency build error Randy Dunlap
2009-04-20 19:44 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090420164449.34942436@pedra.chehab.org \
--to=mchehab@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).