From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: INET_LRO as tristate and use from modules Date: Wed, 22 Apr 2009 02:12:18 -0700 (PDT) Message-ID: <20090422.021218.92737677.davem@davemloft.net> References: <1240339984.9110.141.camel@subratamodak.linux.ibm.com> <20090421193319.GB20237@lixom.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090421193319.GB20237@lixom.net> Sender: netdev-owner@vger.kernel.org To: olof@lixom.net Cc: subrata@linux.vnet.ibm.com, netdev@vger.kernel.org, geoffrey.levand@am.sony.com, Linuxppc-dev@ozlabs.org, sfr@canb.auug.org.au, linux-next@vger.kernel.org, sachinp@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, themann@de.ibm.com List-Id: linux-next.vger.kernel.org From: Olof Johansson Date: Tue, 21 Apr 2009 14:33:19 -0500 > On Wed, Apr 22, 2009 at 12:23:03AM +0530, Subrata Modak wrote: >> MODPOST 338 modules >> ERROR: ".lro_receive_skb" [drivers/net/pasemi_mac_driver.ko] undefined! >> ERROR: ".lro_flush_all" [drivers/net/pasemi_mac_driver.ko] undefined! >> WARNING: modpost: Found 1 section mismatch(es). >> To see full details build your kernel with: >> 'make CONFIG_DEBUG_SECTION_MISMATCH=y' >> make[1]: *** [__modpost] Error 1 >> make: *** [modules] Error 2 > > This seems to be a problem with all tristate-capable drivers that use > LRO (and uses select INET_LRO in their Kconfig): INET_LRO is a tristate > and can thus be a module. Looks like it needs to be a bool instead? Yes, making this a bool would be the easiest fix. By why don't we get the same problem for PHYLIB? It's also tristate and "select"'d by a whole slew of networking drivers.