From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Sachin Sant" <sachinp@in.ibm.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
linux-s390@vger.kernel.org, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
"Ingo Molnar" <mingo@redhat.com>
Subject: Re: Next April 24: [S390] allmodconfig build failure (trace/events)
Date: Fri, 24 Apr 2009 10:41:08 +0200 [thread overview]
Message-ID: <20090424104108.0f2c0f05@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20090424072533.GE24912@elte.hu>
On Fri, 24 Apr 2009 09:25:33 +0200
Ingo Molnar <mingo@elte.hu> wrote:
>
> * Sachin Sant <sachinp@in.ibm.com> wrote:
>
> > Today's next tree build(s390 allmodconfig) failed with
> >
> > kernel/built-in.o: In function `trace_softirq_entry'
> > include/trace/events/irq.h:42: undefined reference to
> > `'
> > include/trace/events/irq.h:42: undefined reference to
> > `__tracepoint_softirq_entry'
> > kernel/built-in.o: In function `trace_softirq_exit':
> > include/trace/events/irq.h:48: undefined reference to
> > `__tracepoint_softirq_exit'
> > include/trace/events/irq.h:48: undefined reference to
> > `__tracepoint_softirq_exit'
>
> Hm, that's weird - s390 does not build kernel/softirq.o? Hm, it does
> - softirq.o is an obj-y object.
s390 does build kernel/softirq.o. However it's anything but obvious to
me how the tracepoint infrastructure works. Too many #ifdefs, #define's
and #undefine's...
I would expect that struct __tracepoint_softirq_entry somehow gets
defined via one of the TRACE_FORMAT macros, no?
kernel/softirq.i has these parts wrt. __tracepoint_softirq_entry:
# 42 "include/trace/events/irq.h"
extern struct tracepoint __tracepoint_softirq_entry; static inline __attribute__((always_inline)) void trace_softirq_entry(struc
t softirq_action *h, struct softirq_action *vec) { if (__builtin_expect(!!(__tracepoint_softirq_entry.state), 0)) do { void **it
_func; do { } while (0); it_func = ({ typeof((&__tracepoint_softirq_entry)->funcs) _________p1 = (*(volatile typeof((&__tracepoi
nt_softirq_entry)->funcs) *)&((&__tracepoint_softirq_entry)->funcs)); do { } while(0); (_________p1); }); if (it_func) { do { ((
void(*)(struct softirq_action *h, struct softirq_action *vec))(*it_func))(h, vec); } while (*(++it_func)); } do { } while (0); }
while (0); } static inline __attribute__((always_inline)) int register_trace_softirq_entry(void (*probe)(struct softirq_action
*h, struct softirq_action *vec)) { return tracepoint_probe_register("softirq_entry", (void *)probe); } static inline __attribute
__((always_inline)) int unregister_trace_softirq_entry(void (*probe)(struct softirq_action *h, struct softirq_action *vec)) { re
turn tracepoint_probe_unregister("softirq_entry", (void *)probe); };
extern struct tracepoint __tracepoint_softirq_exit; static inline __attribute__((always_inline)) void trace_softirq_exit(struct
softirq_action *h, struct softirq_action *vec) { if (__builtin_expect(!!(__tracepoint_softirq_exit.state), 0)) do { void **it_fu
nc; do { } while (0); it_func = ({ typeof((&__tracepoint_softirq_exit)->funcs) _________p1 = (*(volatile typeof((&__tracepoint_s
oftirq_exit)->funcs) *)&((&__tracepoint_softirq_exit)->funcs)); do { } while(0); (_________p1); }); if (it_func) { do { ((void(*
)(struct softirq_action *h, struct softirq_action *vec))(*it_func))(h, vec); } while (*(++it_func)); } do { } while (0); } while
(0); } static inline __attribute__((always_inline)) int register_trace_softirq_exit(void (*probe)(struct softirq_action *h, str
uct softirq_action *vec)) { return tracepoint_probe_register("softirq_exit", (void *)probe); } static inline __attribute__((alwa
ys_inline)) int unregister_trace_softirq_exit(void (*probe)(struct softirq_action *h, struct softirq_action *vec)) { return trac
epoint_probe_unregister("softirq_exit", (void *)probe); };
__do_softirq looks like below. So I would expect some header file include dependency? Dunno...
void __do_softirq(void)
{
struct softirq_action *h;
__u32 pending;
int max_restart = 10;
int cpu;
pending = ((*((struct _lowcore *) 0)).softirq_pending);
account_system_vtime(((struct task_struct *const)(*((struct _lowcore *) 0)).current_task));
__local_bh_disable((unsigned long)__builtin_return_address(0));
do { ((struct task_struct *const)(*((struct _lowcore *) 0)).current_task)->softirq_context++; } while (0);
cpu = ((*((struct _lowcore *) 0)).cpu_nr);
restart:
(((*((struct _lowcore *) 0)).softirq_pending) = (0));
do { trace_hardirqs_on(); raw_local_irq_enable(); } while (0);
h = softirq_vec;
do {
if (pending & 1) {
int prev_count = (current_thread_info()->preempt_count);
trace_softirq_entry(h, softirq_vec);
h->action(h);
trace_softirq_exit(h, softirq_vec);
if (__builtin_expect(!!(prev_count != (current_thread_info()->preempt_count)), 0)) {
printk("<3>" "huh, entered softirq %td %s %p"
"with preempt_count %08x,"
" exited with %08x?\n", h - softirq_vec,
softirq_to_name[h - softirq_vec],
h->action, prev_count, (current_thread_info()->preempt_count));
(current_thread_info()->preempt_count) = prev_count;
}
rcu_bh_qsctr_inc(cpu);
}
h++;
pending >>= 1;
} while (pending);
do { raw_local_irq_disable(); trace_hardirqs_off(); } while (0);
pending = ((*((struct _lowcore *) 0)).softirq_pending);
if (pending && --max_restart)
goto restart;
if (pending)
wakeup_softirqd();
do { ((struct task_struct *const)(*((struct _lowcore *) 0)).current_task)->softirq_context--; } while (0);
account_system_vtime(((struct task_struct *const)(*((struct _lowcore *) 0)).current_task));
_local_bh_enable();
}
next prev parent reply other threads:[~2009-04-24 8:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-24 5:04 linux-next: Tree for April 24 Stephen Rothwell
2009-04-24 6:55 ` Next April 24 : BUG: lock held at task exit time! Sachin Sant
2009-04-24 7:55 ` Stephen Rothwell
2009-04-24 11:55 ` Hugh Dickins
2009-04-24 14:04 ` Al Viro
2009-04-24 14:11 ` Stephen Rothwell
2009-04-24 7:12 ` Next April 24: [S390] allmodconfig build failure (trace/events) Sachin Sant
2009-04-24 7:25 ` Ingo Molnar
2009-04-24 8:41 ` Heiko Carstens [this message]
2009-04-29 9:51 ` Sachin Sant
2009-04-29 11:51 ` Heiko Carstens
2009-04-29 12:04 ` Ingo Molnar
2009-04-29 12:09 ` Steven Rostedt
[not found] ` <20090424150456.ff35e4ea.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2009-04-24 17:56 ` linux-next: Tree for April 24 (p54 build error) Randy Dunlap
2009-04-24 20:47 ` linux-next: Tree for April 24 (p54 build error) (and pull request: wireless-next-2.6 2009-04-24) Christian Lamparter
[not found] ` <200904242247.15042.chunkeey-S0/GAf8tV78@public.gmane.org>
2009-04-30 18:30 ` John W. Linville
2009-04-26 13:20 ` linux-next: Tree for April 24 Benny Halevy
2009-04-27 4:21 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090424104108.0f2c0f05@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sachinp@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).