linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: cifs tree build warning
@ 2009-05-01  3:28 Stephen Rothwell
  2009-05-01  4:04 ` Steve French
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2009-05-01  3:28 UTC (permalink / raw)
  To: Steve French, linux-cifs-client; +Cc: linux-next, Igor Mammedov

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Hi Steve,

Today's linux-next build (x86_64 allmodconfig) produced this warning:

fs/cifs/cifs_dfs_ref.c: In function 'cifs_dfs_follow_mountpoint':
fs/cifs/cifs_dfs_ref.c:345: warning: ISO C90 forbids mixed declarations and code

Introduced by commit 1af28ceb923d04357733642a3dbc4497da4db1c2 ("Enable
dfs submounts to handle remote referrals").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: cifs tree build warning
  2009-05-01  3:28 linux-next: cifs tree build warning Stephen Rothwell
@ 2009-05-01  4:04 ` Steve French
  2009-05-01  6:37   ` Stephen Rothwell
  0 siblings, 1 reply; 7+ messages in thread
From: Steve French @ 2009-05-01  4:04 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-cifs-client, linux-next, Igor Mammedov

On Thu, Apr 30, 2009 at 10:28 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Steve,
>
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>
> fs/cifs/cifs_dfs_ref.c: In function 'cifs_dfs_follow_mountpoint':
> fs/cifs/cifs_dfs_ref.c:345: warning: ISO C90 forbids mixed declarations and code
>
> Introduced by commit 1af28ceb923d04357733642a3dbc4497da4db1c2 ("Enable
> dfs submounts to handle remote referrals").

Fixed - Igor had inverted two statements.


-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: cifs tree build warning
  2009-05-01  4:04 ` Steve French
@ 2009-05-01  6:37   ` Stephen Rothwell
  0 siblings, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2009-05-01  6:37 UTC (permalink / raw)
  To: Steve French; +Cc: linux-cifs-client, linux-next, Igor Mammedov

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

Hi Steve,

On Thu, 30 Apr 2009 23:04:22 -0500 Steve French <smfrench@gmail.com> wrote:
>
> Fixed - Igor had inverted two statements.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: cifs tree build warning
  2009-06-16  6:07 Stephen Rothwell
@ 2009-06-16 10:38 ` Jeff Layton
  0 siblings, 0 replies; 7+ messages in thread
From: Jeff Layton @ 2009-06-16 10:38 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Steve French, linux-next, linux-kernel

On Tue, 16 Jun 2009 16:07:51 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Steve,
> 
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
> 
> fs/cifs/dns_resolve.c: In function 'is_ip':
> fs/cifs/dns_resolve.c:42: warning: passing argument 1 of 'cifs_convert_address' discards qualifiers from pointer target type
> fs/cifs/cifsproto.h:77: note: expected 'char *' but argument is of type 'const char *'
> 
> Introduced by commit 1e68b2b2756fc3488ecbade5ad5f13302b3aaafc ("cifs: add
> new routine for converting AF_INET and AF_INET6 addrs").
> 

Known problem. The warning is pretty harmless (that variable doesn't
ever get changed). Once Steve commits the last patch in that series
the warning will go away.

-- 
Jeff Layton <jlayton@redhat.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* linux-next: cifs tree build warning
@ 2009-06-16  6:07 Stephen Rothwell
  2009-06-16 10:38 ` Jeff Layton
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2009-06-16  6:07 UTC (permalink / raw)
  To: Steve French; +Cc: linux-next, linux-kernel, Jeff Layton

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

Hi Steve,

Today's linux-next build (x86_64 allmodconfig) produced this warning:

fs/cifs/dns_resolve.c: In function 'is_ip':
fs/cifs/dns_resolve.c:42: warning: passing argument 1 of 'cifs_convert_address' discards qualifiers from pointer target type
fs/cifs/cifsproto.h:77: note: expected 'char *' but argument is of type 'const char *'

Introduced by commit 1e68b2b2756fc3488ecbade5ad5f13302b3aaafc ("cifs: add
new routine for converting AF_INET and AF_INET6 addrs").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: cifs tree build warning
  2009-05-01  3:47 Stephen Rothwell
@ 2009-05-01  4:05 ` Steve French
  0 siblings, 0 replies; 7+ messages in thread
From: Steve French @ 2009-05-01  4:05 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-cifs-client, linux-next

On Thu, Apr 30, 2009 at 10:47 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Steve,
>
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>
> fs/cifs/connect.c:2609: warning: 'CIFSNTLMSSPNegotiateSessSetup' defined but not used
> fs/cifs/connect.c:2943: warning: 'CIFSNTLMSSPAuthSessSetup' defined but not used
>
> Introduced by commit 20418acd6874792359b42c12d159f42f17593f34 ("[CIFS]
> Remove older session setup implementation") which removed the last users of

These are being rewritten and moved (probably to a new file ntlmssp.c) tomorrow.


-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] 7+ messages in thread

* linux-next: cifs tree build warning
@ 2009-05-01  3:47 Stephen Rothwell
  2009-05-01  4:05 ` Steve French
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2009-05-01  3:47 UTC (permalink / raw)
  To: Steve French, linux-cifs-client; +Cc: linux-next

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

Hi Steve,

Today's linux-next build (x86_64 allmodconfig) produced this warning:

fs/cifs/connect.c:2609: warning: 'CIFSNTLMSSPNegotiateSessSetup' defined but not used
fs/cifs/connect.c:2943: warning: 'CIFSNTLMSSPAuthSessSetup' defined but not used

Introduced by commit 20418acd6874792359b42c12d159f42f17593f34 ("[CIFS]
Remove older session setup implementation") which removed the last users
of these functions.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2009-06-16 10:38 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-01  3:28 linux-next: cifs tree build warning Stephen Rothwell
2009-05-01  4:04 ` Steve French
2009-05-01  6:37   ` Stephen Rothwell
2009-05-01  3:47 Stephen Rothwell
2009-05-01  4:05 ` Steve French
2009-06-16  6:07 Stephen Rothwell
2009-06-16 10:38 ` Jeff Layton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).