From: Sam Ravnborg <sam@ravnborg.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-next@vger.kernel.org, Jan Beulich <jbeulich@novell.com>,
Steven Whitehouse <swhiteho@redhat.com>
Subject: Re: [PATCH] nfs: fix build error in nfsroot with initconst
Date: Wed, 6 May 2009 06:40:56 +0200 [thread overview]
Message-ID: <20090506044056.GA23277@uranus.ravnborg.org> (raw)
In-Reply-To: <20090506133253.43409da9.sfr@canb.auug.org.au>
On Wed, May 06, 2009 at 01:32:53PM +1000, Stephen Rothwell wrote:
> Hi Sam,
>
> On Tue, 5 May 2009 13:11:14 +0200 Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > fix build error with latest kbuild adjustments to initconst.
> >
> > The commit a447c0932445f92ce6f4c1bd020f62c5097a7842 ("vfs: Use
> > const for kernel parser table") changed:
> >
> > static match_table_t __initdata tokens = {
> > to
> > static match_table_t __initconst tokens = {
> >
> > But the missing const causes popwerpc to fail with latest
> > updates to __initconst like this:
> >
> > fs/nfs/nfsroot.c:400: error: __setup_str_nfs_root_setup causes a section type conflict
> > fs/nfs/nfsroot.c:400: error: __setup_str_nfs_root_setup causes a section type conflict
> >
> > The bug is only present with kbuild-next.
> > Following patch has been build tested.
> >
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Steven Whitehouse <swhiteho@redhat.com>
> > Cc: Stephen Rothwell <sfr@canb.auug.org.au>
>
> I build tested this with the offending compilers, so
>
> Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> I also build tested with the updates to __initconst as well.
>
> > Please apply this either to your -next tree or preferably upstream.
>
> If you want to keep the __initconst changes in your tree, then you need
> the above in your tree as well ... (preferably before the __initconst
> changes).
I hope that Trond would pull it into his tree and get it
upstream.
But if this does not happen within a few days (or Trond says I should do so),
I will add it to the kbuild-next.git.
Sam
next prev parent reply other threads:[~2009-05-06 4:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 1:17 linux-next: kbuild tree build failure Stephen Rothwell
2009-05-05 6:35 ` Jan Beulich
2009-05-05 6:43 ` Sam Ravnborg
2009-05-05 7:04 ` Jan Beulich
2009-05-05 11:11 ` [PATCH] nfs: fix build error in nfsroot with initconst Sam Ravnborg
2009-05-05 12:48 ` Jan Beulich
2009-05-06 3:32 ` Stephen Rothwell
2009-05-06 4:40 ` Sam Ravnborg [this message]
2009-05-06 13:45 ` Trond Myklebust
2009-05-20 1:30 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090506044056.GA23277@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=Trond.Myklebust@netapp.com \
--cc=jbeulich@novell.com \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).