* linux-next: infiniband tree build failure
@ 2009-05-08 1:53 Stephen Rothwell
2009-05-08 4:36 ` [ofa-general] " Roland Dreier
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2009-05-08 1:53 UTC (permalink / raw)
To: Roland Dreier, general; +Cc: linux-next, Jack Morgenstein
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
Hi Roland,
Today's linux-next build (x86_64 allmodconfig) failed like this:
drivers/infiniband/hw/mlx4/mr.c: In function 'mlx4_ib_alloc_fast_reg_page_list':
drivers/infiniband/hw/mlx4/mr.c:242: error: label 'err_free_mfrpl' used but not defined
Caused by commit 88029ff3c862812b81745ae3d6557ede96e2d051 ("IB/mlx4:
Don't overwrite fast registration page list when posting work request").
Clearly not build tested :-(
I have used the version of the tree from next-20090507.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [ofa-general] linux-next: infiniband tree build failure
2009-05-08 1:53 linux-next: infiniband tree build failure Stephen Rothwell
@ 2009-05-08 4:36 ` Roland Dreier
0 siblings, 0 replies; 11+ messages in thread
From: Roland Dreier @ 2009-05-08 4:36 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: general, linux-next
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> drivers/infiniband/hw/mlx4/mr.c: In function 'mlx4_ib_alloc_fast_reg_page_list':
> drivers/infiniband/hw/mlx4/mr.c:242: error: label 'err_free_mfrpl' used but not defined
>
> Caused by commit 88029ff3c862812b81745ae3d6557ede96e2d051 ("IB/mlx4:
> Don't overwrite fast registration page list when posting work request").
> Clearly not build tested :-(
My fault for editing after applying the patch. Fixed now.
Thanks,
Roland
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: infiniband tree build failure
@ 2009-11-20 0:03 Stephen Rothwell
2009-11-20 0:19 ` Roland Dreier
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2009-11-20 0:03 UTC (permalink / raw)
To: Roland Dreier, general; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
Hi all,
Today's linux-next build (powerpc ppc64_defconfig) failed like this:
ERROR: ".__ipv6_addr_type" [drivers/infiniband/core/rdma_cm.ko] undefined!
I have used the version of the infiniband tree from next-20091119 for
today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: infiniband tree build failure
2009-11-20 0:03 Stephen Rothwell
@ 2009-11-20 0:19 ` Roland Dreier
2009-11-20 0:30 ` Sean Hefty
2009-11-20 0:34 ` Stephen Rothwell
0 siblings, 2 replies; 11+ messages in thread
From: Roland Dreier @ 2009-11-20 0:19 UTC (permalink / raw)
To: Stephen Rothwell, sean.hefty; +Cc: general, linux-next, linux-kernel
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>
> ERROR: ".__ipv6_addr_type" [drivers/infiniband/core/rdma_cm.ko] undefined!
>
> I have used the version of the infiniband tree from next-20091119 for
> today.
Sorry, will track it down. Sean this probably came from your patches,
any idea off the top of your head?
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: linux-next: infiniband tree build failure
2009-11-20 0:19 ` Roland Dreier
@ 2009-11-20 0:30 ` Sean Hefty
2009-11-20 0:43 ` Roland Dreier
2009-11-20 0:45 ` Roland Dreier
2009-11-20 0:34 ` Stephen Rothwell
1 sibling, 2 replies; 11+ messages in thread
From: Sean Hefty @ 2009-11-20 0:30 UTC (permalink / raw)
To: 'Roland Dreier', Stephen Rothwell
Cc: general, linux-next, linux-kernel
>Sorry, will track it down. Sean this probably came from your patches,
>any idea off the top of your head?
Off the top of my head, I'll guess that maybe we need to add something like
#if defined(CONFIG_IPv6) || defined(CONFIG_IPV6_MODULE)
to cma_check_linklocal() in cma.c. Does this build failure occur when IPv6 is
excluded?
- Sean
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: infiniband tree build failure
2009-11-20 0:30 ` Sean Hefty
@ 2009-11-20 0:43 ` Roland Dreier
2009-11-20 0:45 ` Roland Dreier
1 sibling, 0 replies; 11+ messages in thread
From: Roland Dreier @ 2009-11-20 0:43 UTC (permalink / raw)
To: Sean Hefty; +Cc: Stephen Rothwell, general, linux-next, linux-kernel
> Off the top of my head, I'll guess that maybe we need to add something like
> #if defined(CONFIG_IPv6) || defined(CONFIG_IPV6_MODULE)
Yes, makes sense, I'll throw that in.
- R.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: infiniband tree build failure
2009-11-20 0:30 ` Sean Hefty
2009-11-20 0:43 ` Roland Dreier
@ 2009-11-20 0:45 ` Roland Dreier
2009-11-20 0:52 ` Sean Hefty
1 sibling, 1 reply; 11+ messages in thread
From: Roland Dreier @ 2009-11-20 0:45 UTC (permalink / raw)
To: Sean Hefty; +Cc: Stephen Rothwell, general, linux-next, linux-kernel
OK, so I threw this into the ipv6 patch, I think it's right:
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index 71e616a..fbdd731 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -2083,6 +2083,7 @@ static int cma_get_port(struct rdma_id_private *id_priv)
static int cma_check_linklocal(struct rdma_dev_addr *dev_addr,
struct sockaddr *addr)
{
+#if defined(CONFIG_IPv6) || defined(CONFIG_IPV6_MODULE)
struct sockaddr_in6 *sin6;
if (addr->sa_family != AF_INET6)
@@ -2094,6 +2095,7 @@ static int cma_check_linklocal(struct rdma_dev_addr *dev_addr,
return -EINVAL;
dev_addr->bound_dev_if = sin6->sin6_scope_id;
+#endif
return 0;
}
^ permalink raw reply related [flat|nested] 11+ messages in thread* RE: linux-next: infiniband tree build failure
2009-11-20 0:45 ` Roland Dreier
@ 2009-11-20 0:52 ` Sean Hefty
0 siblings, 0 replies; 11+ messages in thread
From: Sean Hefty @ 2009-11-20 0:52 UTC (permalink / raw)
To: 'Roland Dreier'; +Cc: Stephen Rothwell, linux-next, linux-kernel
>OK, so I threw this into the ipv6 patch, I think it's right:
Looks correct - thanks.
>diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
>index 71e616a..fbdd731 100644
>--- a/drivers/infiniband/core/cma.c
>+++ b/drivers/infiniband/core/cma.c
>@@ -2083,6 +2083,7 @@ static int cma_get_port(struct rdma_id_private *id_priv)
> static int cma_check_linklocal(struct rdma_dev_addr *dev_addr,
> struct sockaddr *addr)
> {
>+#if defined(CONFIG_IPv6) || defined(CONFIG_IPV6_MODULE)
> struct sockaddr_in6 *sin6;
>
> if (addr->sa_family != AF_INET6)
>@@ -2094,6 +2095,7 @@ static int cma_check_linklocal(struct rdma_dev_addr
>*dev_addr,
> return -EINVAL;
>
> dev_addr->bound_dev_if = sin6->sin6_scope_id;
>+#endif
> return 0;
> }
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: infiniband tree build failure
2009-11-20 0:19 ` Roland Dreier
2009-11-20 0:30 ` Sean Hefty
@ 2009-11-20 0:34 ` Stephen Rothwell
1 sibling, 0 replies; 11+ messages in thread
From: Stephen Rothwell @ 2009-11-20 0:34 UTC (permalink / raw)
To: Roland Dreier; +Cc: sean.hefty, general, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
Hi Roland, Sean,
On Thu, 19 Nov 2009 16:19:29 -0800 Roland Dreier <rdreier@cisco.com> wrote:
>
>
> > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> >
> > ERROR: ".__ipv6_addr_type" [drivers/infiniband/core/rdma_cm.ko] undefined!
> >
> > I have used the version of the infiniband tree from next-20091119 for
> > today.
>
> Sorry, will track it down. Sean this probably came from your patches,
> any idea off the top of your head?
Big hint: IPV6 is not enabled in this config.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: infiniband tree build failure
@ 2009-04-29 4:01 Stephen Rothwell
2009-04-29 16:51 ` Roland Dreier
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2009-04-29 4:01 UTC (permalink / raw)
To: Roland Dreier, general; +Cc: linux-next, Stefan Roscher
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
Hi Roland,
Today's linux-next build (powerpc ppc64_defconfig) produced this new
warning:
drivers/infiniband/hw/ehca/hcp_phyp.c: In function 'hcp_galpas_ctor':
drivers/infiniband/hw/ehca/hcp_phyp.c:65: warning: assignment makes integer from pointer without a cast
Caused by commit 2bd93ed8b59d9bf8b918a0fa04be50482906c16b ("IB/ehca:
Remove unnecessary memory operations for userspace queue pairs").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: linux-next: infiniband tree build failure
2009-04-29 4:01 Stephen Rothwell
@ 2009-04-29 16:51 ` Roland Dreier
0 siblings, 0 replies; 11+ messages in thread
From: Roland Dreier @ 2009-04-29 16:51 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: general, linux-next, Stefan Roscher
> Today's linux-next build (powerpc ppc64_defconfig) produced this new
> warning:
>
> drivers/infiniband/hw/ehca/hcp_phyp.c: In function 'hcp_galpas_ctor':
> drivers/infiniband/hw/ehca/hcp_phyp.c:65: warning: assignment makes integer from pointer without a cast
>
> Caused by commit 2bd93ed8b59d9bf8b918a0fa04be50482906c16b ("IB/ehca:
> Remove unnecessary memory operations for userspace queue pairs").
Thanks for pointing this out. I rolled the below into the patch in
question, which should fix this.
diff --git a/drivers/infiniband/hw/ehca/hcp_phyp.c b/drivers/infiniband/hw/ehca/hcp_phyp.c
index fc3a245..b3e0e72 100644
--- a/drivers/infiniband/hw/ehca/hcp_phyp.c
+++ b/drivers/infiniband/hw/ehca/hcp_phyp.c
@@ -62,7 +62,7 @@ int hcp_galpas_ctor(struct h_galpas *galpas, int is_user,
if (ret)
return ret;
} else
- galpas->kernel.fw_handle = NULL;
+ galpas->kernel.fw_handle = 0;
galpas->user.fw_handle = paddr_user;
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2009-11-20 0:52 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-08 1:53 linux-next: infiniband tree build failure Stephen Rothwell
2009-05-08 4:36 ` [ofa-general] " Roland Dreier
-- strict thread matches above, loose matches on Subject: below --
2009-11-20 0:03 Stephen Rothwell
2009-11-20 0:19 ` Roland Dreier
2009-11-20 0:30 ` Sean Hefty
2009-11-20 0:43 ` Roland Dreier
2009-11-20 0:45 ` Roland Dreier
2009-11-20 0:52 ` Sean Hefty
2009-11-20 0:34 ` Stephen Rothwell
2009-04-29 4:01 Stephen Rothwell
2009-04-29 16:51 ` Roland Dreier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).