From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
linux-next@vger.kernel.org, Jan Beulich <jbeulich@novell.com>,
Steven Whitehouse <swhiteho@redhat.com>
Subject: Re: [PATCH] nfs: fix build error in nfsroot with initconst
Date: Wed, 20 May 2009 11:30:15 +1000 [thread overview]
Message-ID: <20090520113015.63334073.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20090506133253.43409da9.sfr@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1384 bytes --]
Hi Trond,
On Wed, 6 May 2009 13:32:53 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Tue, 5 May 2009 13:11:14 +0200 Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > fix build error with latest kbuild adjustments to initconst.
> >
> > The commit a447c0932445f92ce6f4c1bd020f62c5097a7842 ("vfs: Use
> > const for kernel parser table") changed:
> >
> > static match_table_t __initdata tokens = {
> > to
> > static match_table_t __initconst tokens = {
> >
> > But the missing const causes popwerpc to fail with latest
> > updates to __initconst like this:
> >
> > fs/nfs/nfsroot.c:400: error: __setup_str_nfs_root_setup causes a section type conflict
> > fs/nfs/nfsroot.c:400: error: __setup_str_nfs_root_setup causes a section type conflict
> >
> > The bug is only present with kbuild-next.
> > Following patch has been build tested.
> >
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Steven Whitehouse <swhiteho@redhat.com>
> > Cc: Stephen Rothwell <sfr@canb.auug.org.au>
>
> I build tested this with the offending compilers, so
>
> Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>
Any reason this has not appeared in the nfs (or Linus') tree yet?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2009-05-20 1:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 1:17 linux-next: kbuild tree build failure Stephen Rothwell
2009-05-05 6:35 ` Jan Beulich
2009-05-05 6:43 ` Sam Ravnborg
2009-05-05 7:04 ` Jan Beulich
2009-05-05 11:11 ` [PATCH] nfs: fix build error in nfsroot with initconst Sam Ravnborg
2009-05-05 12:48 ` Jan Beulich
2009-05-06 3:32 ` Stephen Rothwell
2009-05-06 4:40 ` Sam Ravnborg
2009-05-06 13:45 ` Trond Myklebust
2009-05-20 1:30 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090520113015.63334073.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=Trond.Myklebust@netapp.com \
--cc=jbeulich@novell.com \
--cc=linux-next@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).