From: Borislav Petkov <borislav.petkov@amd.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
dougthompson@xmission.com
Subject: Re: linux-next: Tree for May 20 (amd64_edac)
Date: Wed, 20 May 2009 18:41:12 +0200 [thread overview]
Message-ID: <20090520164112.GA29913@aftab> (raw)
In-Reply-To: <4A142CC9.4050904@oracle.com>
Hi,
On Wed, May 20, 2009 at 09:16:09AM -0700, Randy Dunlap wrote:
> Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20090519:
> >
> > Undropped tree:
> > edac-amd
> >
> > The edac-amd tree lost its build failure.
>
>
> When K8_NB is not enabled:
>
> drivers/built-in.o: In function `amd64_edac_init':
> amd64_edac.c:(.init.text+0x254f6): undefined reference to `cache_k8_northbridges'
> amd64_edac.c:(.init.text+0x25c38): undefined reference to `num_k8_northbridges'
ah, well, one dependency goes another one comes in :(. Thanks, will fix...
> Error with EDAC_AMD64 =y or =m.
> Error on both i386 and on x86_64.
>
>
> Comments on Kconfig for EDAC_AMD64:
>
> config EDAC_AMD64
> tristate "AMD64 (Opteron, Athlon64) K8, F10h, F11h"
> depends on EDAC_MM_EDAC && X86 && PCI
> default m
> help
> Support for error detection and correction on the AMD 64
> Families of Memory Controllers (K8, F10h and F11h)
>
>
> Does this actually apply to X86_32 or should the depends be on
> X86_64 instead of X86?
and since K8_NB depends on X86_64, this answers that question :).
> The default y on EDAC_MM_EDAC and default m on EDAC_AMD64 should
> be removed.
The reasoning behind those comes from Ingo: people who enable EDAC
should get the modules automatically on instead of going through the
different entries in the subtree. Which sounds kind of reasonable, no?
See
http://marc.info/?l=linux-kernel&m=124173363813847
for details.
> The 2 lines of help text should be indented by 2 spaces.
ok, will do.
> Would be Good to have the amd64_edac maintainer(s) email addresses
> in MAINTAINERS file, please.
This is coming up.
--
Regards/Gruss,
Boris.
Operating | Advanced Micro Devices GmbH
System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
Research | Geschäftsführer: Thomas M. McCoy, Giuliano Meroni
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
(OSRC) | Registergericht München, HRB Nr. 43632
next prev parent reply other threads:[~2009-05-20 16:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 7:08 linux-next: Tree for May 20 Stephen Rothwell
2009-05-20 16:16 ` linux-next: Tree for May 20 (amd64_edac) Randy Dunlap
2009-05-20 16:41 ` Borislav Petkov [this message]
2009-05-20 16:51 ` Randy Dunlap
2009-05-20 17:17 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090520164112.GA29913@aftab \
--to=borislav.petkov@amd.com \
--cc=dougthompson@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).