From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Paul Mundt <lethal@linux-sh.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH -next] v4l2: handle unregister for non-I2C builds
Date: Fri, 22 May 2009 17:55:54 +1000 [thread overview]
Message-ID: <20090522175554.19465733.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20090522054847.GB14059@linux-sh.org>
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
On Fri, 22 May 2009 14:48:47 +0900 Paul Mundt <lethal@linux-sh.org> wrote:
>
> On Mon, May 11, 2009 at 09:37:41AM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > Build fails when CONFIG_I2C=n, so handle that case in the if block:
> >
> > drivers/built-in.o: In function `v4l2_device_unregister':
> > (.text+0x157821): undefined reference to `i2c_unregister_device'
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> This patch still has not been applied as far as I can tell, and builds
> are still broken as a result, almost 2 weeks after the fact.
In fact there has been no updates to the v4l-dvb tree at all since
May 11. Mauro?
I have reverted the patch that caused the build breakage ... (commit
d5bc7940d39649210f1affac1fa32f253cc45a81 "V4L/DVB (11673): v4l2-device:
unregister i2c_clients when unregistering the v4l2_device").
[By the way, an alternative fix might be to just define
V4L2_SUBDEV_FL_IS_I2C to be zero if CONFIG_I2C and CONFIG_I2C_MODULE are
not defined (gcc should then just elide the offending code).]
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-05-22 7:56 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 6:14 linux-next: Tree for May 11 Stephen Rothwell
2009-05-11 11:46 ` Next May 11 : BUG during scsi initialization Sachin Sant
2009-05-11 11:52 ` Matthew Wilcox
2009-05-11 12:04 ` Sachin Sant
2009-05-11 12:21 ` Matthew Wilcox
2009-05-11 16:19 ` Sachin Sant
2009-05-11 16:25 ` Matthew Wilcox
2009-05-11 16:59 ` Sachin Sant
2009-05-12 4:57 ` Nick Piggin
2009-05-12 5:56 ` Stephen Rothwell
2009-05-12 5:59 ` Nick Piggin
2009-05-12 6:03 ` Stephen Rothwell
2009-05-12 6:52 ` Stephen Rothwell
2009-05-12 6:56 ` Nick Piggin
2009-05-14 8:30 ` Sachin Sant
2009-05-14 8:51 ` Pekka Enberg
2009-05-14 9:54 ` Sachin Sant
2009-05-14 9:59 ` Pekka Enberg
2009-05-14 10:01 ` Pekka Enberg
2009-05-14 11:46 ` Sachin Sant
2009-06-05 12:04 ` [Powerpc/SLQB] Next June 06 " Sachin Sant
2009-06-07 8:06 ` Pekka J Enberg
2009-06-08 12:12 ` Sachin Sant
2009-06-09 14:19 ` Nick Piggin
2009-06-12 5:44 ` Sachin Sant
2009-06-12 7:42 ` Nick Piggin
2009-06-12 8:08 ` Sachin Sant
2009-06-12 8:21 ` Nick Piggin
2009-06-12 8:25 ` Pekka Enberg
2009-06-12 8:35 ` Stephen Rothwell
2009-06-12 8:38 ` Pekka Enberg
2009-05-11 16:32 ` [PATCH -next] kvm: fix build error: add missing semi-colon Randy Dunlap
2009-05-12 8:31 ` Avi Kivity
2009-05-11 16:36 ` [PATCH -next] soc_camera: depends on I2C Randy Dunlap
2009-05-11 17:53 ` Guennadi Liakhovetski
2009-05-11 16:37 ` [PATCH -next] v4l2: handle unregister for non-I2C builds Randy Dunlap
2009-05-22 5:48 ` Paul Mundt
2009-05-22 7:55 ` Stephen Rothwell [this message]
2009-05-22 15:57 ` Randy Dunlap
2009-05-26 17:31 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090522175554.19465733.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=hverkuil@xs4all.nl \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).