From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH -next] v4l2: handle unregister for non-I2C builds Date: Tue, 26 May 2009 14:31:10 -0300 Message-ID: <20090526143110.6c7b2e5a@pedra.chehab.org> References: <20090511161442.3e9d9cb9.sfr@canb.auug.org.au> <4A085455.5040108@oracle.com> <20090522054847.GB14059@linux-sh.org> <20090522175554.19465733.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090522175554.19465733.sfr@canb.auug.org.au> Sender: linux-media-owner@vger.kernel.org To: Stephen Rothwell Cc: Paul Mundt , Randy Dunlap , linux-next@vger.kernel.org, LKML , linux-media@vger.kernel.org, Hans Verkuil List-Id: linux-next.vger.kernel.org Em Fri, 22 May 2009 17:55:54 +1000 Stephen Rothwell escreveu: > On Fri, 22 May 2009 14:48:47 +0900 Paul Mundt wrote: > > > > On Mon, May 11, 2009 at 09:37:41AM -0700, Randy Dunlap wrote: > > > From: Randy Dunlap > > > > > > Build fails when CONFIG_I2C=n, so handle that case in the if block: > > > > > > drivers/built-in.o: In function `v4l2_device_unregister': > > > (.text+0x157821): undefined reference to `i2c_unregister_device' > > > > > > Signed-off-by: Randy Dunlap > > > > This patch still has not been applied as far as I can tell, and builds > > are still broken as a result, almost 2 weeks after the fact. > > In fact there has been no updates to the v4l-dvb tree at all since > May 11. Mauro? Sorry, this email were got by a wrong filtering rule here. Only today I noticed it. Anyway, the tree were updated yesterday, with Randy's patch. Sorry for the mess. > > I have reverted the patch that caused the build breakage ... (commit > d5bc7940d39649210f1affac1fa32f253cc45a81 "V4L/DVB (11673): v4l2-device: > unregister i2c_clients when unregistering the v4l2_device"). > > [By the way, an alternative fix might be to just define > V4L2_SUBDEV_FL_IS_I2C to be zero if CONFIG_I2C and CONFIG_I2C_MODULE are > not defined (gcc should then just elide the offending code).] Cheers, Mauro