Hi Greg, On Wed, 20 Jan 2010 10:45:25 +1100 Stephen Rothwell wrote: > > On Tue, 19 Jan 2010 13:04:17 -0800 Greg KH wrote: > > > > On Tue, Jan 19, 2010 at 05:27:41PM +1100, Stephen Rothwell wrote: > > > > > > Today's linux-next build (powerpc ppc64_defconfig) produced this warning: > > > > > > drivers/base/cpu.c:264: warning: initialization from incompatible pointer type > > > drivers/base/cpu.c:265: warning: initialization from incompatible pointer type > > > > > > Introduced by commit 380567d3dc35a62f5cc0ec640a45dfc238238417 ("sysdev: > > > Convert node driver")? > > > > No, I don't think that patch causes the warning, I can't duplicate it > > here. > > > > I don't know what patch causes that problem, as I can't duplicate it in > > my tree at all. Maybe some 'const' patch snuck in from some other tree? > > > > strange, > > OK, if it is still there today, I will look deeper. I still get those warnings. The two referenced lines are added by the commit above. The relevant parts of the file (in the version I have) are: (lines 98 and 99) static CLASS_ATTR(probe, S_IWUSR, NULL, cpu_probe_store); static CLASS_ATTR(release, S_IWUSR, NULL, cpu_release_store); ... (lines 262-266) static struct sysdev_class_attribute *cpu_sysdev_class_attrs[] = { #ifdef CONFIG_ARCH_CPU_PROBE_RELEASE &class_attr_probe.attr, &class_attr_release.attr, #endif class_attr_probe.attr is a "struct attribute" not a "struct sysdev_class_attribute". -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/