From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: linux-next: build failure after merge of the driver-core tree Date: Tue, 16 Feb 2010 10:01:00 +0100 Message-ID: <20100216100100.55f5922f@hyperion.delvare> References: <20100216173926.b7a4d25c.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from poutre.nerim.net ([62.4.16.124]:49217 "EHLO poutre.nerim.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755492Ab0BPJBE (ORCPT ); Tue, 16 Feb 2010 04:01:04 -0500 In-Reply-To: <20100216173926.b7a4d25c.sfr@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: Greg KH , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner Hi Stephen, On Tue, 16 Feb 2010 17:39:26 +1100, Stephen Rothwell wrote: > After merging the driver-core tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/i2c/i2c-smbus.c:58: error: 'struct device' has no member named 'sem' > drivers/i2c/i2c-smbus.c:66: error: 'struct device' has no member named 'sem' > > Caused by commit 0819a881db29059d113fc5f019f7c489dea5937d from the > driver-core tree interacting with commit > 38f1e8aedf0a238d56fbcd3660fc140b50dbc89a ("i2c: Add SMBus alert support") > from the i2c tree. > > I have applied the following patch for today and will use it as a merge > fixup for the driver-core tree while necessary. Thanks for the heads up and the fix. Greg, is there an API I am supposed to use instead of accessing the device's semaphore/mutex directly? -- Jean Delvare